CERBERUS/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2026-08-04 06:40:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Keep a std::string in scope when accessing its c_str.

Browse source 
The std::string was being created and deleted in a single statement, so
its c_str pointer pointed to freed memory. This could be seen with

valgrind nmap --exclude foo
This commit is contained in:
david 2011-07-29 20:43:31 +00:00
parent 50ec56fa67
commit 262ec8f7d7
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
targets.cc
View file

@ -197,9 +197,9 @@ int load_exclude_string(addrset *excludelist, const char *s) {
begin = p;
while (*p != '\0' && *p != ',')
p++;
const char * addr = std::string(begin, p - begin).c_str();
if (!addrset_add_spec(excludelist,addr, o.af(), 1)){
fatal("Invalid address specification: %s", addr);
std::string addr_str = std::string(begin, p - begin);
if (!addrset_add_spec(excludelist, addr_str.c_str(), o.af(), 1)) {
fatal("Invalid address specification: %s", addr_str.c_str());
}
if (*p == '\0')
break;