All dialyzer errors fixed; dialyzer added to travis.yml

.travis.yml

@@ -8,3 +8,4 @@ script:
   - ./rebar3 compile
   - ./rebar3 xref
   - ./rebar3 eunit
+  - ./rebar3 dialyzer

src/gen_timeout.erl

@@ -18,7 +18,7 @@
 -export_type([tout/0, opts/0]).
 
 -record(timeout,
-        {ref :: reference(),
+        {ref :: reference() | undefined,
          last_bump :: integer(),
          message :: any(),
          unit = second :: erlang:time_unit(),

src/mtp_abridged.erl

@@ -13,6 +13,8 @@
          encode_packet/2]).
 -export_type([codec/0]).
 
+-dialyzer(no_improper_lists).
+
 -record(st,
         {buffer = <<>> :: binary()}).
 -define(MAX_PACKET_SIZE, 1 * 1024 * 1024).      % 1mb

src/mtp_down_conn.erl

@@ -76,7 +76,7 @@ shutdown(Conn) ->
     gen_server:cast(Conn, shutdown).
 
 %% To be called by upstream
--spec send(handle(), iodata()) -> ok.
+-spec send(handle(), iodata()) -> ok | {error, unknown_upstream}.
 send(Conn, Data) ->
     gen_server:call(Conn, {send, Data}, ?SEND_TIMEOUT * 2).
 

src/mtp_full.erl

@@ -16,6 +16,8 @@
          encode_packet/2]).
 -export_type([codec/0]).
 
+-dialyzer(no_improper_lists).
+
 -record(full_st,
         {decode_buf = <<>> :: binary(),
          enc_seq_no :: integer(),

src/mtp_handler.erl

@@ -45,7 +45,7 @@
          codec :: mtp_codec:codec() | undefined,
 
          down :: mtp_down_conn:handle() | undefined,
-         dc_id :: {DcId :: integer(), Pool :: pid()},
+         dc_id :: {DcId :: integer(), Pool :: pid()} | undefined,
 
          ad_tag :: binary(),
          addr :: mtp_config:netloc(),           % IP/Port of remote side

src/mtp_intermediate.erl

@@ -15,6 +15,8 @@
          encode_packet/2]).
 -export_type([codec/0]).
 
+-dialyzer(no_improper_lists).
+
 -record(int_st,
         {padding = false :: boolean(),
          buffer = <<>> :: binary()}).

src/mtp_rpc.erl

@@ -13,6 +13,8 @@
          encode_ip_port/2]).
 -export_type([codec/0]).
 
+-dialyzer(no_improper_lists).
+
 -record(rpc_st,
         {client_addr :: binary(),
          proxy_addr :: binary(),
@@ -97,7 +99,7 @@ encode_packet({data, Msg}, {{ConnId, ClientAddr, ProxyTag}, ProxyAddr}) ->
 encode_packet(remote_closed, ConnId) ->
     <<?RPC_CLOSE_CONN, ConnId:64/little-signed>>.
 
-
+-spec encode_ip_port(inet:ip_address(), inet:port_number()) -> iodata().
 encode_ip_port(IPv4, Port) when tuple_size(IPv4) == 4 ->
     IpBin = inet_pton(IPv4),
     [lists:duplicate(10, <<0>>)