mirror of
https://github.com/kovidgoyal/kitty.git
synced 2026-07-10 09:43:26 +00:00
dc36e21654
A quick click-and-flick on a tab could leave all of kitty with mouse input permanently redirected to the tab bar, making every window unclickable and text selection impossible. Starting a tab drag is asynchronous: the drag thumbnail is rendered on the next frame before glfwStartDrag is called. If the button is released in that window, wl_data_device_start_drag is sent with a stale serial that no longer matches an active pointer implicit grab, so the compositor silently ignores it. The wl_data_source then never receives any event, on_drag_source_finished never runs, and the tab_being_dragged state is stuck forever, hijacking all mouse events. Fix in layers: - glfw/Wayland: track the implicit grab (serial of the first button press and pressed-button count), use that serial for start_drag and refuse with EAGAIN when there is no active implicit grab instead of letting the compositor silently drop the request - mouse.c: a left button release arriving while a tab drag is marked started but no system DND is active means the drag never launched (an active DND consumes the release on all platforms), so clear the drag state instead of waiting for DND events that will never come - tabs.py: handle OSError from start_drag_with_data for tab drags the same way window drags already do; clear the potential-drag state when the release lands on the new-tab button or empty tab bar area - tabs.py/boss.py: clear drag state on drag finish/drop even when the dragged tab has already been closed Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| backend_utils.c | ||
| backend_utils.h | ||
| cocoa_displaylink.m | ||
| cocoa_init.m | ||
| cocoa_joystick.h | ||
| cocoa_joystick.m | ||
| cocoa_monitor.m | ||
| cocoa_platform.h | ||
| cocoa_window.m | ||
| context.c | ||
| dbus_glfw.c | ||
| dbus_glfw.h | ||
| egl_context.c | ||
| egl_context.h | ||
| glfw.py | ||
| glfw3.h | ||
| glx_context.c | ||
| glx_context.h | ||
| ibus_glfw.c | ||
| ibus_glfw.h | ||
| init.c | ||
| input.c | ||
| internal.h | ||
| kwin-blur-v1.xml | ||
| linux_desktop_settings.c | ||
| linux_desktop_settings.h | ||
| linux_joystick.c | ||
| linux_joystick.h | ||
| linux_notify.c | ||
| linux_notify.h | ||
| main_loop.h | ||
| mappings.h | ||
| memfd.h | ||
| momentum-scroll.c | ||
| monitor.c | ||
| monotonic.c | ||
| nsgl_context.h | ||
| nsgl_context.m | ||
| null_init.c | ||
| null_joystick.c | ||
| null_joystick.h | ||
| null_monitor.c | ||
| null_platform.h | ||
| null_window.c | ||
| osmesa_context.c | ||
| osmesa_context.h | ||
| posix_thread.c | ||
| posix_thread.h | ||
| source-info.json | ||
| vulkan.c | ||
| window.c | ||
| wl_client_side_decorations.c | ||
| wl_client_side_decorations.h | ||
| wl_cursors.c | ||
| wl_cursors.h | ||
| wl_init.c | ||
| wl_monitor.c | ||
| wl_platform.h | ||
| wl_text_input.c | ||
| wl_text_input.h | ||
| wl_window.c | ||
| wlr-layer-shell-unstable-v1.xml | ||
| x11_init.c | ||
| x11_monitor.c | ||
| x11_platform.h | ||
| x11_window.c | ||
| xkb-compat-shim.h | ||
| xkb_glfw.c | ||
| xkb_glfw.h | ||