mirror of
https://github.com/kovidgoyal/kitty.git
synced 2026-11-16 13:08:25 +00:00
A full screen reverse scroll (ESC M at the top, CSI T) moves every image ref down a row. scroll_filter_func() only removed refs that left through the top, so a cell image on the bottom line ended up at row `lines`, off screen, while its line was discarded. The next forward scroll brought it back onto the bottom row, where the line has no placeholders. screen_render_line_graphics() returns early for such lines, so nothing removed the ref and a slice of the old image was drawn over the new text. tmux and pagers send ESC M when scrolling down, so this shows up in practice. Fix it by dropping cell image refs that move below the bottom margin, the same way the margins scroll path drops refs that leave the region. This replaces PR #10623, which was not merged for these reasons: - It does not find the cause. It removes cell image refs at render time for every line without placeholders, so the stale ref still exists and is still seen by anything that reads refs before the next render, such as graphics query and delete commands and the paused rendering path, which returns before the new code. - It costs time on every frame. Whenever any image is loaded, even with no placeholders at all, each clean visible line and each visible history line triggers a walk over all images and refs. Before, such lines cost nothing. This fix adds one comparison to a loop that only runs when the screen scrolls. Close #10623 |
||
|---|---|---|
| .. | ||
| _static | ||
| _templates | ||
| kittens | ||
| screenshots | ||
| actions.rst | ||
| basic.rst | ||
| binary.rst | ||
| build.rst | ||
| changelog.rst | ||
| clipboard.rst | ||
| color-stack.rst | ||
| conf.py | ||
| conf.rst | ||
| custom-shaders.rst | ||
| deccara.rst | ||
| desktop-notifications.rst | ||
| dnd-protocol.rst | ||
| extract-rst-targets.py | ||
| faq.rst | ||
| file-transfer-protocol.rst | ||
| glossary.rst | ||
| graphics-protocol.rst | ||
| index.rst | ||
| installer.sh | ||
| integrations.rst | ||
| intro_vid.rst | ||
| invocation.rst | ||
| keyboard-protocol.rst | ||
| kittens_intro.rst | ||
| launch.rst | ||
| layouts.rst | ||
| Makefile | ||
| mapping.rst | ||
| marks.rst | ||
| misc-protocol.rst | ||
| multiple-cursors-protocol.rst | ||
| notifications.py | ||
| open_actions.rst | ||
| overview.rst | ||
| performance.rst | ||
| pipe.rst | ||
| pointer-shapes.rst | ||
| press-mentions.rst | ||
| protocol-extensions.rst | ||
| quake-screenshots.rst | ||
| quickstart.rst | ||
| rc_protocol.rst | ||
| remote-control.rst | ||
| requirements.txt | ||
| sessions.rst | ||
| shell-integration.rst | ||
| support.html | ||
| support.rst | ||
| text-sizing-protocol.rst | ||
| underlines.rst | ||
| unscroll.rst | ||
| wide-gamut-colors.rst | ||