Merge branch 'fix/help-pager-fallback' of https://github.com/Xuyiyang23333/kitty

When kitten --help is run in a terminal and less is not available,
ShowHelpInPager silently discards the error from pager.Run(), resulting
in no output and a zero exit code. Fall back to writing help text
directly to stdout when the pager fails, matching the behavior of the
Python equivalent in kitty/cli.py which catches FileNotFoundError and
prints the text as a fallback.

Signed-off-by: Xuyiyang23333 <xuyiyang23333@gmail.com>

glfw/cocoa_window.m

@@ -4351,12 +4351,21 @@ add_uri_list_drag_items(_GLFWwindow *window, NSMutableArray<NSDraggingItem*>* dr
 
 static int
 add_drag_items(_GLFWwindow *window, NSMutableArray<NSDraggingItem*>* dragItems, GLFWDragSourceItem *mime_item, const GLFWimage *thumbnail) {
+    // URI list items get added directly to the clipboard for use by native apps since macOS does not support
+    // the text/uri-list MIME type, however this type remains as a private
+    // kitty type to enable kitty to kitty DnD for remote clients.
+    bool is_uri_list = false;
     if (strcmp(mime_item->mime_type, "text/uri-list") == 0 && mime_item->optional_data && mime_item->data_size) {
-        return add_uri_list_drag_items(window, dragItems, mime_item->optional_data, mime_item->data_size, mime_item->is_remote_client, thumbnail);
+        is_uri_list = true;
+        int err = add_uri_list_drag_items(window, dragItems, mime_item->optional_data, mime_item->data_size, mime_item->is_remote_client, thumbnail);
+        if (err != 0) return err;
     }
     NSString* utiString = mime_to_uti(mime_item->mime_type);
     id w;
-    if (mime_item->optional_data) {
+    // remote client URI list must be set a file promise so that the kitty drag
+    // source code receives a request for it and can then fetch the remote
+    // files.
+    if (mime_item->optional_data && !(is_uri_list && mime_item->is_remote_client)) {
         NSPasteboardItem *pbItem = [[[NSPasteboardItem alloc] init] autorelease];
         NSData *data = [NSData dataWithBytes:mime_item->optional_data length:mime_item->data_size];
         [pbItem setData:data forType:utiString];

tools/cli/help.go

@@ -131,7 +131,9 @@ func ShowHelpInPager(text string) {
 	pager.Stdin = strings.NewReader(text)
 	pager.Stdout = os.Stdout
 	pager.Stderr = os.Stderr
-	_ = pager.Run()
+	if err := pager.Run(); err != nil {
+		os.Stdout.WriteString(text)
+	}
 }
 
 func getDeterministicTimestamp() time.Time {