Commit graph

54 commits

Author SHA1 Message Date
Kovid Goyal
72c2b119c3
dnd kitten: Never create remote directories through a staged symlink
The fix for CVE-2026-54056 only made remote regular file creation
exclusive. A remote source could still send a symlink and then a
directory with the same name, as names were only de-duplicated on
case insensitive filesystems. CreateDirAt() would then follow the
symlink and the directory's children would be written outside the
staging directory.

Always de-duplicate names, create remote directories exclusively and
never follow symlinks when opening a newly created directory.
2026-11-19 12:48:00 +05:30
Kovid Goyal
b9e7070cc8
dnd kitten: Fix failure to start in a non-writable directory
Create the temporary directory used for staging drops lazily, on the first
drop, instead of at startup, so the kitten works in directories that are not
writable when nothing is dropped into them.

Fixes #10855
2026-11-12 18:54:46 +05:30
Kovid Goyal
9575920aab
Cleanup previous PR
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
Track move source identities in drop_status rather than parsed_uri, and
also compare birth times where available, so that a replacement reusing
the inode number of a deleted source is not removed. Clarify the
changelog entry.
2026-10-30 18:28:40 +05:30
Zhizhen He
7629533607 dnd: Only remove original sources after a local move 2026-10-30 20:29:16 +08:00
Kovid Goyal
f5c6ad38be
Cleanup previous PR 2026-10-30 14:24:59 +05:30
Zhizhen He
c370368a48 dnd: Reject local moves that merge back into a source 2026-10-30 14:32:13 +08:00
Kovid Goyal
02b2b10d10
Fix flaky test
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-29 22:05:37 +05:30
Kovid Goyal
1647103c57
Cleanup previous PR
- List the existing files that will be overwritten under the names they
  are stored as in the destination, not the dropped names
- Treat symlinks to directories in the destination as directories in
  find_overwrites, matching rename_contents, so the files that will be
  overwritten inside the symlink target are listed
- Replace an existing file or dangling symlink with a dropped directory
  instead of failing the drop after the user confirmed the overwrite
- Fail up front when a dropped file would replace an existing directory
- Also fold Unicode normalization when uniqifying remote drop names
- Probe for filesystem aliasing once before running the alias test
2026-10-29 21:41:44 +05:30
Zhizhen He
924dacc955
dnd: Detect filesystem aliases before overwrite confirmation 2026-10-29 23:55:24 +08:00
Kovid Goyal
40562972f4
Cleanup previous PR
Walk up from the drop destination using .. relative to its file
descriptor instead of its path, so the check is not fooled if the
destination is moved or replaced while the kitten is running. Also skip
the staging directory when copying, which guards against routes to it
the up-front check cannot see, such as bind mounts. Use readable
subtest names, check the chmod error in test cleanup and link the PR in
the changelog.
2026-10-29 17:32:35 +05:30
Zhizhen He
1a1495f564 dnd: Reject directory drops into their own descendants 2026-10-29 18:22:19 +08:00
Zhizhen He
ed4d37a9fa dnd: Skip local moves into the source directory 2026-10-28 20:36:04 +08:00
Kovid Goyal
c514311380
dnd: Use the existing conflict name template for local drops
Keeps conflict naming consistent between local and remote drops.
2026-10-28 17:38:44 +05:30
Zhizhen He
b7b29fe444 dnd: Preserve same-named local drop sources
Staging two entries with the same basename could fall back from a hard link to a truncating copy and overwrite the first source. Give each local source an unused staging name and use exclusive file and directory creation. Add regressions for files, directories, repeated paths, case conflicts, existing staging entries and symbolic links.
2026-10-28 19:45:51 +08:00
Hassan Raza
133aa8bb15
Add independent DnD copy mode 2026-08-27 20:37:01 +05:00
Hassan Raza
e304b3c1d8
Make DnD copies independent 2026-08-27 19:38:23 +05:00
Kovid Goyal
8996aa798c
dnd kitten: Create regular files with O_EXCL to avoid symlink attacks
Some checks failed
CI / Linux (python=3.13 cc=clang sanitize=1) (push) Has been cancelled
CI / Linux (python=3.11 cc=gcc sanitize=0) (push) Has been cancelled
CI / Linux (python=3.12 cc=gcc sanitize=1) (push) Has been cancelled
CI / Linux package (push) Has been cancelled
CI / Bundle test (macos-latest) (push) Has been cancelled
CI / Bundle test (ubuntu-latest) (push) Has been cancelled
CI / macOS Brew (push) Has been cancelled
CI / Test ./dev.sh and benchmark (push) Has been cancelled
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Has been cancelled
CodeQL / CodeQL-Build (c, macos-latest) (push) Has been cancelled
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Has been cancelled
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Has been cancelled
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Has been cancelled
Depscan / Scan dependencies for vulnerabilities (push) Has been cancelled
This is not really needed as the terminal emulator should be de
duplicating directory entries anyway but no harm in defense in depth.
2026-06-03 12:17:38 +05:30
copilot-swe-agent[bot]
7af3f4ee83
Refactor dnd kitten: track num_dropped_files instead of data_has_been_dropped
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/84513fee-68de-4504-b41b-e8643e0ea585

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-18 08:44:07 +00:00
Kovid Goyal
6da5bae945
Cleanup previous PR 2026-05-18 13:55:48 +05:30
copilot-swe-agent[bot]
9bb33ac25a
Address code review: clarify comments and simplify mime stripping
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/dd371733-fa08-484e-888a-8d0ebdadb853

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-18 07:59:00 +00:00
copilot-swe-agent[bot]
d5a6c072d9
Add data URI support to dnd kitten parse_uri_list
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/dd371733-fa08-484e-888a-8d0ebdadb853

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-18 07:54:57 +00:00
Kovid Goyal
2a59bfe9a0
Dont request the same MIME type multiple times 2026-05-18 13:08:49 +05:30
Kovid Goyal
32e6e834a6
Some cleanups 2026-05-18 11:14:11 +05:30
copilot-swe-agent[bot]
8acb6e7ecb
Address review comments: rename variable and improve comments
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/41b8254d-fc79-4f41-9775-67d1ddfceb5b

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-14 02:53:15 +00:00
copilot-swe-agent[bot]
66dca3cde1
Fix dnd kitten: restrict drop to boxes matching drag source allowed operations
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/41b8254d-fc79-4f41-9775-67d1ddfceb5b

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-14 02:49:17 +00:00
Kovid Goyal
0cddb39d95
More work on dnd kitten 2026-05-08 22:23:29 +05:30
Kovid Goyal
5ec8c52025
... 2026-05-06 12:15:08 +05:30
Kovid Goyal
e024f33b70
... 2026-05-06 08:53:23 +05:30
copilot-swe-agent[bot]
13898e73f2
Implement --exit-on flag for dnd kitten
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/b6835902-79c3-4d14-9761-8633073db808

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-05 10:33:11 +00:00
copilot-swe-agent[bot]
fe6807c9b0
implement move deletion and add tests for dnd kitten drop
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/e2238746-2319-43e5-9b01-4899e7f06b50

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-05 09:37:50 +00:00
Kovid Goyal
9a3f3ed14e
... 2026-05-05 14:54:09 +05:30
Kovid Goyal
d70ec000ff
Start work on drag source implementation 2026-04-30 15:06:22 +05:30
Kovid Goyal
79bf7ef1a4
Cleanup previous PR 2026-04-30 09:23:22 +05:30
copilot-swe-agent[bot]
0615823d15
Add text/uri-list edge case tests and overwrite confirmation tests to dnd_kitten_drop
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/cc433db7-b78f-4174-a6a7-1ba6e51955ac

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-04-29 13:27:02 +00:00
Kovid Goyal
1d6f695140
More work on dnd kitten 2026-04-29 17:46:12 +05:30
Kovid Goyal
bd5fbad8eb
Avoid EMFILE errors when there are too many in flight data requests 2026-04-29 13:21:35 +05:30
Kovid Goyal
86c055d96a
More work on dnd kitten 2026-04-29 12:40:46 +05:30
Kovid Goyal
9a6f4c3fb8
More work on dnd kitten 2026-04-27 17:31:23 +05:30
Kovid Goyal
ffc39cabfd
code cleanup 2026-04-27 09:54:16 +05:30
Kovid Goyal
8c2c32a5a5
More work on the dnd kitten 2026-04-27 08:22:17 +05:30
Kovid Goyal
3e46fa9f81
More work on dnd kitten 2026-04-26 22:55:11 +05:30
Kovid Goyal
db2d5e0111
More work on dnd kitten 2026-04-26 21:07:28 +05:30
Kovid Goyal
151fb9220f
More work on dnd kitten 2026-04-26 20:45:41 +05:30
Kovid Goyal
20bd31db0b
Allow multiple drops on the dnd kitten 2026-04-26 18:42:14 +05:30
Kovid Goyal
eb6eb37613
Remove option used only for testing 2026-04-26 13:50:10 +05:30
Kovid Goyal
5146cb388b
Fix various minor bugs in copy folders 2026-04-25 13:02:27 +05:30
Kovid Goyal
0a384ffad4
DRYer 2026-04-24 15:15:03 +05:30
Kovid Goyal
0f81bca430
DRYer 2026-04-24 14:37:34 +05:30
Kovid Goyal
708987f0d9
... 2026-04-24 10:49:12 +05:30
Kovid Goyal
a47ec50d72
More work on the dnd kitten 2026-04-23 17:23:21 +05:30