CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-08-04 06:36:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Modernize Go code

Browse source
This commit is contained in:
Kovid Goyal 2026-03-10 14:47:41 +05:30
parent 3d13cf1ca5
commit eddaaed3e3
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
16 changed files with 64 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tools/utils/strings.go
View file

@ -69,11 +69,11 @@ func ScanFuncForSeparator(sep string) StringScannerScanFunc {
}
return func(data string) (remaining_data, token string) {
idx := strings.Index(data, sep)
if idx < 0 {
before, after, ok := strings.Cut(data, sep)
if !ok {
return "", data
}
return data[idx+len(sep):], data[:idx]
return after, before
}
}

19
tools/utils/style/colorspaces_bench_test.go
View file

@ -9,50 +9,50 @@ import (
// Benchmark color parsing functions to demonstrate performance
func BenchmarkParseOklch(b *testing.B) {
for i := 0; i < b.N; i++ {
for b.Loop() {
_, _ = parseOklch("0.5 0.1 180")
}
}
func BenchmarkParseLab(b *testing.B) {
for i := 0; i < b.N; i++ {
for b.Loop() {
_, _ = parseLab("50 0 0")
}
}
func BenchmarkParseColorHex(b *testing.B) {
for i := 0; i < b.N; i++ {
for b.Loop() {
_, _ = ParseColor("#ff0000")
}
}
func BenchmarkParseColorOklch(b *testing.B) {
for i := 0; i < b.N; i++ {
for b.Loop() {
_, _ = ParseColor("oklch(0.5 0.1 180)")
}
}
func BenchmarkParseColorLab(b *testing.B) {
for i := 0; i < b.N; i++ {
for b.Loop() {
_, _ = ParseColor("lab(50 0 0)")
}
}
func BenchmarkParseColorWithComment(b *testing.B) {
for i := 0; i < b.N; i++ {
for b.Loop() {
_, _ = ParseColor("oklch(0.5 0.1 180) # vibrant color")
}
}
// Benchmark the gamut mapping algorithm specifically
func BenchmarkOklchToSrgbGamutMap(b *testing.B) {
for i := 0; i < b.N; i++ {
for b.Loop() {
oklchToSrgbGamutMap(0.7, 0.4, 25) // Very saturated color requiring gamut mapping
}
}
func BenchmarkOklchToSrgbGamutMapInGamut(b *testing.B) {
for i := 0; i < b.N; i++ {
for b.Loop() {
oklchToSrgbGamutMap(0.5, 0.05, 180) // Already in gamut
}
}
@ -71,8 +71,7 @@ func BenchmarkParseManyColors(b *testing.B) {
"green",
}
b.ResetTimer()
for i := 0; i < b.N; i++ {
for b.Loop() {
for _, color := range colors {
_, _ = ParseColor(color)
}