From e6423bc05c21b142e4c19be1e8d90cb33573b6f8 Mon Sep 17 00:00:00 2001 From: rudolf-blue Date: Thu, 8 Oct 2026 22:40:36 -0400 Subject: [PATCH] Fix spacing edges in serialized launch args --- kitty/window.py | 6 +++--- kitty_tests/layout.py | 11 +++++++++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/kitty/window.py b/kitty/window.py index 5d6812429..a50d47821 100644 --- a/kitty/window.py +++ b/kitty/window.py @@ -685,11 +685,11 @@ class EdgeWidths: if self.left is not None: yield f'--spacing={prefix}-left={self.left}' if self.right is not None: - yield f'--spacing={prefix}-left={self.right}' + yield f'--spacing={prefix}-right={self.right}' if self.top is not None: - yield f'--spacing={prefix}-left={self.top}' + yield f'--spacing={prefix}-top={self.top}' if self.bottom is not None: - yield f'--spacing={prefix}-left={self.bottom}' + yield f'--spacing={prefix}-bottom={self.bottom}' class GlobalWatchers: diff --git a/kitty_tests/layout.py b/kitty_tests/layout.py index e93124993..a45d822df 100644 --- a/kitty_tests/layout.py +++ b/kitty_tests/layout.py @@ -7,6 +7,7 @@ from kitty.fast_data_types import BOTTOM_EDGE, LEFT_EDGE, RIGHT_EDGE, TOP_EDGE, from kitty.layout.base import blank_rects_for_window, layout_dimension, lgd from kitty.layout.interface import Fat, Grid, Horizontal, Splits, Stack, Tall, Vertical from kitty.layout.splits import Pair, SplitsLayoutOpts +from kitty.rc.set_spacing import parse_spacing_settings from kitty.types import WindowGeometry from kitty.window import EdgeWidths from kitty.window_list import WindowList, reset_group_id_counter @@ -1566,3 +1567,13 @@ class TestProportionalSplits(BaseTest): self.check_weights(q, dict.fromkeys((1, 2, 3), 1 / 3)) self.ae(q.balanced_add_window(4).horizontal, q.pairs_root.horizontal) self.check_weights(q, dict.fromkeys((1, 2, 3, 4), 0.25)) + + +class TestWindowHelpers(BaseTest): + def test_edge_widths_launch_args(self): + ew = EdgeWidths({'left': 1, 'right': 2, 'top': 3, 'bottom': 4}) + for prefix in ('padding', 'margin'): + args = list(ew.as_launch_args(prefix)) + self.ae(len(set(args)), 4) + self.ae(parse_spacing_settings(a.partition('=')[2] for a in args), { + f'{prefix}-left': 1, f'{prefix}-right': 2, f'{prefix}-top': 3, f'{prefix}-bottom': 4})