CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-10-21 12:42:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix empty hints selection handling

Browse source
This commit is contained in:
Hassan Raza 2026-08-28 11:49:17 +05:00
parent caf36a4072
commit e31a5e4e07
No known key found for this signature in database
2 changed files with 39 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
kittens/hints/main.py
View file

@ -366,6 +366,8 @@ def handle_result(args: list[str], data: dict[str, Any], target_window_id: int,
if m:
matches.append(m)
groupdicts.append(g)
if not matches:
return
joiner = data['multiple_joiner']
try:
is_int: int | None = int(joiner)

38
kitty_tests/hints.py
View file

@ -2,7 +2,7 @@
# License: GPL v3 Copyright: 2026, Kovid Goyal <kovid at kovidgoyal.net>
from typing import Any
from unittest.mock import Mock
from unittest.mock import Mock, patch
from kittens.hints.main import handle_result
@ -10,6 +10,42 @@ from .base import BaseTest
class TestHints(BaseTest):
def test_multiple_selection_actions(self):
for matches in ([], [''], ['alpha', 'beta']):
for joiner, expected in (('auto', 'alpha beta'), ('json', '[\n\t"alpha",\n\t"beta"\n]'), ('0', 'alpha'), ('-1', 'beta')):
with self.subTest(matches=matches, joiner=joiner):
boss: Any = Mock()
window = Mock()
boss.window_id_map = {1: window}
data = {
'customize_processing': '',
'type': 'word',
'programs': ['@', '*', '@test', '-'],
'match': matches,
'groupdicts': [{} for _ in matches],
'multiple_joiner': joiner,
}
with patch('kittens.hints.main.set_clipboard_string') as clipboard, patch('kittens.hints.main.set_primary_selection') as primary:
handle_result([], data, 1, boss)
if any(matches):
clipboard.assert_called_once_with(expected)
primary.assert_called_once_with(expected)
boss.set_clipboard_buffer.assert_called_once_with('test', expected)
window.paste_text.assert_called_once_with(expected)
else:
clipboard.assert_not_called()
primary.assert_not_called()
boss.set_clipboard_buffer.assert_not_called()
window.paste_text.assert_not_called()
def test_custom_handler_receives_empty_selection(self):
boss: Any = Mock()
custom_handler = Mock()
data = {'customize_processing': 'custom.py', 'type': 'word', 'match': [], 'groupdicts': [], 'extra_cli_args': ['extra']}
with patch('kittens.hints.main.load_custom_processor', return_value={'handle_result': custom_handler}):
handle_result([], data, 1, boss)
custom_handler.assert_called_once_with([], data, 1, boss, ['extra'])
def test_named_groups_are_passed_to_program(self):
boss: Any = Mock()
boss.window_id_map = {}