CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-10-21 20:52:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Wayland: Get rid of visibility change debounce since previous commit made it unnecessary

Browse source
This commit is contained in:
Kovid Goyal 2025-04-24 09:08:28 +05:30
parent 06716b8b85
commit c893440208
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
2 changed files with 6 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

33
kitty/glfw.c
View file

@ -2452,22 +2452,6 @@ is_layer_shell_supported(PyObject *self UNUSED, PyObject *args UNUSED) {
#endif
}
static void
do_os_visibility_change(id_type timer_id, void *d) {
id_type wid = (uintptr_t)d;
OSWindow *w = os_window_for_id(wid);
if (w && w->handle && w->debounce_visibility_changes.timer_id == timer_id) {
w->debounce_visibility_changes.timer_id = 0;
if (w->debounce_visibility_changes.set_visible) {
glfwShowWindow(w->handle);
w->needs_render = true;
w->keep_rendering_till_swap = 256; // try this many times
request_tick_callback();
} else glfwHideWindow(w->handle);
w->debounce_visibility_changes.last_change_at = monotonic();
}
}
static PyObject*
toggle_os_window_visibility(PyObject *self UNUSED, PyObject *args) {
unsigned long long wid;
@ -2478,17 +2462,12 @@ toggle_os_window_visibility(PyObject *self UNUSED, PyObject *args) {
bool is_visible = glfwGetWindowAttrib(w->handle, GLFW_VISIBLE) != 0;
if (set_visible == -1) set_visible = !is_visible;
else if (set_visible == is_visible) Py_RETURN_FALSE;
// Debouncing of toggle requests is needed because of buggy Wayland
// compositors: https://github.com/kovidgoyal/kitty/issues/8557
monotonic_t debounce_interval = ms_to_monotonic_t(250);
monotonic_t now = monotonic();
w->debounce_visibility_changes.set_visible = set_visible;
if (now - w->debounce_visibility_changes.last_change_at >= debounce_interval) {
do_os_visibility_change(0, (void*)(uintptr_t)w->id);
} else if (w->debounce_visibility_changes.timer_id == 0) {
w->debounce_visibility_changes.timer_id = add_main_loop_timer(
debounce_interval - (now - w->debounce_visibility_changes.last_change_at), false, do_os_visibility_change, (void*)(uintptr_t)w->id, NULL);
}
if (set_visible) {
glfwShowWindow(w->handle);
w->needs_render = true;
w->keep_rendering_till_swap = 256; // try this many times
request_tick_callback();
} else glfwHideWindow(w->handle);
Py_RETURN_TRUE;
}

5
kitty/state.h
View file

@ -314,11 +314,6 @@ typedef struct {
id_type last_focused_counter;
CloseRequest close_request;
bool is_layer_shell;
struct {
monotonic_t last_change_at;
bool set_visible;
id_type timer_id;
} debounce_visibility_changes;
} OSWindow;