From 9d41e7bbadee8b59a257d1a62d0e7b3b90ddc407 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 24 Jun 2026 03:40:53 +0000 Subject: [PATCH] Address code review: use url=None, add TypeError comment --- .github/workflows/ci.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.py b/.github/workflows/ci.py index cb02809ad..d82af4e68 100644 --- a/.github/workflows/ci.py +++ b/.github/workflows/ci.py @@ -116,12 +116,12 @@ def install_slang_compiler() -> None: version = release['tag_name'].lstrip('v') asset_name = f'slang-{version}-{os_name}-{arch}.tar.gz' - url = '' + url = None for asset in release['assets']: if asset['name'] == asset_name: url = asset['browser_download_url'] break - if not url: + if url is None: raise SystemExit(f'Could not find slang release asset: {asset_name}') install_dir = '/tmp/slang' @@ -131,6 +131,7 @@ def install_slang_compiler() -> None: try: tf.extractall(install_dir, filter='fully_trusted') except TypeError: + # filter parameter not supported on older Python versions tf.extractall(install_dir) pc_dir = os.path.join(install_dir, 'lib', 'pkgconfig')