CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-05-13 08:26:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid extra stat()

Browse source
This commit is contained in:
Kovid Goyal 2025-05-03 15:55:36 +05:30
parent a59a347903
commit 7ef2fe53e0
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
1 changed files with 10 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

25
kittens/diff/main.go
View file

@ -37,16 +37,9 @@ var conf *Config
var opts *Options
var lp *loop.Loop
func isdir(path string) bool {
if s, err := os.Stat(path); err == nil {
return s.IsDir()
}
return false
}
var temp_files []string
func resolve_path(path string) (ans string, err error) {
func resolve_path(path string) (ans string, is_dir bool, err error) {
var s fs.FileInfo
if s, err = os.Stat(path); err != nil {
return
@ -65,10 +58,10 @@ func resolve_path(path string) (ans string, err error) {
if _, err = io.Copy(dest, src); err != nil {
return
}
return dest.Name(), nil
return dest.Name(), false, nil
} else {
return path, nil
return path, s.IsDir(), nil
}
}
}
@ -158,20 +151,22 @@ func main(_ *cli.Command, opts_ *Options, args []string) (rc int, err error) {
if err != nil {
return 1, err
}
if isdir(left) != isdir(right) {
return 1, fmt.Errorf("The items to be diffed should both be either directories or files. Comparing a directory to a file is not valid.'")
}
defer func() {
for _, path := range temp_files {
os.Remove(path)
}
}()
if left, err = resolve_path(left); err != nil {
var left_is_dir, right_is_dir bool
if left, left_is_dir, err = resolve_path(left); err != nil {
return 1, err
}
if right, err = resolve_path(right); err != nil {
if right, right_is_dir, err = resolve_path(right); err != nil {
return 1, err
}
if left_is_dir != right_is_dir {
return 1, fmt.Errorf("The items to be diffed should both be either directories or files. Comparing a directory to a file is not valid.'")
}
lp, err = loop.New()
loop.MouseTrackingMode(lp, loop.BUTTONS_AND_DRAG_MOUSE_TRACKING)
if err != nil {