From 7c52f727dc09740b7993a4e9bc8d2dbb6561748f Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sun, 23 Nov 2025 12:48:14 +0530 Subject: [PATCH] Show file metadata based preview with an error message when preview fails to render --- kittens/choose_files/image_preview.go | 2 +- kittens/choose_files/preview.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/kittens/choose_files/image_preview.go b/kittens/choose_files/image_preview.go index 6a8d46886..6900c2e46 100644 --- a/kittens/choose_files/image_preview.go +++ b/kittens/choose_files/image_preview.go @@ -157,7 +157,7 @@ func (p *ImagePreview) Render(h *Handler, x, y, width, height int) { p.source_img = hd.img p.custom_metadata = hd.metadata if hd.err != nil { - p.render_err = NewErrorPreview(fmt.Errorf("Failed to render the preview with error: %w", hd.err)) + p.render_err = NewFileMetadataPreviewWithError(p.abspath, p.metadata, fmt.Errorf("Failed to render the preview with error: %w", hd.err)) } p.Render(h, x, y, width, height) return diff --git a/kittens/choose_files/preview.go b/kittens/choose_files/preview.go index da0827242..e2e7b4f0c 100644 --- a/kittens/choose_files/preview.go +++ b/kittens/choose_files/preview.go @@ -196,6 +196,7 @@ func NewFileMetadataPreviewWithError(abspath string, metadata fs.FileInfo, err e h, t := write_file_metadata(abspath, metadata, nil) ans := &MessagePreview{title: title, msg: h, trailers: t} lines := style.WrapTextAsLines(err.Error(), 30, style.WrapOptions{}) + ans.trailers = append(ans.trailers, "") ans.trailers = append(ans.trailers, lines...) return ans }