CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-08-30 05:19:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

When copying env for SSH sanitize problematic env vars

Browse source
This commit is contained in:
Kovid Goyal 2024-01-06 13:53:20 +05:30
parent e656a75d5e
commit 7427e65f60
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
kitty/window.py
View file

@ -171,6 +171,18 @@ class CwdRequest:
set_cwd_in_cmdline(reported_cwd, argv)
set_server_args_in_cmdline(server_args, argv, allocate_tty=not run_shell)
if env is not None:
# Assume env is coming from a local process so drop env
# vars that can cause issues when set on the remote host
if env.get('KITTY_KITTEN_RUN_MODULE') == 'ssh_askpass':
for k in ('KITTY_KITTEN_RUN_MODULE', 'SSH_ASKPASS', 'SSH_ASKPASS_REQUIRE'):
env.pop(k, None)
for k in (
'HOME', 'USER', 'TEMP', 'TMP', 'TMPDIR', 'PATH', 'PWD', 'OLDPWD', 'KITTY_INSTALLATION_DIR',
'HOSTNAME', 'SSH_AUTH_SOCK', 'SSH_AGENT_PID', 'KITTY_WINDOW_ID', 'KITTY_STDIO_FORWARDED',
'KITTY_PID', 'KITTY_PUBLIC_KEY', 'KITTY_WINDOW_ID', 'TERMINFO', 'XDG_RUNTIME_DIR', 'XDG_VTNR',
'XDG_DATA_DIRS', 'XAUTHORITY', 'EDITOR', 'VISUAL',
):
env.pop(k, None)
set_env_in_cmdline(env, argv, clone=False)
return ''
if not window.child_is_remote and (self.request_type is CwdRequestType.last_reported or window.at_prompt):