CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-10-21 20:52:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Handle drop leave events

Browse source
This commit is contained in:
Kovid Goyal 2026-02-22 13:44:19 +05:30
parent ca43d57cdf
commit 6d59469cf1
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
2 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
kitty/boss.py
View file

@ -1893,7 +1893,7 @@ class Boss:
if tm is not None:
tm.update_tab_bar_data()
def on_drop_move(self, os_window_id: int, x: int, y: int, from_self: bool) -> None:
def on_drop_move(self, os_window_id: int, x: int, y: int, from_self: bool, is_leave: bool) -> None:
if (tm := self.os_window_map.get(os_window_id)) is None:
return
if from_self:
@ -1901,10 +1901,10 @@ class Boss:
if tab_id and drag_started and (tab := self.tab_for_id(tab_id)):
central, tab_bar = viewport_for_window(os_window_id)[:2]
in_tab_bar = tab_bar.left <= x < tab_bar.right and tab_bar.top <= y < tab_bar.bottom
detach = not in_tab_bar or tab.os_window_id != tm.os_window_id
detach = not in_tab_bar or tab.os_window_id != tm.os_window_id or is_leave
change_drag_thumbnail(tab.os_window_id, 1 if detach else 0, detach)
for q in self.all_tab_managers:
is_dest = q is tm and (in_tab_bar or os_window_id != tab.os_window_id)
is_dest = q is tm and (in_tab_bar or os_window_id != tab.os_window_id) and not is_leave
q.on_tab_drop_move(tab_id, is_dest, x, y)
def on_drop(self, os_window_id: int, drop: dict[str, bytes] | int, from_self: bool, x: int, y: int) -> None:

7
kitty/glfw.c
View file

@ -731,14 +731,17 @@ on_drop(GLFWwindow *window, GLFWDropEvent *ev) {
os_window->last_drag_event.x = (int)(ev->xpos * os_window->viewport_x_ratio);
os_window->last_drag_event.y = (int)(ev->ypos * os_window->viewport_y_ratio);
on_mouse_position_update(ev->xpos, ev->ypos);
call_boss(on_drop_move, "KiiO",
call_boss(on_drop_move, "KiiOO",
os_window->id, os_window->last_drag_event.x, os_window->last_drag_event.y,
ev->from_self ? Py_True : Py_False);
ev->from_self ? Py_True : Py_False, Py_False);
/* fallthrough */
case GLFW_DROP_STATUS_UPDATE:
update_allowed_mimes_for_drop(ev);
break;
case GLFW_DROP_LEAVE:
call_boss(on_drop_move, "KiiOO",
os_window->id, os_window->last_drag_event.x, os_window->last_drag_event.y,
ev->from_self ? Py_True : Py_False, Py_True);
break;
case GLFW_DROP_DROP:
Py_CLEAR(global_state.drop_dest.data);