From 65c777e335d8a0cc4a3d2515b80f90d6d6021b31 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Mon, 18 Sep 2023 22:09:46 +0530 Subject: [PATCH] Better error message for APC payload too large --- gen-apc-parsers.py | 2 +- kitty/parse-graphics-command.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gen-apc-parsers.py b/gen-apc-parsers.py index 1df9beb07..835e1230b 100755 --- a/gen-apc-parsers.py +++ b/gen-apc-parsers.py @@ -113,7 +113,7 @@ def generate( sz = screen->parser_buf_pos - pos; g.payload_sz = sizeof(payload); if (!base64_decode32(screen->parser_buf + pos, sz, payload, &g.payload_sz)) {{ - REPORT_ERROR("Failed to parse {command_class} command payload with error: %s", "output buffer for base64_decode too small"); return; }} + REPORT_ERROR("Failed to parse {command_class} command payload with error: payload size (%zu) too large", sz); return; }} pos = screen->parser_buf_pos; }} break; diff --git a/kitty/parse-graphics-command.h b/kitty/parse-graphics-command.h index 62b55a44a..12acdbc26 100644 --- a/kitty/parse-graphics-command.h +++ b/kitty/parse-graphics-command.h @@ -302,9 +302,9 @@ static inline void parse_graphics_code(Screen *screen, g.payload_sz = sizeof(payload); if (!base64_decode32(screen->parser_buf + pos, sz, payload, &g.payload_sz)) { - REPORT_ERROR( - "Failed to parse GraphicsCommand command payload with error: %s", - "output buffer for base64_decode too small"); + REPORT_ERROR("Failed to parse GraphicsCommand command payload with " + "error: payload size (%zu) too large", + sz); return; } pos = screen->parser_buf_pos;