CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-08-28 04:13:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Refuse to read image files in /proc /sys and /dev

Browse source 
Also, open the image file with O_NONBLOCK to ensure we dont hang opening
a FIFO
This commit is contained in:
Kovid Goyal 2023-05-25 12:17:03 +05:30
parent 20fbde447c
commit 624007c7aa
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
5 changed files with 58 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
docs/graphics-protocol.rst
View file

@ -284,7 +284,7 @@ and can take the values:
Value of `t` Meaning
================== ============
``d`` Direct (the data is transmitted within the escape code itself)
``f`` A simple file (regular files only, not named pipes or similar)
``f`` A simple file (regular files only, not named pipes, device files, etc.)
``t`` A temporary file, the terminal emulator will delete the file after reading the pixel data. For security reasons
the terminal emulator should only delete the file if it
is in a known temporary directory, such as :file:`/tmp`,
@ -302,7 +302,11 @@ Value of `t` Meaning
When opening files, the terminal emulator must follow symlinks. In case of
symlink loops or too many symlinks, it should fail and respond with an error,
similar to reporting any other kind of I/O error.
similar to reporting any other kind of I/O error. Since the file paths come
from potentially untrusted sources, terminal emulators **must** refuse to read
any device/socket/etc. special files. Only regular files are allowed.
Additionally, terminal emulators may refuse to read files in *sensitive*
parts of the filesystem, such as :file:`/proc`, :file:`/sys`, :file:`/dev/`, etc.
Local client
^^^^^^^^^^^^^^