From 6131f4cba79adccb513d26047b19f43ddfa9a58d Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sat, 28 Sep 2024 12:40:42 +0530 Subject: [PATCH] Close fds explicitly --- kitty/child.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kitty/child.c b/kitty/child.c index 492d935fb..c5879e399 100644 --- a/kitty/child.c +++ b/kitty/child.c @@ -136,7 +136,10 @@ spawn(PyObject *self UNUSED, PyObject *args) { int fd = PyLong_AsLong(pfd); if (fd > -1) { if (fd == min_closed_fd) min_closed_fd++; - else if (safe_dup2(fd, min_closed_fd++) == -1) exit_on_err("dup2() failed for forwarded fd 1"); + else { + if (safe_dup2(fd, min_closed_fd++) == -1) exit_on_err("dup2() failed for forwarded fd 1"); + safe_close(fd, __FILE__, __LINE__); + } } } if (forward_stdio) {