CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-05-13 08:26:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Disallow parsing color specs as conf files for clone-in-kitty and edit-in-kitty

Browse source
This commit is contained in:
Kovid Goyal 2026-04-26 10:47:24 +05:30
parent 2ead0de844
commit 5623ce52bb
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
4 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/changelog.rst
View file

@ -228,7 +228,7 @@ Detailed list of changes
- Password input in kittens: hide the cursor and display a blinking 🔒 at the end of typed characters to make it visually clear the user is entering a password
- edit-in-kitty: Ignore environment variables as some editors execute code present in env vars
- edit-in-kitty: Ignore environment variables as some editors execute code present in env vars. Similarly ignore conf file specifications for colors.
- Command palette :sc:`command_palette`: nicer grouping of aliases and combined actions (:pull:`9819`)

5
docs/shell-integration.rst
View file

@ -266,7 +266,7 @@ over SSH when using :doc:`kittens/ssh`.
The :command:`clone-in-kitty` command takes almost all the same arguments as the
:doc:`launch <launch>` command, so you can open a new tab instead or a new OS
window, etc. Arguments of launch that can cause code execution or that don't
window, etc. Arguments of launch that that don't
make sense when cloning are ignored. Most prominently, the following options are
ignored: :option:`--allow-remote-control <launch --allow-remote-control>`,
:option:`--copy-cmdline <launch --copy-cmdline>`, :option:`--copy-env <launch
@ -314,7 +314,8 @@ window, etc. Not all arguments are supported, see the discussion in the
In order to avoid remote code execution, kitty will only execute the configured
editor and pass the file path to edit to it and it will strip all environment
variables from the :command:`edit-in-kitty` command line.
variables from the :command:`edit-in-kitty` command line. Additionally, parsing
of colors is more limited, reading colors from config files is not allowed.
.. note:: To edit files using sudo the best method is to set the
:code:`SUDO_EDITOR` environment variable to ``kitten edit-in-kitty`` and