From 51b159f9900896182aa708e27db7fc9851a3e654 Mon Sep 17 00:00:00 2001 From: Egor Ignatov Date: Tue, 3 Nov 2026 20:36:29 +0500 Subject: [PATCH] Fix PNG dimension validation test on 32-bit platforms Expect OverflowError for dimensions that exceed sys.maxsize, since PyArg_ParseTuple rejects them before the PNG buffer validation runs. Continue to expect ValueError for invalid dimensions and buffer lengths that reach the validation code. --- kitty_tests/datatypes.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kitty_tests/datatypes.py b/kitty_tests/datatypes.py index 9eb089d69..0b3172116 100644 --- a/kitty_tests/datatypes.py +++ b/kitty_tests/datatypes.py @@ -116,7 +116,10 @@ class TestDataTypes(BaseTest): (rgba, 2**32 + 2, 2), (rgba, -2, -2), ): - with self.assertRaises(ValueError, msg=repr(args[1:])): + # Dimensions outside Py_ssize_t fail during argument parsing, before + # the buffer length and dimension validation can raise ValueError. + error = OverflowError if any(x > sys.maxsize for x in args[1:]) else ValueError + with self.assertRaises(error, msg=repr(args[1:])): png_from_32bit_rgba_data(*args) with self.assertRaises(OverflowError): png_from_32bit_rgba_data(rgba, 2, 2**64 + 2)