From 4ea6862dd33f7d111d0646cbcff8bb277199f67a Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Mon, 17 Nov 2025 17:23:40 +0530 Subject: [PATCH] Remove unused code --- kitty/disk-cache.c | 16 ++-------------- kitty/fast_data_types.pyi | 16 ---------------- 2 files changed, 2 insertions(+), 30 deletions(-) diff --git a/kitty/disk-cache.c b/kitty/disk-cache.c index 316b346f1..83e85bb65 100644 --- a/kitty/disk-cache.c +++ b/kitty/disk-cache.c @@ -775,6 +775,7 @@ disk_cache_num_cached_in_ram(PyObject *self_) { } +// The Python interface used only for testing {{{ #define PYWRAP(name) static PyObject* py##name(DiskCache *self, PyObject *args) #define PA(fmt, ...) if (!PyArg_ParseTuple(args, fmt, __VA_ARGS__)) return NULL; PYWRAP(ensure_state) { @@ -783,19 +784,6 @@ PYWRAP(ensure_state) { Py_RETURN_NONE; } -PYWRAP(read_from_cache_file) { - Py_ssize_t pos = 0, sz = -1; - PA("|nn", &pos, &sz); - mutex(lock); - if (sz < 0) sz = self->end_of_data_offset; - mutex(unlock); - PyObject *ans = PyBytes_FromStringAndSize(NULL, sz); - if (ans) { - read_from_cache_file(self, pos, sz, PyBytes_AS_STRING(ans)); - } - return ans; -} - static PyObject* wait_for_write(PyObject *self, PyObject *args) { double timeout = 0; @@ -913,7 +901,6 @@ num_cached_in_ram(PyObject *self, PyObject *args UNUSED) { #define MW(name, arg_type) {#name, (PyCFunction)py##name, arg_type, NULL} static PyMethodDef methods[] = { MW(ensure_state, METH_NOARGS), - MW(read_from_cache_file, METH_VARARGS), {"add", add, METH_VARARGS, NULL}, {"remove", pyremove, METH_VARARGS, NULL}, {"remove_from_ram", remove_from_ram, METH_O, NULL}, @@ -949,3 +936,4 @@ PyTypeObject DiskCache_Type = { INIT_TYPE(DiskCache) PyObject* create_disk_cache(void) { return new_diskcache_object(&DiskCache_Type, NULL, NULL); } +// }}} diff --git a/kitty/fast_data_types.pyi b/kitty/fast_data_types.pyi index aa0be1be5..b3681c2ba 100644 --- a/kitty/fast_data_types.pyi +++ b/kitty/fast_data_types.pyi @@ -1798,19 +1798,3 @@ class StreamingBase64Encodeer: def reset(self) -> bytes: ... # encode the specified data, return number of bytes written dest should be at least 4/3 *src + 2 bytes in size def encode_into(self, dest: WriteableBuffer, src: ReadableBuffer) -> int: ... - - - -class DiskCache: - small_hole_threshold: int - defrag_factor: int - @property - def total_size(self) -> int: ... - - def add(self, key: bytes, data: bytes) -> None: ... - def remove(self, key: bytes) -> bool: ... - def remove_from_ram(self, predicate: Callable[[bytes], bool]) -> int: ... - def num_cached_in_ram(self) -> int: ... - def get(self, key: bytes, store_in_ram: bool = False) -> bytes: ... # raises KeyError if not found - def end_of_data_offset(self) -> int: ... - def clear(self) -> None: ...