CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-07-09 01:11:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Ignore underline exclusion if max overlap is only half the thickness of the underline

Browse source 
This eliminates false positives for c and s with some fonts.
This commit is contained in:
Kovid Goyal 2025-01-15 11:51:33 +05:30
parent 8bf8f5dc46
commit 4e76a3d1c6
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
kitty/fonts.c
View file

@ -358,15 +358,24 @@ calculate_underline_exclusion_zones(pixel *buf, const FontGroup *fg, DecorationG
thickness = MAX(1u, thickness);
if (0) printf("dg: %u %u cell_height: %u scaled_cell_height: %u\n", dg.top, dg.height, fg->fcm.cell_height, scaled_metrics.cell_height);
if (0) { display_rgba_data(buf, fg->fcm.cell_width, fg->fcm.cell_height); printf("\n"); }
unsigned max_overlap = 0;
#define is_rendered(x, y) ((buf[(y) * fg->fcm.cell_width + (x)] & 0x000000ff) > 0)
for (unsigned x = 0; x < fg->fcm.cell_width; x++) {
for (unsigned y = dg.top; y < bottom && !ans[x]; y++) {
if ((buf[y * fg->fcm.cell_width + x] & 0x000000ff) > 0) {
if (is_rendered(x, y)) {
while (y + 1 < bottom && is_rendered(x, y + 1)) y++;
max_overlap = MAX(max_overlap, y - dg.top + 1);
unsigned start_x = x > thickness ? x - thickness : 0;
for (unsigned dx = start_x; dx < MIN(x + thickness, fg->fcm.cell_width); dx++) ans[dx] = 0xffffffff;
break;
}
}
}
#undef is_rendered
if (dg.height > 1 && max_overlap <= dg.height / 2) {
// ignore half thickness overlap as this is likely a false positive not an actual descender
memset(ans, 0, fg->fcm.cell_width * sizeof(ans[0]));
}
if (0) dump_sprite(ans, fg->fcm.cell_width, 1);
}