mirror of
https://github.com/kovidgoyal/kitty.git
synced 2026-11-19 06:35:15 +00:00
Fix stale Unicode placeholder images after a synchronized update
While rendering is paused, screen_update_cell_data() rendered the line graphics of the snapshot lines into the live graphics manager. Paused frames draw paused_rendering.grman, so those cell image refs were never shown during the pause, and after the pause they stayed at rows whose live lines had since scrolled or been overwritten: the live line has no placeholders, so screen_render_line_graphics() returns early and never removes them.
This commit is contained in:
parent
dedb3701fc
commit
36a560c3e7
1 changed files with 2 additions and 1 deletions
|
|
@ -4078,7 +4078,8 @@ screen_update_cell_data(Screen *self, void *address, FONTS_DATA_HANDLE fonts_dat
|
|||
linebuf_init_line(linebuf, y);
|
||||
if (linebuf->line->attrs.has_dirty_text) {
|
||||
render_line(fonts_data, linebuf->line, y, &self->paused_rendering.cursor, self->disable_ligatures, self->lc);
|
||||
screen_render_line_graphics(self, linebuf->line, y);
|
||||
// No screen_render_line_graphics() here: it writes to the live grman, but paused frames draw
|
||||
// paused_rendering.grman, so the refs would only outlive the pause over rows that no longer hold placeholders.
|
||||
if (linebuf->line->attrs.has_dirty_text && screen_has_marker(self)) mark_text_in_line(self->marker, linebuf->line, &self->as_ansi_buf);
|
||||
linebuf_mark_line_clean(linebuf, y);
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue