Commit graph

1136 commits

Author SHA1 Message Date
Cody Robibero
47ba387eb3
Merge pull request #17982 from Shadowghost/fix-similarity
Fix SimilarItemsManager concurrency
2026-09-13 11:56:42 -04:00
Cody Robibero
cabec7ec28
Merge pull request #17842 from Shadowghost/fix-multi-version
Fix versions of a video still listing separately from their group and preserve manual merges
2026-09-13 11:55:42 -04:00
Cody Robibero
8a37ce5a7e
Merge branch 'release-12.z' into fix-similarity 2026-09-12 13:48:09 -04:00
Shadowghost
028dcd0193 Use IODefaults.FileStreamBufferSize for similar items cache reads 2026-09-12 08:03:18 +02:00
Shadowghost
ad142ec30c Fix SimilarItemsManager concurrency 2026-09-11 12:48:42 +02:00
Shadowghost
911edfb64d Fix cross-library versions 2026-09-11 08:35:21 +02:00
Shadowghost
ca06ccfa13 Populate missing tags array in Filters2 2026-09-09 09:48:55 +02:00
Cody Robibero
85ebd83bdd
Merge pull request #17821 from Shadowghost/more-counts
Some checks are pending
CodeQL / Analyze (push) Waiting to run
Format / format-check (push) Waiting to run
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
OpenAPI Publish / OpenAPI - Publish Artifact (push) Waiting to run
OpenAPI Publish / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI Publish / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / main (push) Waiting to run
Expose optimized ItemCounts for byName items
2026-09-07 17:53:31 -04:00
Shadowghost
59cd5f983b Expose optimized ItemCounts for byName items 2026-09-07 10:30:01 +02:00
Shadowghost
fd016cfb13 Share played state across alternate versions 2026-09-06 17:20:18 +02:00
Cody Robibero
34feb3c04a
Merge pull request #17763 from Shadowghost/fix-refresh-queue-and-directory-cache
Fix items being lost from the refresh queue and bound the directory service caches
2026-09-06 07:36:13 -04:00
Shadowghost
7b638a22bb Add test 2026-09-06 09:07:22 +02:00
Shadowghost
344a6dcd2c Apply review suggestions 2026-09-06 08:38:43 +02:00
Cody Robibero
c80f05fad1
Merge pull request #17767 from Shadowghost/post-scna-task-logging
Some checks are pending
CodeQL / Analyze (push) Waiting to run
Format / format-check (push) Waiting to run
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
OpenAPI Publish / OpenAPI - Publish Artifact (push) Waiting to run
OpenAPI Publish / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI Publish / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / main (push) Waiting to run
Add comprehensive logging for post scan tasks
2026-09-04 21:13:54 -04:00
Shadowghost
46dd7d8e99 Invalidate the singleton DirectoryService cache on filesystem changes 2026-09-04 19:28:59 +02:00
Shadowghost
5edb369e3b Apply review suggestion 2026-09-04 07:02:08 +02:00
Shadowghost
b724e57458 Reduce comments 2026-09-03 11:51:02 +02:00
Shadowghost
f0297ee9ce Add comprehensive logging for post scan tasks 2026-09-02 09:26:41 +02:00
Shadowghost
d73e3d964e Optimize Caches
Co-Authored-By: Cody Robibero <cody@robibe.ro>
2026-09-02 07:06:08 +02:00
Shadowghost
50f08d41a4 Find dead people and artists by id, not by name 2026-09-01 19:49:25 +02:00
Shadowghost
792ce4a391 Fix people validator not creating missing people 2026-09-01 07:36:53 +02:00
Cody Robibero
0cec5661e0
Merge pull request #17752 from Shadowghost/fix-linkedchildren-recursive
Fix recursive handling for LinkedChildren
2026-08-31 17:47:33 -04:00
Cody Robibero
eafe5ba6ed
Merge pull request #17729 from Shadowghost/enforce-acl-similar-items
Some checks are pending
CodeQL / Analyze (push) Waiting to run
Format / format-check (push) Waiting to run
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
OpenAPI Publish / OpenAPI - Publish Artifact (push) Waiting to run
OpenAPI Publish / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI Publish / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / main (push) Waiting to run
Enforce permissions on similar items
2026-08-31 12:02:33 -04:00
Shadowghost
7ccce8e0e7 Fix recursive handling for LinkedChildren 2026-08-31 17:56:56 +02:00
Cody Robibero
9fe5a53e47
Merge commit from fork
Secure library paths
2026-08-30 14:40:16 -04:00
Cody Robibero
0d78e44633
Merge pull request #17739 from Shadowghost/simplify-search-query
Filter search candidates by user access in a single query
2026-08-30 13:29:59 -04:00
Shadowghost
07e97c0ee9 Filter search candidates by user access in a single query 2026-08-30 12:33:12 +02:00
Shadowghost
27d898e59e Count a season's episodes by the season they belong to 2026-08-29 21:39:14 +02:00
Shadowghost
ea5f83328d Support anime provider ids on season folders 2026-08-28 15:48:17 +02:00
Shadowghost
a45e66d43c Enforce permissions on similar items 2026-08-28 11:01:43 +02:00
Cody Robibero
f682c22b08
Merge pull request #17715 from Shadowghost/fix-people-cleanup
Delete credits nothing maps to and bound item-by-name folder names
2026-08-25 18:28:52 -04:00
Cody Robibero
e79e2cba27
Merge pull request #17714 from Shadowghost/fix-localized-view-ids
Stop deriving user view ids from their localized name
2026-08-25 18:26:09 -04:00
Shadowghost
a81b90f570 Fix tests 2026-08-25 21:03:51 +02:00
Shadowghost
6978dfc294 Delete a credit once no item maps to it any more 2026-08-25 20:31:30 +02:00
Shadowghost
0c560b22ce Secure library paths 2026-08-25 09:28:45 +02:00
Shadowghost
3fafdbc281 Say which image and item failed instead of logging a blank path 2026-08-24 22:12:57 +02:00
Cody Robibero
b2ba726635
Merge pull request #17691 from Shadowghost/fix-top-parent-fallback
Fall back to the ancestor filter when a view has no top parents
2026-08-22 08:49:39 -04:00
Shadowghost
4df580f0e8 Fall back to the ancestor filter when a view has no top parents 2026-08-21 20:40:52 +02:00
theguymadmax
80fe8c67e9 Fix latest items for mixed libraries 2026-08-19 18:34:21 -04:00
Cody Robibero
2a8d168796
Merge pull request #17579 from Shadowghost/fix-removal-notification
Fix missing ItemRemoved events and search fallback after access filtering
2026-08-10 18:28:22 -04:00
Cody Robibero
35e86416af
Merge pull request #17576 from obiwantoby/perf/batch-mediasourcecount-dto
Bugfix: #17547 | Batching MediaSourceCount into one call
2026-08-10 16:15:54 -04:00
TOomaAh
5f3e938d09 fix: bound remote provider pagination 2026-08-09 17:18:54 +02:00
brandon
10d108a1f4 Address review on MediaSourceCount batching
Rename GetItemsWithAlternateVersions to GetItemIdsWithAlternateVersions
across the interfaces and implementations since it returns ids. Return
the hashset straight from the query instead of materializing an array
first. Rename the DtoService guard to mayHaveAlternateVersions and
invert it so the computed path is the explicit case. Assert the media
source count value in the batch skip test and add a test covering an
item that is in the returned set still resolving to the correct count.
2026-08-08 12:33:11 -04:00
Shadowghost
e63c05137a Fix missing ItemRemoved events and search fallback after access filtering 2026-08-08 10:59:37 +02:00
brandon
c091ffdc6b Batch alternate version detection in DtoService to remove MediaSourceCount N+1
Browsing a page of videos with the MediaSourceCount field ran one alternate
version query per item, each opening a fresh DbContext. On a large library that
turned a single page into hundreds of sequential round trips and made the Items
endpoint take tens of seconds while holding a request thread the whole time.

Detect which videos own alternate versions once per page with a single query,
mirroring the existing people batch. Videos absent from that set have a single
media source, so the per item lookups are skipped for the common case. Behavior
is unchanged: a video with no alternates already resolved to a count of one.

Adds a regression test asserting the count resolves from the batch and the per
item lookups are never called.
2026-08-07 22:51:45 -04:00
brandon
d6da6906a4 Batch people lookups when building item DTOs
GetBaseItemDtos already batch fetches user data, child counts, played counts
and artists before its per item loop, but AttachPeople still ran one GetPeople
query per item. Rendering a page of items (for example a large playlist) fired
one extra query per row.

Add GetPeopleByItems to IPeopleRepository, which reads every requested item in a
single query over the people mapping table and returns full PersonInfo (role,
type and sort order) grouped by item id. GetBaseItemDtos prefetches this once
when the People field is requested and passes it into AttachPeople, which reads
from the batch instead of querying per item. The single item GetBaseItemDto path
keeps its existing per item behaviour when no batch is supplied.

Adds a DtoService test asserting people resolve from the batch and the per item
GetPeople is never called.
2026-08-07 11:59:17 -04:00
Cody Robibero
17b0453cfb
Merge pull request #17466 from Shadowghost/fix-byname-queries
Improve People deduplication, fix search and restrict ItemByName responses
2026-08-05 18:39:55 -04:00
Shadowghost
4e2089b6a1 Keep folder extras with the item that owns the folder 2026-08-03 10:50:33 +02:00
Shadowghost
8044534774 Merge remote-tracking branch 'upstream/master' into fix-byname-queries 2026-08-02 22:12:57 +02:00
Cody Robibero
24022092ad
Merge pull request #17456 from Shadowghost/fix-extras
Fix extras naming and version assignment
2026-08-02 14:25:00 -04:00