Enea D'Angiò
d36c8ebce8
Reduce cognitive complexity of RemoveFromPlaylist
2026-07-16 21:03:29 +02:00
Enea D'Angiò
6883cd0969
Fix play queue index handling in SyncPlay
...
Three index bugs in PlayQueueManager, two of which leave
PlayingItemIndex out of bounds, making every subsequent Buffering/Ready
request throw and leaving the group unusable until it empties:
- RemoveFromPlaylist did not compensate for removed items preceding the
playing item: removing the playing item together with earlier items
could select the wrong item or crash with an out-of-bounds index.
- Next/Previous on an empty playlist with RepeatOne/RepeatAll reported
success or set PlayingItemIndex to 0 on an empty list, crashing
downstream in Group and corrupting the index.
- SetPlayingItemByIndex accepted an index equal to the playlist count
(latent off-by-one, callers currently pre-validate).
2026-07-04 11:38:05 +02:00
jakobkukla
37350282cc
Run tree-wide dotnet format
2026-05-21 20:48:41 +02:00
Niels van Velzen
5e4bd744c0
Return SyncPlay group info after creation, add GET group endpoint ( #13935 )
2025-04-20 19:40:23 -06:00
Niels van Velzen
269508be9f
Fix SyncPlay WebSocket OpenAPI schemas ( #13946 )
2025-04-19 13:08:15 -06:00
Cody Robibero
9a0dfc00f1
Add all websocket messages to generated openapi spec ( #9682 )
...
* Add all websocket messages to generated openapi spec
* Use oneOf
* JsonIgnore ServerId
* Oops
* Add discriminators
* Add WebSocketMessage container for Inbound and Outbound messages
2023-06-10 07:28:21 -06:00
Stepan Goremykin
910617bbc3
Remove redundant 'else' keywords
2023-04-06 19:38:34 +02:00
Bond_009
52194f56b5
Replace != null with is not null
2022-12-05 15:01:13 +01:00
luz paz
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
cvium
b50c3852ef
Remove unused dependencies
2021-11-16 12:24:17 +01:00
Bond_009
dc8feca6bb
Remove duplicate Fisher–Yates shuffle impl
2021-10-08 15:20:11 +02:00
Claus Vium
00f7f68e53
Merge pull request #5648 from OancaAndrei/syncplay-sessions-fix
...
Fix session references in SyncPlay
2021-09-10 17:44:44 +02:00
Bond_009
0d16c48998
Fix some warnings
2021-09-09 15:59:13 +02:00
dkanada
f6c0db4bb5
merge branch 'master' into syncplay-sessions-fix
2021-09-06 13:42:48 +09:00
dkanada
5e3905d41a
merge branch 'master' into syncplay-clear-queue
2021-09-06 13:35:58 +09:00
Bond_009
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
2021-05-07 00:39:20 +02:00
Ionut Andrei Oanca
9eb740ba57
Fix storing outdated sessions in SyncPlay
2021-03-28 13:25:40 +02:00
Ionut Andrei Oanca
68969c9530
Clear playlist in SyncPlay group
2021-01-24 01:05:17 +01:00
Ionut Andrei Oanca
499f3ee950
Update authorization policies for SyncPlay
2020-12-07 10:33:15 +01:00
Ionut Andrei Oanca
cc64ee483d
Reorder parameters in HandleRequest
2020-12-04 23:16:15 +01:00
Ionut Andrei Oanca
cbf70e7a03
Change type of PlaylistItemId to Guid
2020-12-04 20:15:16 +01:00
Ionut Andrei Oanca
b7eb4da04e
Rename GroupController into Group
2020-12-03 21:01:18 +01:00
Ionut Andrei Oanca
7169c0a22d
Move SyncPlay request DTOs to proper namespace
2020-12-03 19:01:57 +01:00
Ionut Andrei Oanca
389367fec8
Rename 'track' into 'item' in SyncPlay
2020-12-03 15:54:39 +01:00
Ionut Andrei Oanca
78ea8ef99e
Create common interface for SyncPlay requests
2020-11-28 16:03:02 +01:00
Ionut Andrei Oanca
c60714e365
Move query parameters to request body in SyncPlay
2020-11-28 14:20:46 +01:00
Ionut Andrei Oanca
a3ca36cb54
Review logging and minor changes in SyncPlay
2020-11-16 20:05:57 +01:00
Ionut Andrei Oanca
c7e53bce2f
Patch data-races and minor changes in SyncPlay
2020-11-15 17:30:28 +01:00
Ionut Andrei Oanca
5d77f422f0
Hide some property setters, init null values, update namespaces
2020-11-14 23:40:01 +01:00
Ionut Andrei Oanca
fa69f6fd51
Handle ignore-wait request in waiting state in SyncPlay
2020-11-14 18:09:25 +01:00
Ionut Andrei Oanca
83333e1fe8
Replace foreach loop with FindIndex
2020-11-14 17:07:52 +01:00
Ionut Andrei Oanca
1dbc91978e
Address requested changes and fix some warnings
2020-11-14 12:33:54 +01:00
Ionut Andrei Oanca
563a6fb3c7
Minor changes to group-wait in SyncPlay
2020-11-13 20:55:14 +01:00
Ionut Andrei Oanca
019bc19aa4
Minor changes to play queue in Syncplay group
2020-10-22 16:32:15 +02:00
Ionut Andrei Oanca
0c735a0395
Address requested changes by review
2020-10-22 16:12:27 +02:00
Ionut Andrei Oanca
1cabe82b59
Rewrite play queue logic of SyncPlay group
2020-10-22 16:12:27 +02:00
BaronGreenback
f6ab98507e
Update MediaBrowser.Controller/SyncPlay/Queue/PlayQueueManager.cs
2020-10-22 13:29:09 +01:00
Ionut Andrei Oanca
36fee4e60a
Minor fixes
2020-10-21 16:42:57 +02:00
Ionut Andrei Oanca
93cbf64f88
End comments with a period
2020-10-21 15:46:50 +02:00
Ionut Andrei Oanca
8819a9d478
Add playlist-sync and group-wait to SyncPlay
2020-10-16 12:06:29 +02:00
gion
e10799e0e8
Rewrite syncplay using a state design pattern
2020-10-16 11:38:50 +02:00
gion
5487dfc145
Rename GroupInfoView to GroupInfoDto
2020-10-16 11:25:19 +02:00
Bond_009
f0556c8ded
Improve GroupInfo class
...
* Fixed docs
* Remove extra dictionary lookups
* change property to constant
2020-10-04 16:27:34 +02:00
Bond_009
404bb4f835
Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release
2020-08-22 21:56:24 +02:00
dkanada
5e706ba7ce
keep playstate during syncplay group creation
2020-07-13 06:55:03 +09:00
telans
247f9c61e6
fix SA1513/SA1516
2020-06-16 16:11:30 +12:00
telans
9b528aabc2
misc
2020-06-15 10:45:59 +12:00
gion
e42bfc92f3
Fix code issues
2020-05-26 11:37:52 +02:00
gion
5c8cbd4087
Fix code issues
2020-05-09 14:34:07 +02:00
gion
8a6ec2fb71
Rename Syncplay to SyncPlay
2020-05-09 12:37:39 +02:00