From eba577358eda29ebf55511d55dfb86c92a628fa5 Mon Sep 17 00:00:00 2001
From: limuthu123 <168603554+limuthu123@users.noreply.github.com>
Date: Sun, 31 May 2026 01:37:29 +0530
Subject: [PATCH] refactor: replace bare except blocks with Exception for
 better signal handling

---
 fail2ban/client/configparserinc.py | 4 ++--
 fail2ban/helpers.py                | 2 +-
 fail2ban/server/failregex.py       | 2 +-
 fail2ban/server/filter.py          | 2 +-
 fail2ban/server/filtersystemd.py   | 2 +-
 fail2ban/server/ipdns.py           | 4 ++--
 fail2ban/server/server.py          | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/fail2ban/client/configparserinc.py b/fail2ban/client/configparserinc.py
index 11b9a461..67ea9b28 100644
--- a/fail2ban/client/configparserinc.py
+++ b/fail2ban/client/configparserinc.py
@@ -202,11 +202,11 @@ after = 1.conf
 				rplcmnt = 1
 				try: # set it in map-vars (consider different python versions):
 					defaults[sopt] = v
-				except:
+				except Exception:
 					# try to set in first default map (corresponding vars):
 					try:
 						defaults._maps[0][sopt] = v
-					except: # pragma: no cover
+					except Exception: # pragma: no cover
 						# no way to update vars chain map - overwrite defaults:
 						self._defaults[sopt] = v
 		return rplcmnt
diff --git a/fail2ban/helpers.py b/fail2ban/helpers.py
index 00aca138..b3eb8ad2 100644
--- a/fail2ban/helpers.py
+++ b/fail2ban/helpers.py
@@ -36,7 +36,7 @@ import importlib
 try:
 	import ctypes
 	_libcap = ctypes.CDLL('libcap.so.2')
-except:
+except Exception:
 	_libcap = None
 
 
diff --git a/fail2ban/server/failregex.py b/fail2ban/server/failregex.py
index 85636f36..e016a1e4 100644
--- a/fail2ban/server/failregex.py
+++ b/fail2ban/server/failregex.py
@@ -94,7 +94,7 @@ R_MAP = {
 try:
 	re.search("^re(?i:val)$", "reVAL")
 	R_GLOB2LOCFLAGS = ( re.compile(r"(?<!\\)\((?:\?:)?(\(\?[a-z]+)\)"), r"\1:" )
-except:
+except Exception:
 	R_GLOB2LOCFLAGS = ()
 
 def mapTag2Opt(tag):
diff --git a/fail2ban/server/filter.py b/fail2ban/server/filter.py
index 44ed13b5..7ecf9023 100644
--- a/fail2ban/server/filter.py
+++ b/fail2ban/server/filter.py
@@ -1314,7 +1314,7 @@ try:
 		md5sum = hashlib.md5
 		# try to use it (several standards like FIPS forbid it):
 		md5sum(' ').hexdigest()
-	except: # pragma: no cover
+	except Exception: # pragma: no cover
 		md5sum = hashlib.sha1
 except ImportError: # pragma: no cover
 	# hashlib was introduced in Python 2.5.  For compatibility with those
diff --git a/fail2ban/server/filtersystemd.py b/fail2ban/server/filtersystemd.py
index 6bb9d466..0259b615 100644
--- a/fail2ban/server/filtersystemd.py
+++ b/fail2ban/server/filtersystemd.py
@@ -194,7 +194,7 @@ class FilterSystemd(JournalFilter): # pragma: systemd no cover
 				ja = self.__jrnlargs
 				super(journal.Reader, self.__journal).__init__(
 					ja.get('flags', 0), ja.get('path'), ja.get('files'), ja.get('namespace'))
-			except:
+			except Exception:
 				# cannot reopen in that way, so simply recreate reader:
 				self.closeJournal()
 				self.__journal = journal.Reader(**self.__jrnlargs)
diff --git a/fail2ban/server/ipdns.py b/fail2ban/server/ipdns.py
index 02e65194..b2389253 100644
--- a/fail2ban/server/ipdns.py
+++ b/fail2ban/server/ipdns.py
@@ -204,7 +204,7 @@ class DNSUtils:
 		# try to obtain from network interfaces if possible (implemented for this platform):
 		try:
 			ips = IPAddrSet([a for ni, a in DNSUtils._NetworkInterfacesAddrs()])
-		except:
+		except Exception:
 			ips = IPAddrSet()
 		# cache and return :
 		DNSUtils.CACHE_nameToIp.set(DNSUtils._getNetIntrfIPs_key, ips)
@@ -257,7 +257,7 @@ class DNSUtils:
 			with open('/proc/sys/net/ipv6/conf/all/disable_ipv6', 'rb') as f:
 				# if 1 - disabled, 0 - enabled
 				return not int(f.read())
-		except:
+		except Exception:
 			pass
 		s = None
 		try:
diff --git a/fail2ban/server/server.py b/fail2ban/server/server.py
index e438c4ca..5b7be07f 100644
--- a/fail2ban/server/server.py
+++ b/fail2ban/server/server.py
@@ -939,7 +939,7 @@ class Server:
 					os.close(fd)
 				except OSError:   # ERROR (ignore)
 					pass
-		except:
+		except Exception:
 			try:
 				maxfd = os.sysconf("SC_OPEN_MAX")
 			except (AttributeError, ValueError):