From 7a6eecbe219d42aed0d667f175e185e98159f134 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Thu, 9 May 2013 13:25:29 -0400 Subject: [PATCH] ENH: close open file in a test --- testcases/filtertestcase.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/testcases/filtertestcase.py b/testcases/filtertestcase.py index c1e91e74..1657f694 100644 --- a/testcases/filtertestcase.py +++ b/testcases/filtertestcase.py @@ -592,17 +592,19 @@ class GetFailures(unittest.TestCase): def testCRLFFailures01(self): # We first adjust logfile/failures to end with CR+LF fname = tempfile.mktemp(prefix='tmp_fail2ban', suffix='crlf') - f = open(fname, 'w') - for l in open(GetFailures.FILENAME_01).readlines(): - f.write('%s\r\n' % l.rstrip('\n')) - f.close() + # poor man unix2dos: + fin, fout = open(GetFailures.FILENAME_01), open(fname, 'w') + for l in fin.readlines(): + fout.write('%s\r\n' % l.rstrip('\n')) + fin.close() + fout.close() # now see if we should be getting the "same" failures self.testGetFailures01(filename=fname, failures=GetFailures.FAILURES_01[:3] + ([x.rstrip('\n') + '\r\n' for x in GetFailures.FAILURES_01[-1]],)) - _killfile(f, fname) + _killfile(fout, fname) def testGetFailures02(self):