diff --git a/caddytest/integration/caddyfile_adapt/reverse_proxy_handle_response_too_many_args.caddyfiletest b/caddytest/integration/caddyfile_adapt/reverse_proxy_handle_response_too_many_args.caddyfiletest new file mode 100644 index 000000000..5bc3121c3 --- /dev/null +++ b/caddytest/integration/caddyfile_adapt/reverse_proxy_handle_response_too_many_args.caddyfiletest @@ -0,0 +1,10 @@ +localhost:8884 { + reverse_proxy localhost:8000 { + handle_response header Foo { + respond "handled" + } + } +} + +---------- +parsing caddyfile tokens for 'reverse_proxy': too many arguments for 'handle_response': only a single response matcher name is allowed, but got: [header Foo] diff --git a/modules/caddyhttp/reverseproxy/caddyfile.go b/modules/caddyhttp/reverseproxy/caddyfile.go index 8716babe3..4661f8863 100644 --- a/modules/caddyhttp/reverseproxy/caddyfile.go +++ b/modules/caddyhttp/reverseproxy/caddyfile.go @@ -923,13 +923,8 @@ func (h *Handler) FinalizeUnmarshalCaddyfile(helper httpcaddyfile.Helper) error d.Next() args := d.RemainingArgs() - // TODO: Remove this check at some point in the future - if len(args) == 2 { - return d.Errf("configuring 'handle_response' for status code replacement is no longer supported. Use 'replace_status' instead.") - } - if len(args) > 1 { - return d.Errf("too many arguments for 'handle_response': %s", args) + return d.Errf("too many arguments for 'handle_response': only a single response matcher name is allowed, but got: %s", args) } var matcher *caddyhttp.ResponseMatcher