From 67cbd76beb220200602316d9a1532bf769cad4ee Mon Sep 17 00:00:00 2001 From: Varvara Dvortsova Date: Tue, 23 Jun 2026 16:07:56 +0300 Subject: [PATCH] logging: close file handle on permission errors when not rolling (#7833) --- modules/logging/filewriter.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/logging/filewriter.go b/modules/logging/filewriter.go index 0445ef06f..b47c00654 100644 --- a/modules/logging/filewriter.go +++ b/modules/logging/filewriter.go @@ -232,11 +232,13 @@ func (fw FileWriter) OpenWriter() (io.WriteCloser, error) { // Ensure already existing files have the right mode, since OpenFile will not set the mode in such case. if configuredMode := os.FileMode(fw.Mode); configuredMode != 0 { if err != nil { + file.Close() return nil, fmt.Errorf("unable to stat log file to see if we need to set permissions: %v", err) } // only chmod if the configured mode is different if info.Mode()&os.ModePerm != configuredMode&os.ModePerm { if err = os.Chmod(fw.Filename, configuredMode); err != nil { + file.Close() return nil, err } }