From 3b7bde8f25122a3a83ae0777e5bdce47f449e47d Mon Sep 17 00:00:00 2001
From: Rhul <143727980+vijayvenkatj@users.noreply.github.com>
Date: Fri, 5 Jun 2026 00:25:08 +0530
Subject: [PATCH] httpcaddyfile: error on duplicate named_routes (#7800)

* fix: error on duplicate named_routes

Fixes issue #7798

Validate named route names before inserting them into the
named route map.

This prevents later definitions from overwriting existing
named routes and returns an error when a route name is
defined more than once.

* test: add test for duplicate named_routes
---
 caddyconfig/httpcaddyfile/httptype.go            |  6 +++++-
 ...duplicate_named_route_challenge.caddyfiletest | 16 ++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 caddytest/integration/caddyfile_adapt/duplicate_named_route_challenge.caddyfiletest

diff --git a/caddyconfig/httpcaddyfile/httptype.go b/caddyconfig/httpcaddyfile/httptype.go
index 1c907572f..74cca4a4f 100644
--- a/caddyconfig/httpcaddyfile/httptype.go
+++ b/caddyconfig/httpcaddyfile/httptype.go
@@ -523,7 +523,11 @@ func (ServerType) extractNamedRoutes(
 			route.HandlersRaw = []json.RawMessage{caddyconfig.JSONModuleObject(handler, "handler", subroute.CaddyModule().ID.Name(), h.warnings)}
 		}
 
-		namedRoutes[sb.block.GetKeysText()[0]] = &route
+		key := sb.block.GetKeysText()[0]
+		if _, exists := namedRoutes[key]; exists {
+			return nil, fmt.Errorf("cannot have duplicate named_routes: %s", key)
+		}
+		namedRoutes[key] = &route
 	}
 	options["named_routes"] = namedRoutes
 
diff --git a/caddytest/integration/caddyfile_adapt/duplicate_named_route_challenge.caddyfiletest b/caddytest/integration/caddyfile_adapt/duplicate_named_route_challenge.caddyfiletest
new file mode 100644
index 000000000..f0e648830
--- /dev/null
+++ b/caddytest/integration/caddyfile_adapt/duplicate_named_route_challenge.caddyfiletest
@@ -0,0 +1,16 @@
+&(api) {
+	header X-Version v1
+	respond "API v1"
+}
+
+&(api) {
+	header X-Version v2
+	respond "API v2"
+}
+
+localhost {
+	invoke api
+}
+
+----------
+cannot have duplicate named_routes: api