From 0ccf820f87d46a08fb8b70ea30794caf9edbfba3 Mon Sep 17 00:00:00 2001 From: tomholford Date: Tue, 5 May 2026 18:23:39 -0700 Subject: [PATCH] caddyhttp: clarify WebTransportServer doc covers both disabled paths WebTransportServer returns nil for two distinct configurations: EnableWebTransport=false on the server, and HTTP/3 not in use. The prior doc only mentioned the latter. Spell out both, per review. --- modules/caddyhttp/server.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/caddyhttp/server.go b/modules/caddyhttp/server.go index c4d99d183..1319c8e1c 100644 --- a/modules/caddyhttp/server.go +++ b/modules/caddyhttp/server.go @@ -1196,7 +1196,8 @@ func (s *Server) Name() string { return s.name } // WebTransportServer returns the server's underlying WebTransport // serving state as an opaque value. Modules that import // github.com/quic-go/webtransport-go may type-assert it to -// *webtransport.Server. Returns nil if HTTP/3 is not in use. +// *webtransport.Server. Returns nil if WebTransport is not enabled +// on this server (EnableWebTransport=false or HTTP/3 is not in use). // // This is exposed as any so caddyhttp's public API does not leak the // upstream webtransport-go type to packages that don't use it.