LibreChat/api/server/middleware/optionalJwtAuth.spec.js
Marco Beretta 92432e95d5
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
🔐 feat: Enforce Required Two-Factor Authentication (#14731)
* feat: enforce required two-factor authentication

Require local and LDAP accounts to enroll in TOTP before they can use the
app when ENFORCE_TWO_FACTOR_AUTHENTICATION is set. Sign-in, refresh, bearer
verification, optional share auth and image authorization all route an
unenrolled account into a staged setup flow, and every bearer credential
minted before enrollment or a password reset is retired.

Password reset retirement uses the existing credentialsChangedAt stamp, and
commitPasswordReset clears any staged enrollment in the same write. Passkey
sign-in follows the same enrollment gate as password sign-in.

* test: cover passkey sign-in handing off to required enrollment

* refactor: keep Mongoose user types out of two-factor auth contracts

* fix: withdraw a minted session when its retirement recheck fails

* fix: hold Agent API keys and the reset CLI to the required two-factor policy

* fix: adopt a setup token handed off after the setup screen mounted

* fix: move every tab that receives an enrollment hand-off into setup

* fix: read the enrollment gate's retirement cutoff in system scope

* fix: clear minted session cookies before the fallible session deletion

* fix: adopt a setup token persisted before the setup screen subscribed
2026-10-01 23:39:51 +02:00

73 lines
2.6 KiB
JavaScript

const mockAuthenticate = jest.fn();
const mockTenantContextMiddleware = jest.fn((_req, _res, next) => next());
const mockIsTwoFactorEnrollmentRequired = jest.fn(() => false);
const mockClearCloudFrontCookies = jest.fn();
jest.mock('passport', () => ({
_strategy: jest.fn(() => undefined),
authenticate: (...args) => mockAuthenticate(...args),
}));
jest.mock('@librechat/api', () => ({
continueAfterOptionalAuth: jest.requireActual('@librechat/api').continueAfterOptionalAuth,
isEnabled: jest.fn(() => false),
clearCloudFrontCookies: (...args) => mockClearCloudFrontCookies(...args),
isTwoFactorEnrollmentRequired: (...args) => mockIsTwoFactorEnrollmentRequired(...args),
tenantContextMiddleware: (...args) => mockTenantContextMiddleware(...args),
}));
const optionalJwtAuth = require('./optionalJwtAuth');
const run = (user) => {
const req = { headers: {}, _mockUser: user };
const res = {};
const next = jest.fn();
optionalJwtAuth(req, res, next);
return { req, res, next };
};
describe('optionalJwtAuth', () => {
beforeEach(() => {
jest.clearAllMocks();
mockIsTwoFactorEnrollmentRequired.mockReturnValue(false);
mockAuthenticate.mockImplementation((_strategy, _options, callback) => {
return (req) => callback(null, req._mockUser ?? false);
});
});
it('establishes authenticated context when enrollment is not required', () => {
const user = { id: 'viewer-1', provider: 'local', twoFactorEnabled: true };
const { req, next } = run(user);
expect(req.user).toBe(user);
expect(req.authStrategy).toBe('jwt');
expect(mockTenantContextMiddleware).toHaveBeenCalledTimes(1);
expect(next).toHaveBeenCalledTimes(1);
});
it('treats a viewer with incomplete required enrollment as unauthenticated', () => {
const user = { id: 'viewer-required', provider: 'local', twoFactorEnabled: false };
mockIsTwoFactorEnrollmentRequired.mockReturnValue(true);
const { req, res, next } = run(user);
expect(req.user).toBeUndefined();
expect(req.authStrategy).toBeUndefined();
expect(mockClearCloudFrontCookies).toHaveBeenCalledWith(res, {
userId: 'viewer-required',
tenantId: undefined,
storageRegion: undefined,
});
expect(mockTenantContextMiddleware).not.toHaveBeenCalled();
expect(next).toHaveBeenCalledTimes(1);
});
it('continues anonymously when authentication does not resolve a user', () => {
const { req, next } = run(undefined);
expect(req.user).toBeUndefined();
expect(mockTenantContextMiddleware).not.toHaveBeenCalled();
expect(next).toHaveBeenCalledTimes(1);
});
});