LibreChat/packages/api/src/middleware/email.spec.ts
Cha 73c43ded25
💂 fix: Enforce ALLOW_EMAIL_LOGIN on the Backend Login Route (#14180)
* 🔒 fix: Enforce ALLOW_EMAIL_LOGIN on Backend Login Route

ALLOW_EMAIL_LOGIN=false previously only hid the login form; POST
/api/auth/login stayed mounted and accepted valid credentials. Add a
validateEmailLogin middleware (mirroring validateRegistration /
validatePasswordReset) that rejects login with 403 when the flag is
disabled, with an ALLOW_EMAIL_LOGIN_OVERRIDE escape hatch for
intentional direct API login (each use logged with request IP).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: Gate admin local login by email login flag

* fix: Move email login gate into api package

* test: Avoid mutating readonly request ip

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Danny Avila <danny@librechat.ai>
2026-07-09 09:55:36 -04:00

121 lines
3.5 KiB
TypeScript

import { logger } from '@librechat/data-schemas';
import type { NextFunction, Request, Response } from 'express';
import { validateEmailLogin } from './email';
jest.mock('@librechat/data-schemas', () => ({
...jest.requireActual('@librechat/data-schemas'),
logger: {
warn: jest.fn(),
},
}));
describe('validateEmailLogin', () => {
const originalEnv = {
ALLOW_EMAIL_LOGIN: process.env.ALLOW_EMAIL_LOGIN,
ALLOW_EMAIL_LOGIN_OVERRIDE: process.env.ALLOW_EMAIL_LOGIN_OVERRIDE,
};
let req: Request;
let res: Response;
let next: jest.MockedFunction<NextFunction>;
function createRequest(ip = '127.0.0.1'): Request {
return { ip } as Request;
}
beforeEach(() => {
delete process.env.ALLOW_EMAIL_LOGIN;
delete process.env.ALLOW_EMAIL_LOGIN_OVERRIDE;
req = createRequest();
res = {
status: jest.fn().mockReturnThis(),
json: jest.fn(),
} as Partial<Response> as Response;
next = jest.fn();
(logger.warn as jest.Mock).mockClear();
});
afterAll(() => {
for (const [key, value] of Object.entries(originalEnv)) {
if (value === undefined) {
delete process.env[key];
} else {
process.env[key] = value;
}
}
});
it('should allow login when ALLOW_EMAIL_LOGIN is unset (default)', () => {
validateEmailLogin(req, res, next);
expect(next).toHaveBeenCalled();
expect(res.status).not.toHaveBeenCalled();
});
it('should allow login when ALLOW_EMAIL_LOGIN is true', () => {
process.env.ALLOW_EMAIL_LOGIN = 'true';
validateEmailLogin(req, res, next);
expect(next).toHaveBeenCalled();
expect(res.status).not.toHaveBeenCalled();
});
it('should reject login with 403 when ALLOW_EMAIL_LOGIN is false', () => {
process.env.ALLOW_EMAIL_LOGIN = 'false';
validateEmailLogin(req, res, next);
expect(next).not.toHaveBeenCalled();
expect(res.status).toHaveBeenCalledWith(403);
expect(res.json).toHaveBeenCalledWith({ message: 'Email login is not allowed.' });
});
it('should log blocked login attempts with the request IP', () => {
process.env.ALLOW_EMAIL_LOGIN = 'false';
req = createRequest('10.0.0.42');
validateEmailLogin(req, res, next);
expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('10.0.0.42'));
});
it('should treat non-true values as disabled', () => {
process.env.ALLOW_EMAIL_LOGIN = 'no';
validateEmailLogin(req, res, next);
expect(next).not.toHaveBeenCalled();
expect(res.status).toHaveBeenCalledWith(403);
});
it('should allow login when disabled but ALLOW_EMAIL_LOGIN_OVERRIDE is true', () => {
process.env.ALLOW_EMAIL_LOGIN = 'false';
process.env.ALLOW_EMAIL_LOGIN_OVERRIDE = 'true';
validateEmailLogin(req, res, next);
expect(next).toHaveBeenCalled();
expect(res.status).not.toHaveBeenCalled();
});
it('should log override logins with the request IP', () => {
process.env.ALLOW_EMAIL_LOGIN = 'false';
process.env.ALLOW_EMAIL_LOGIN_OVERRIDE = 'true';
req = createRequest('10.0.0.42');
validateEmailLogin(req, res, next);
expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('ALLOW_EMAIL_LOGIN_OVERRIDE'));
expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('10.0.0.42'));
});
it('should ignore the override when email login is enabled', () => {
process.env.ALLOW_EMAIL_LOGIN_OVERRIDE = 'true';
validateEmailLogin(req, res, next);
expect(next).toHaveBeenCalled();
expect(logger.warn).not.toHaveBeenCalled();
});
});