mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-09-01 19:41:32 +00:00
6f05f2427b
`npx playwright install-deps chrome` is the third-most-common e2e failure: three of the last twenty-five Playwright runs died on it, taking the whole aggregate gate with them. The step is not installing anything CI needs. The runner's Chrome is an apt package, so apt has already satisfied every library Playwright lists — the log shows each one "already the newest version". All `install-deps` adds are decorative CJK/Thai/Cyrillic font packages, ~21MB pulled from azure.archive.ubuntu.com by seven jobs on every PR. No CI assertion depends on them: the only spec that screenshots gates its comparison behind `E2E_VISUAL_SNAPSHOTS`, which no workflow sets, and no baselines are committed. Keep the install, but demote it. `google-chrome --version` becomes its own fatal step so a genuinely missing browser still fails loudly and immediately, while the font install retries with a per-attempt cap and degrades to a warning. The Redis install in the list_changed job stays fatal — that one is required.
30 lines
1.2 KiB
Bash
Executable file
30 lines
1.2 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
#
|
|
# Installs Playwright's optional font packages for the `chrome` channel.
|
|
#
|
|
# The GitHub runner ships Chrome as an apt package, so every library Playwright
|
|
# lists is already satisfied by apt itself. The only packages `install-deps` adds
|
|
# are decorative CJK/Thai/Cyrillic fonts (~21MB) that no CI assertion depends on:
|
|
# the one spec that takes screenshots gates the comparison behind
|
|
# `E2E_VISUAL_SNAPSHOTS`, which CI never sets.
|
|
#
|
|
# Ubuntu's mirrors stall often enough that a hard failure here has repeatedly
|
|
# taken down whole e2e runs, so each attempt is capped and a final failure is
|
|
# only a warning. The workflow keeps `continue-on-error: true` as a backstop for
|
|
# the case where the step itself is killed by its timeout.
|
|
|
|
set -uo pipefail
|
|
|
|
readonly ATTEMPT_TIMEOUT_SECONDS=70
|
|
readonly MAX_ATTEMPTS=3
|
|
|
|
for attempt in $(seq 1 "${MAX_ATTEMPTS}"); do
|
|
if timeout "${ATTEMPT_TIMEOUT_SECONDS}" npx playwright install-deps chrome; then
|
|
exit 0
|
|
fi
|
|
echo "::warning::playwright install-deps attempt ${attempt}/${MAX_ATTEMPTS} failed or timed out"
|
|
sleep 5
|
|
done
|
|
|
|
echo "::warning::Optional Playwright font packages were not installed; continuing without them."
|
|
exit 0
|