mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-19 22:43:38 +00:00
* 🎚️ fix: Allow Opting Out of the MCP OAuth `resource` Parameter Adds `mcpServers.<name>.oauth.send_resource_parameter`, defaulting to true, so operators whose authorization server rejects RFC 8707 `resource` can complete the MCP OAuth flow. Suppression applies at send time only: Protected Resource Metadata is still discovered, still validated against the server URL (RFC 9728 §3.3) and still recorded on the stored client binding. * 🧹 chore: Drop Accidentally Tracked node_modules Symlinks Worktree-local symlinks were committed because .gitignore matches node_modules/ as a directory, not as a symlink of that name. They pointed outside the repository, so CI dependency installation failed and every downstream check with it. * 🧪 test: Cover the MCP OAuth `resource` Opt-Out at Token Exchange The authorization_code exchange reads the decision from flow metadata rather than live config, so a code obtained without `resource` is never exchanged with one. Covers both the opted-out flow and a flow initiated before the field existed, which must keep sending the parameter. * 💅 style: Apply Prettier to the Token Exchange Test * 🔒 fix: Make the MCP OAuth `resource` Opt-Out Actually Take Effect Addresses three Codex findings on the opt-out: - `startAuthorization` copies the configured `authorization_url` verbatim, so a `resource` an admin left in that URL survived into the request and Entra kept rejecting the flow. Opting out now deletes the parameter on both authorize paths instead of only declining to add one. - `.omit()` let a user-managed submission carrying `send_resource_parameter` parse successfully while discarding the field, so the opt-out was silently ignored. It is now `z.never().optional()`, matching the documented contract and the `audience` precedent. - A pending flow built with `resource` could be replayed for the full pending window after an operator set the option, reissuing the request they had just reconfigured away from. `isCurrentServerOAuthFlow` now compares the captured decision with live config. Stored tokens are unaffected, so changing the option still does not force re-authentication. * 🧯 fix: Suppress Inherited MCP OAuth `resource` and Stale Replays Addresses two further Codex findings on the opt-out: - The MCP SDK uses `token_endpoint` verbatim and the refresh paths post to the resolved token URL as-is, so a `resource` an admin left in `token_url` (or one on a discovered token endpoint) still reached the provider. The outbound URL is now sanitized at the exchange and in all three refresh paths. Stored metadata keeps its configured form so the client binding still matches. - Pending-flow replay was only guarded inside MCPConnectionFactory, so the browser initiate endpoint could still redirect to the stored URL. The shared pending helper now takes optional live config and refuses a replay whose captured decision no longer matches; the route passes it. * 🪤 fix: Scope the MCP OAuth `resource` Opt-Out to Paths It Can Serve Correctly The browser initiate route compared the pending flow against `resolveConfigServers`, which deliberately omits unmodified YAML servers (see `mcp/context.ts`). For the very config this option targets that read a captured `false` against `undefined`, reported drift on every initiation, and then returned 400 because factory-written flow states carry no `oauth` property to rebuild from. Reverted rather than patched: doing it right needs effective-config resolution behind a `packages/api` helper, per the `/api` wiring-only rule, and this sandbox cannot run that route suite. Retained and corrected: - The pending-flow guard no longer rides on `isCurrentServerOAuthFlow`, which also gates reuse of a recent COMPLETED flow. It was invalidating already-issued tokens, contradicting the promise that changing this option never forces re-authentication. Now a PENDING-only predicate at the two replay sites. - `ServerConfigsDB.sanitizeUserManagedOAuthConfig` strips `send_resource_parameter`, so a DB-backed or imported user config cannot activate the admin-only opt-out. --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|---|---|---|
| .. | ||
| src | ||
| types | ||
| .gitignore | ||
| babel.config.cjs | ||
| jest.config.mjs | ||
| jest.setup.cjs | ||
| package.json | ||
| tsconfig-paths-bootstrap.mjs | ||
| tsconfig.build.json | ||
| tsconfig.json | ||
| tsconfig.spec.json | ||
| tsdown.config.mjs | ||