mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-06-26 01:16:24 +00:00
* feat: Add granular access control to shared links via ACL system * fix(shared-links): preserve isPublic on failed migration grants Transient ACL failures during auto-migration permanently stranded links — $unset ran unconditionally, removing the legacy flag that triggers retry. Now only $unset isPublic after all grants succeed. * fix(config): skip isPublic unset for failed ACL grants Bulk migration unconditionally removed isPublic from all links, even those whose ACL writes failed. Failed links then lost the legacy marker needed for auto-migration retry. Now tracks failed link IDs per-batch and excludes them from the $unset step. Also adds sharedLink to AccessRole resourceType schema enum — was missing, only worked because seedDefaultRoles uses findOneAndUpdate which bypasses validation. * ci(config): add jest config and PR workflow for migration tests config/__tests__/ specs depend on api/jest.config.js module mappings but had no dedicated runner. Adds config/jest.config.js extending api config with absolutized paths, npm test:config script, and a GitHub Actions workflow triggered by changes to config/, api/models/, api/db/, or packages/ ACL code. * fix(permissions): honor boolean sharedLinks config SHARED_LINKS has no USE permission, so boolean config produced an empty update payload — gate conditions only matched object form, making `sharedLinks: false` a no-op on existing perms. * fix(share): resolve role before creating shared link Role lookup between create and grant left an orphaned link without ACL entries if getRoleByName threw — retry then hit "Share already exists" with no recovery path. * fix: Restore Public ACL Access Checks * fix: Type Public ACL Lookup * fix: Preserve Private Legacy Shared Links * chore: Promote Shared Link Permission Migration * fix: Address Shared Link Review Findings * fix: Repair Shared Link CI Follow-Up * fix: Narrow Shared Link Mongoose Test Mock * fix: Address Shared Link Review Follow-Ups * fix: Close Shared Link Review Gaps * fix: Guard Missing Shared Link Permission Backfill * test: Add Shared Link Mock E2E * test: Stabilize Shared Link Mock E2E --------- Co-authored-by: Danny Avila <danny@librechat.ai>
216 lines
6.5 KiB
JavaScript
216 lines
6.5 KiB
JavaScript
const mongoose = require('mongoose');
|
|
const express = require('express');
|
|
const {
|
|
isEnabled,
|
|
generateCheckAccess,
|
|
grantCreationPermissions,
|
|
ensureLinkPermissions,
|
|
deleteSharedLinkWithCleanup,
|
|
updateSharedLinkPermissionsExpiration,
|
|
isActiveExpirationDate,
|
|
getSharedLinkExpiration,
|
|
} = require('@librechat/api');
|
|
const { logger, createTempChatExpirationDate } = require('@librechat/data-schemas');
|
|
const { PermissionTypes, Permissions } = require('librechat-data-provider');
|
|
const {
|
|
getSharedMessages,
|
|
createSharedLink,
|
|
updateSharedLink,
|
|
getSharedLinks,
|
|
getSharedLink,
|
|
getRoleByName,
|
|
} = require('~/models');
|
|
const canAccessSharedLink = require('~/server/middleware/canAccessSharedLink');
|
|
const optionalJwtAuth = require('~/server/middleware/optionalJwtAuth');
|
|
const requireJwtAuth = require('~/server/middleware/requireJwtAuth');
|
|
const router = express.Router();
|
|
|
|
const checkSharedLinksAccess = generateCheckAccess({
|
|
permissionType: PermissionTypes.SHARED_LINKS,
|
|
permissions: [Permissions.CREATE],
|
|
getRoleByName,
|
|
});
|
|
|
|
const resolveSharedLinkExpiration = (req, conversationId) =>
|
|
getSharedLinkExpiration(
|
|
{ req, conversationId },
|
|
{
|
|
getConvo: async (userId, sourceConversationId) => {
|
|
const Conversation = mongoose.models.Conversation;
|
|
return Conversation.findOne(
|
|
{ conversationId: sourceConversationId, user: userId },
|
|
'isTemporary expiredAt',
|
|
).lean();
|
|
},
|
|
createExpirationDate: createTempChatExpirationDate,
|
|
logger,
|
|
},
|
|
);
|
|
|
|
/**
|
|
* Shared messages
|
|
*/
|
|
const allowSharedLinks =
|
|
process.env.ALLOW_SHARED_LINKS === undefined || isEnabled(process.env.ALLOW_SHARED_LINKS);
|
|
|
|
if (allowSharedLinks) {
|
|
router.get('/:shareId', optionalJwtAuth, canAccessSharedLink, async (req, res) => {
|
|
try {
|
|
const share = await getSharedMessages(req.params.shareId, req.shareResourceId);
|
|
if (share) {
|
|
res.status(200).json(share);
|
|
} else {
|
|
res.status(404).end();
|
|
}
|
|
} catch (error) {
|
|
logger.error('Error getting shared messages:', error);
|
|
res.status(500).json({ message: 'Error getting shared messages' });
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Shared links
|
|
*/
|
|
router.get('/', requireJwtAuth, async (req, res) => {
|
|
try {
|
|
const params = {
|
|
pageParam: req.query.cursor,
|
|
pageSize: Math.max(1, parseInt(req.query.pageSize) || 10),
|
|
sortBy: ['createdAt', 'title'].includes(req.query.sortBy) ? req.query.sortBy : 'createdAt',
|
|
sortDirection: ['asc', 'desc'].includes(req.query.sortDirection)
|
|
? req.query.sortDirection
|
|
: 'desc',
|
|
search: req.query.search ? decodeURIComponent(req.query.search.trim()) : undefined,
|
|
};
|
|
|
|
const result = await getSharedLinks(
|
|
req.user.id,
|
|
params.pageParam,
|
|
params.pageSize,
|
|
params.sortBy,
|
|
params.sortDirection,
|
|
params.search,
|
|
);
|
|
|
|
res.status(200).send({
|
|
links: result.links,
|
|
nextCursor: result.nextCursor,
|
|
hasNextPage: result.hasNextPage,
|
|
});
|
|
} catch (error) {
|
|
logger.error('Error getting shared links:', error);
|
|
res.status(500).json({
|
|
message: 'Error getting shared links',
|
|
error: error.message,
|
|
});
|
|
}
|
|
});
|
|
|
|
router.get('/link/:conversationId', requireJwtAuth, async (req, res) => {
|
|
try {
|
|
const share = await getSharedLink(req.user.id, req.params.conversationId);
|
|
|
|
if (share._id && share.success) {
|
|
await ensureLinkPermissions(share._id, req.user.id);
|
|
}
|
|
|
|
return res.status(200).json({
|
|
_id: share._id,
|
|
success: share.success,
|
|
shareId: share.shareId,
|
|
targetMessageId: share.targetMessageId,
|
|
conversationId: req.params.conversationId,
|
|
});
|
|
} catch (error) {
|
|
logger.error('Error getting shared link:', error);
|
|
res.status(500).json({ message: 'Error getting shared link' });
|
|
}
|
|
});
|
|
|
|
router.post('/:conversationId', requireJwtAuth, checkSharedLinksAccess, async (req, res) => {
|
|
try {
|
|
const { targetMessageId } = req.body;
|
|
const expiredAt = await resolveSharedLinkExpiration(req, req.params.conversationId);
|
|
if (expiredAt != null && !isActiveExpirationDate(expiredAt)) {
|
|
return res.status(404).end();
|
|
}
|
|
|
|
const role = await getRoleByName(req.user.role);
|
|
const sharedLinksPerms = role?.permissions?.[PermissionTypes.SHARED_LINKS] || {};
|
|
const grantPublic = sharedLinksPerms[Permissions.SHARE_PUBLIC] === true;
|
|
|
|
const created = await createSharedLink(
|
|
req.user.id,
|
|
req.params.conversationId,
|
|
targetMessageId,
|
|
expiredAt,
|
|
);
|
|
if (created) {
|
|
await grantCreationPermissions(created._id, req.user.id, grantPublic, expiredAt);
|
|
res.status(200).json(created);
|
|
} else {
|
|
res.status(404).end();
|
|
}
|
|
} catch (error) {
|
|
logger.error('Error creating shared link:', error);
|
|
res.status(500).json({ message: 'Error creating shared link' });
|
|
}
|
|
});
|
|
|
|
router.patch('/:shareId', requireJwtAuth, async (req, res) => {
|
|
try {
|
|
const { targetMessageId } = req.body ?? {};
|
|
if (targetMessageId !== undefined && typeof targetMessageId !== 'string') {
|
|
return res.status(400).json({ message: 'targetMessageId must be a string' });
|
|
}
|
|
|
|
let expiredAt;
|
|
const SharedLink = mongoose.models.SharedLink;
|
|
const existing = await SharedLink.findOne(
|
|
{ shareId: req.params.shareId, user: req.user.id },
|
|
'conversationId',
|
|
).lean();
|
|
if (existing?.conversationId) {
|
|
expiredAt = await resolveSharedLinkExpiration(req, existing.conversationId);
|
|
}
|
|
if (expiredAt != null && !isActiveExpirationDate(expiredAt)) {
|
|
return res.status(404).end();
|
|
}
|
|
|
|
const updatedShare = await updateSharedLink(
|
|
req.user.id,
|
|
req.params.shareId,
|
|
targetMessageId,
|
|
expiredAt,
|
|
);
|
|
if (updatedShare) {
|
|
if (updatedShare._id && expiredAt !== undefined) {
|
|
await updateSharedLinkPermissionsExpiration(updatedShare._id, expiredAt);
|
|
}
|
|
res.status(200).json(updatedShare);
|
|
} else {
|
|
res.status(404).end();
|
|
}
|
|
} catch (error) {
|
|
logger.error('Error updating shared link:', error);
|
|
res.status(500).json({ message: 'Error updating shared link' });
|
|
}
|
|
});
|
|
|
|
router.delete('/:shareId', requireJwtAuth, async (req, res) => {
|
|
try {
|
|
const result = await deleteSharedLinkWithCleanup(req.user.id, req.params.shareId);
|
|
|
|
if (!result) {
|
|
return res.status(404).json({ message: 'Share not found' });
|
|
}
|
|
|
|
return res.status(200).json(result);
|
|
} catch (error) {
|
|
logger.error('Error deleting shared link:', error);
|
|
return res.status(400).json({ message: 'Error deleting shared link' });
|
|
}
|
|
});
|
|
|
|
module.exports = router;
|