mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-16 13:00:55 +00:00
* 🌊 refactor: Upgrade the Client to Tailwind v4 Moves client/ to tailwindcss 4.3.3 through @tailwindcss/postcss, keeping the JS config via `@config` so createTailwindColors(), the theme preset and the high-contrast variant stay exactly as they are. Renames the utilities whose meaning changed (outline-none -> outline-hidden, shadow-sm -> shadow-xs), the ones v4 removed (flex-shrink-0 -> shrink-0, flex-grow -> grow, blur-0 -> blur-none, ring-opacity-N -> a /N color modifier) and the tailwindcss-radix variants, whose plugin generates nothing under v4, to the data attributes Radix already sets. Restores the two preflight defaults v4 changed (border-color, ::placeholder) so the upgrade carries no visual change. Verified by compiling the app's CSS under both versions: every class the source uses that v3 generated, v4 generates too, and each declaration difference is a v4 representation (logical properties, color-mix alpha, theme variables) with an equal computed value. * 🩹 fix: Keep the v4 Upgrade Invisible Where Review Found It Was Not Four findings against this pull request, all of them defaults v4 changed under a tree written against v3: - v4 moved the blur scale up a step: its `blur-sm` is 8px where v3's was 4px, and 4px is now `blur-xs`. Nothing in either Tailwind config overrides the scale, so all six surviving small-blur sites rendered at twice their radius. They are renamed `blur-xs`/`backdrop-blur-xs`. - The high-contrast block reset `--tw-ring-opacity`, a variable v4 does not read, and its comment named `ring-opacity-50`/`ring-opacity-20`, classes this change deleted. Compiling the converted controls through this tree's own Tailwind shows the slash modifier baking the alpha into `--tw-ring-color` as a `color-mix(...)` — the ring measured `oklab(0 0 0 / 0.5)` in the mode that promises full strength. The block now re-declares the ring colour, and the same probe measures `rgb(0 0 0)`. - `ResizableHandle` and its `Alt` twin carry a bare `border`, which v4 paints with `currentColor`. The app's compatibility shim covers that inside the SPA but is not part of the published stylesheet, so a standalone consumer drew a text-coloured hairline around a `border-medium` grip. Both handles now name `border-border-light` — the same #e3e3e3 the shim resolves to, and it follows the active theme. - `tailwindcss` was a devDependency only, while the published components emit `outline-hidden`, `shadow-xs` and `origin-(--radix-…)`. A Tailwind 3 host installed the package with no warning and silently lost focus suppression and popup transform origins. `^4.3.3` is now a peer, like `tailwind-merge`, and the consumer contract says so. Two consequences of rebasing onto `dev` are settled here as well. The 28 commits this branch caught up with added styling to eleven files the upgrade touches, so their `no-restyle` counts are re-recorded: those violations are `dev`'s existing code arriving in this pull request's lint scope, not new debt, and the diff shows which file each belongs to. And `TemplateTable.tsx` goes back to exactly what `dev` has: it is an unrendered mockup carrying six literal strings the i18n rule rejects, so renaming its one `radix-state-open:` class would have pulled six pre-existing errors into this lane for a component nothing mounts. It is the one file the rename skips, and the reason is here rather than in a suppression. Six `@scenario`-tagged specs read what the app paints: the 4px blur on the artifact scrim, the ring resolving to the opaque ink token under high contrast and to a `color-mix` without it, the handle's border following the theme in dark mode rather than inheriting `currentColor`, a focused control keeping an outline under forced colours, the restored v3 border and placeholder defaults, and npm refusing the packed tarball beside Tailwind 3 with ERESOLVE. * 🧱 fix: Keep v4's Cascade Layers and Revived Classes Out of the Rendering Two mechanisms let the upgrade change what the app paints, and each one had more sites than the reports that found it. Tailwind 4 emits every utility inside `@layer utilities`, and an unlayered declaration beats a layered one whatever its specificity. The SPA's hand-written element and bare-pseudo rules used to lose to utilities by being element selectors; they started winning. Measured in a browser against the compiled stylesheet, before and after: a `<p class="my-4">` computed `0px` margins instead of `16px`, a themed `<select>` fell back to square corners, a white background, 16px text and 40px of native arrow padding instead of `rounded-lg`, transparent, 14px and `px-2`, and a keyboard-focused control painted a 2px black outline over the ring `focus-visible:outline-hidden` was supposed to leave alone. The `select` rule, the `blockquote…p, pre { margin: 0 }` reset and the two bare focus rules now sit in `@layer base`. `.dark :focus-visible`, the `code, pre` font `!important` reset and the `.hidden`/`.overflow-*` class overrides stay unlayered: those are meant to beat utilities, and layering them would change behaviour. Tailwind 3 generated nothing for classes it could not parse, so a number of them were dead markup; Tailwind 4 honours them. Compiling the same sources under 3.4.1 and 4.3.3 and diffing the generated selectors (2,412 vs 2,435) turns up 27 v4-only tokens, 12 of which are this upgrade's own renames and 15 of which already existed on `dev`. Those 15 are restored to what v3 painted: the artifact panel keeps its 150 ms desktop open and 300 ms mobile close rather than 350 ms and 250 ms, the continue icon stays 12px rather than 76px, agent avatars keep their borderless edge, file rows and the files side panel stay fluid rather than jumping to 25rem and 7.5rem, a dialog that sets no `max-w` stays full width, the source rails keep the scrollbar they had, the composer's control row stops declaring a container, and the dropdown keeps the height, transform origin and destructive icon colour it actually had. Each one is a design decision someone wrote and never saw; they are catalogued for deliberate adoption in berry-13/LibreChat#67 instead of switching on inside an invisible upgrade. The reverse direction is clean: of the 70 selectors only v3 emits, every one is extractor noise — JavaScript negations (`!visible`, `!table`, `!running`) its regex mistook for important-prefixed classes, and a bare `animate-none` it split out of `motion-reduce:animate-none`. No class is lost. Four scenarios cover the two invariants: a paragraph keeps its margin utility, a focused control shows only its ring, a native select keeps its token styling, and the classes v3 ignored stay inert — the last one reading the artifact panel's 150 ms and then walking the stylesheets the page loaded to assert no rule exists for any of the ten revived tokens. `AddMultiConvo.tsx`'s `no-restyle` count drops 10 → 9, the entry the previous commit's class removal left unpruned, and `AgentDetail.spec.tsx` loses the blank line that deleting an assertion left behind — both were failing CI on the previous head. `FileListItem` is deleted rather than edited. It carried one of the `w-100` rows, and nothing renders it: `FileList.tsx` imports it beside a commented-out line and renders `FileListItem2` instead. Keeping it would have kept a `w-100` rule in the stylesheet the scenario asserts is empty, and dragged its six unlocalized literals into this lane — the same reason `TemplateTable` went earlier. Its dead import and `no-restyle` entry go with it, as does an unused size map in `agents.tsx` that the avatar never read. * 🧹 fix: Stop the App's Own `.hidden` From Outranking `md:flex` `client/src/style.css` declared `.hidden { display: none }`, a duplicate of the utility Tailwind already emits. Unlayered, it outranked every layered variant that reveals an element, so `hidden … md:flex` and `hidden … md:block` stayed hidden at every width: the header's desktop cluster — export/share, the trace button, temporary chat — never appeared, and the composer's MCP control lost the label its accessible name comes from, which is why `e2e/specs/mock/activity-labels.spec.ts` timed out waiting for a button named "MCP Servers" while the same suite passes on the base branch. Measured in a browser against the compiled stylesheets, `<span class="hidden md:block">MCP Servers</span>` inside a button at 1280px: | Stylesheet | computed display | button name | |---|---|---| | Tailwind 3 | `block` | `MCP Servers` | | Tailwind 4, rule present | `none` | *(empty)* | | Tailwind 4, rule deleted | `block` | `MCP Servers` | Deleting it is the whole fix: Tailwind generates the identical `.hidden`, inside `@layer utilities` where the responsive variants can win. `.overflow-x-auto` and `.overflow-y-auto` stay unlayered with a note — they deliberately override the utility of the same name with `overlay`, no source pairs them with a variant that would need to win back, and both computed values are identical under either major. `@scenario:the-desktop-header-shows-its-controls` opens a chat at 1280px, requires the export/share control to be visible, narrows to 500px where it must be hidden, and widens again. * 🔗 fix: Let a List Link Keep the Utility That Unstyles It `client/src/mobile.css` paints every list link blue, bold and underlined. `li a` is two element selectors, so under Tailwind 3 any class beat it — which is how the source cards in `verticals.tsx` and the skill file viewer, both carrying `no-underline`, actually looked. Unlayered under v4's cascade layers it outranked the utility instead, and those links came back underlined and bold. `li a` moves into `@layer base`. `p.whitespace-pre-wrap a` does not: at (0,1,2) it already outranked a single class under v3, and layering it would be the behaviour change. Measured in a browser against both compiled stylesheets, a `<li><a class="no-underline">`: Tailwind 3 computes `text-decoration-line: none` with `font-weight: 700`, and the fixed Tailwind 4 build computes the same, while the paragraph link keeps its underline in both. `@scenario:a-list-link-keeps-its-no-underline-utility` paints both links through the stylesheet the app loaded and asserts the utility wins on the carded one, the plain one keeps its underline, and the bold the rule owns survives. * fix: Carry the v4 Upgrade Across What Dev Added Rebasing onto dev brought seven commits, and three of them land styling and a test this upgrade has to account for. ToolCall.tsx and McpOAuthDialog.tsx arrived written in v3 class order, which prettier-plugin-tailwindcss rejects under v4. Both are reordered, with no class added or removed. Textarea.tsx already carried the same drift and was the only file in this branch's own diff against dev still failing the rule, so it is reordered here as well. dialog-scrim-role.spec.ts pins the new OGDialog scrim by string-comparing getComputedStyle().backgroundColor against an rgba literal. Tailwind 4 compiles a slash modifier to color-mix(in oklab, ...), which Chromium reports as oklab(L a b / alpha), so all four scenarios would read oklab(0.463999 ... / 0.8) where they expect rgba(89, 89, 89, 0.8). The paint is unchanged and only the serialization moved, so readScrim now rounds the computed color through a 1x1 canvas, which returns the same sRGB channels for either spelling. The expectations stay written as the rgba a reader can check against the palette, and the spec keeps testing the color rather than its text form. Dev's change also deleted the overlay this file used to render beside its content, which was one of its recorded no-restyle violations, so the backlog entry drops from 8 to 7. * fix: Give the Primitives the Focus and Elevation Their Callers Were Restating The design-rule gate reads a renamed utility as a swapped violation, so every v3 name the upgrade rewrote on a primitive (outline-none to outline-hidden, shadow-sm to shadow-xs, radix-state-open: to data-[state=open]:) failed it. Fix the call sites instead of re-recording them: - Button, Input, Textarea, SecretInput and AnimatedTabs already hide the outline on the focus state that shows one, so the restated class goes. - TextareaAutosize, TooltipAnchor, OGDialogContent, OGDialogClose, OGDialogTitle and CollapsibleTrigger take focusOutline="hidden" for a caller that draws its own indicator. - Alert takes elevation="raised" for the auth notices and message errors that carried a shadow. - The presets trigger's open fill moves to the Radix Trigger that stamps data-state; the parameters anchor's never matched, so it is dropped, as is the MCP config inputs' one-off shadow. Two controls had lost their keyboard outline under v4, where outline-hidden sets --tw-outline-style: none and outline-2 reads it: the files table's name cell gets it back, and the admin settings trigger drops the dead outline for the ring Button already draws. * test: Compile the Code Typography Spec With Tailwind v4 The spec dev added in #16146 ran tailwindcss as a PostCSS plugin, which v4 moved to @tailwindcss/postcss. Compile style.css the way the app does, with source(none) and an inline source standing in for the raw content the v3 config override supplied, and bridge Node's structuredClone into jsdom for the compiler. The assertions are unchanged and still fail when style.css restates the code font with !important. * test: Cover the Focus Outlines the Primitives Now Own Adds two scenarios beside the upgrade's other focus checks: the files table's name cell draws its 2px keyboard outline again, and a control that opts into focusOutline="hidden" drops the browser outline while forced colors still repaints the transparent one. * fix: Keep OGDialog's Entrance From Sliding In Half a Width v4 compiles translate-x-[-50%] and translate-y-[-50%] to the translate property, which tailwindcss-animate's enter and exit keyframes compose with through transform instead of replacing as they did in v3. The surface's slide-in-from-left-1/2 and slide-in-from-top-[48%] therefore started every OGDialog half its width to the left of centre and slid it across, where v3 started it 2% of its height below its resting place. Name only that 2% in each direction, which reproduces v3's motion over the centering translate. Found by #16068's dialog-scrim-role scenarios, which sample the dialog's position mid-entrance and failed against the upgraded build. --------- Co-authored-by: berry-13 <berry-13@users.noreply.github.com>
6 lines
341 B
JavaScript
6 lines
341 B
JavaScript
// Tailwind v4 subsumes the rest of this pipeline: `@tailwindcss/postcss` handles `@import`
|
|
// inlining (postcss-import), vendor prefixing and modern-CSS lowering (autoprefixer,
|
|
// postcss-preset-env) through Lightning CSS. Adding them back would process the output twice.
|
|
module.exports = {
|
|
plugins: [require('@tailwindcss/postcss')],
|
|
};
|