mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-07-15 19:14:51 +00:00
e35b539e64
Pre-PR multi-agent review confirmed 5 defects in the initial commit; all fixed: 1. CRITICAL — the tool never paused on the real agents endpoint: production loads tools definitions-only, flipping the SDK ToolNode to event-driven dispatch, and the host ON_TOOL_EXECUTE handler runs outside the Pregel task frame (under runOutsideTracing), where interrupt() throws and becomes an error ToolMessage. Reworked: the ask tool never rides toolDefinitions/ toolRegistry — on HITL-capable top-level agents a real instance is supplied via AgentInputs.graphTools (agents#289, requires @librechat/agents > 3.2.57), the SDK's in-graph direct-tool seam; new production-shape e2e pins the event-driven mode end to end. 2. CRITICAL — ask-only runs left orphaned interrupted checkpoints (silent context duplication on every later turn): both orphan prunes were gated on toolApproval.enabled. The pre-turn prune now also fires for ask-capable agents (exported agentRequestsAskUserQuestion), and the abort-route prune fires when the aborted job carries a pendingAction. 3. MAJOR — self-spawned subagents bypassed the strip (self config resolves from the parent's _sourceInputs): fixed SDK-side (buildChildInputs clears graphTools) and the tool is now never present on child surfaces host-side. 4. MINOR — the manifest entry leaked into the Assistants tools dialog and the legacy plugins endpoint, where tools execute with no run to pause: new agentsOnly manifest flag, scoped out of both listings. 5. MINOR — filteredTools/includedTools only hid the tool from the dialog: now enforced at run build (strip + no checkpointer), making the admin filter a real kill switch for already-saved agents. |
||
|---|---|---|
| .. | ||
| askUserQuestion.e2e.spec.js | ||
| callbacks.spec.js | ||
| client.contextMetadata.spec.js | ||
| client.memory.spec.js | ||
| hitlCheckpoint.e2e.spec.js | ||
| jobReplacement.spec.js | ||
| modelEndHandler.spec.js | ||
| openai.spec.js | ||
| request.resumeMetadata.spec.js | ||
| responses.unit.spec.js | ||
| resume.spec.js | ||
| usageEvents.integration.spec.js | ||
| usageEvents.live.spec.js | ||
| v1.duplicate-actions.spec.js | ||
| v1.spec.js | ||