LibreChat/api/server/services/Endpoints/agents/subagentThreadStore.spec.js
Danny Avila d641c398d5
🧳 fix: Port Subagent Control Receipt Writes to DocumentDB-Safe Operators (#15171)
* fix: harden subagent control receipt persistence

* fix: harden durable subagent control replay

* fix: await terminal control receipts on shutdown

* fix: close subagent control replay races

* test: type stale-owner transport fixture

* fix: quiesce durable subagent controls

* test: await subagent shutdown durability boundary

* fix: serialize durable subagent controls

* fix: fail shutdown on cleanup errors

* fix: report cancellable result availability accurately

* fix: fence subagent control receipt ownership

* fix: close distributed control receipt races

* test: type control receipt race fixture

* chore: require authoritative control receipts

* fix: close subagent control lifecycle races

* style: separate control reservation member

* test: harden subagent settlement wait

* fix: preserve authoritative control replay state
2026-08-24 20:05:39 -04:00

136 lines
5.1 KiB
JavaScript

const mockTaskStore = {
configureTaskControlTransport: jest.fn().mockResolvedValue(undefined),
configureActivityStream: jest.fn(),
prepareActivityForShutdown: jest.fn(),
destroyTaskControlTransport: jest.fn().mockResolvedValue(undefined),
destroyActivityStream: jest.fn(),
};
const mockCompletionWakeupHandler = jest.fn().mockResolvedValue(undefined);
jest.mock('@librechat/api', () => ({
cacheConfig: { USE_REDIS: true, REDIS_KEY_PREFIX: 'test:' },
ioredisClient: { duplicate: jest.fn() },
isEnabled: jest.fn(() => false),
registerShutdownTask: jest.fn(),
duplicateIoRedisClient: jest.fn(),
createSubagentThreadTaskStore: jest.fn(() => mockTaskStore),
createSubagentCompletionWakeupHandler: jest.fn(() => mockCompletionWakeupHandler),
RedisSubagentTaskControlTransport: jest.fn(),
RedisEventTransport: jest.fn(),
SubagentActivityStream: jest.fn(),
}));
jest.mock('~/models', () => ({
acquireSubagentThreadLease: jest.fn(),
claimSubagentTaskResult: jest.fn(),
releaseSubagentTaskResultClaim: jest.fn(),
countActiveSubagentThreadLeases: jest.fn(),
deleteConvos: jest.fn(),
deleteMessages: jest.fn(),
getConvo: jest.fn(),
getSubagentTaskControlReplay: jest.fn(),
getMessages: jest.fn(),
listActiveSubagentThreadLeases: jest.fn(),
recordSubagentTaskControlReceipt: jest.fn(),
releaseSubagentThreadLease: jest.fn(),
reserveSubagentThread: jest.fn(),
renewSubagentThreadLease: jest.fn(),
saveConvo: jest.fn(),
saveMessage: jest.fn(),
isSubagentOwnerAdmissible: jest.fn(),
fenceSubagentAdmission: jest.fn(),
renewSubagentAdmission: jest.fn(),
releaseSubagentAdmission: jest.fn(),
}));
jest.mock('../../Agents/triggers', () => ({
enqueueAgentTrigger: jest.fn(),
}));
const {
ioredisClient,
isEnabled,
registerShutdownTask,
duplicateIoRedisClient,
createSubagentThreadTaskStore,
} = require('@librechat/api');
const subagentThreadTaskStore = require('./subagentThreadStore');
const { configureSubagentTaskRouting } = subagentThreadTaskStore;
const taskStoreOptions = createSubagentThreadTaskStore.mock.calls[0][1];
const taskStoreMethods = createSubagentThreadTaskStore.mock.calls[0][0];
const db = require('~/models');
const activityPrepareRegistration = registerShutdownTask.mock.calls.find(
([name]) => name === 'subagent activity streams prepare',
);
const taskStoreShutdownRegistration = registerShutdownTask.mock.calls.find(
([name]) => name === 'subagent task store',
);
describe('subagent thread Redis lifecycle', () => {
it('wires durable control receipt persistence into the host store', () => {
expect(taskStoreMethods.recordSubagentTaskControlReceipt).toBe(
db.recordSubagentTaskControlReceipt,
);
expect(taskStoreMethods.getSubagentTaskControlReplay).toBe(db.getSubagentTaskControlReplay);
});
it('reads completion wakeup rollout state at task preparation time', async () => {
isEnabled.mockReturnValueOnce(false);
await taskStoreOptions.onTaskPrepared({ taskId: 'disabled' });
expect(mockCompletionWakeupHandler).not.toHaveBeenCalled();
isEnabled.mockReturnValueOnce(true);
await taskStoreOptions.onTaskPrepared({ taskId: 'enabled' });
expect(mockCompletionWakeupHandler).toHaveBeenCalledWith({ taskId: 'enabled' });
isEnabled.mockReturnValueOnce(true);
expect(subagentThreadTaskStore.completionWakeupsEnabled).toBe(true);
isEnabled.mockReturnValueOnce(false);
expect(subagentThreadTaskStore.completionWakeupsEnabled).toBe(false);
});
it('registers local task-store quiescence independently of optional Redis setup', () => {
expect(taskStoreShutdownRegistration).toEqual([
'subagent task store',
expect.any(Function),
{ priority: 90 },
]);
});
it('closes activity SSE before drain and disconnects its subscriber after drain', async () => {
const taskSubscriber = { disconnect: jest.fn() };
const activitySubscriber = { disconnect: jest.fn() };
const taskPublisher = { disconnect: jest.fn() };
const activityPublisher = { disconnect: jest.fn() };
ioredisClient.duplicate
.mockReturnValueOnce(taskSubscriber)
.mockReturnValueOnce(activitySubscriber);
duplicateIoRedisClient
.mockReturnValueOnce(taskPublisher)
.mockReturnValueOnce(activityPublisher);
await configureSubagentTaskRouting();
expect(activityPrepareRegistration).toEqual([
'subagent activity streams prepare',
expect.any(Function),
{ phase: 'pre-drain', priority: 100 },
]);
expect(taskStoreShutdownRegistration).toEqual([
'subagent task store',
expect.any(Function),
{ priority: 90 },
]);
const prepare = activityPrepareRegistration[1];
prepare();
expect(mockTaskStore.prepareActivityForShutdown).toHaveBeenCalledTimes(1);
const shutdown = taskStoreShutdownRegistration[1];
await shutdown();
expect(mockTaskStore.destroyTaskControlTransport).toHaveBeenCalledTimes(1);
expect(mockTaskStore.destroyActivityStream).toHaveBeenCalledTimes(1);
expect(taskPublisher.disconnect).toHaveBeenCalledTimes(1);
expect(activitySubscriber.disconnect).toHaveBeenCalledTimes(1);
expect(activityPublisher.disconnect).toHaveBeenCalledTimes(1);
});
});