mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-16 21:08:17 +00:00
* feat: add run-scoped file sharing for subagents Delegate current-message files through authorized execution catalogs and publish selected immutable code-output versions through the existing file pipeline. Requires the companion agents SDK context adapter before the dependency can be released and pinned. * fix: preserve child tool artifacts and verify file-sharing lifecycle Keep citations and other non-sandbox artifacts on their existing delivery path while retaining private code outputs and inspected images until publication. Cover native and text delivery, nested and sibling authorization, concurrent runs, cancellation cleanup, and checkpoint recovery through the browser harness. * test: align file-sharing fixtures and integration cleanup * test: repair LibreOffice conversion fixtures * test: verify deployment skill bytes across checkout formats * fix: align subagent file budgets and refresh boundaries * chore: update agents SDK to 3.8.6 * refactor: move code output processing into API workspace * fix: enforce shared file budgets for parents and teams * fix: declare the shared file encoder interface
183 lines
7 KiB
JavaScript
183 lines
7 KiB
JavaScript
jest.mock('uuid', () => ({ v4: jest.fn(() => 'mock-uuid') }));
|
|
|
|
jest.mock('@librechat/data-schemas', () => ({
|
|
logger: { warn: jest.fn(), debug: jest.fn(), error: jest.fn() },
|
|
}));
|
|
|
|
jest.mock('@librechat/agents', () => ({
|
|
...jest.requireActual('@librechat/agents'),
|
|
getCodeBaseURL: jest.fn(() => 'http://localhost:8000'),
|
|
}));
|
|
|
|
const mockSanitizeArtifactPath = jest.fn();
|
|
const mockFlattenArtifactPath = jest.fn((name) => name.replace(/\//g, '__'));
|
|
|
|
const mockAxios = jest.fn().mockResolvedValue({
|
|
data: Buffer.from('file-content'),
|
|
});
|
|
mockAxios.post = jest.fn();
|
|
|
|
jest.mock('@librechat/api', () => {
|
|
const http = require('http');
|
|
const https = require('https');
|
|
return {
|
|
processCodeOutput: jest.requireActual('@librechat/api').processCodeOutput,
|
|
resolveDownloadPath: (file) => file.storageKey || file.filepath,
|
|
logAxiosError: jest.fn(),
|
|
getBasePath: jest.fn(() => ''),
|
|
sanitizeArtifactPath: mockSanitizeArtifactPath,
|
|
flattenArtifactPath: mockFlattenArtifactPath,
|
|
createAxiosInstance: jest.fn(() => mockAxios),
|
|
getCodeApiAuthHeaders: jest.fn(async () => ({})),
|
|
codeExecutionHeaders: jest.fn(() => ({})),
|
|
getCodeExecutionBaseUrl: jest.fn(() => 'http://localhost:8000'),
|
|
CODE_API_EXPECTED_PROFILE_HEADER: 'X-CodeAPI-Expected-Profile',
|
|
classifyCodeArtifact: jest.fn(() => 'other'),
|
|
extractCodeArtifactText: jest.fn(async () => null),
|
|
getBoundedCodeOutputByteLimit: (configured) =>
|
|
typeof configured === 'number' && Number.isFinite(configured) && configured > 0
|
|
? Math.min(configured, 64 * 1024 * 1024)
|
|
: 64 * 1024 * 1024,
|
|
/* `processCodeOutput` calls this to derive the trust flag persisted
|
|
* on `IMongoFile.textFormat` — Codex P1 review on PR #12934. The
|
|
* mock returns null in lockstep with the null `text` above so
|
|
* downstream consumers don't see a phantom format. */
|
|
getExtractedTextFormat: jest.fn(() => null),
|
|
getStorageMetadata: jest.fn(() => ({})),
|
|
/* Pass-through `withTimeout`: this suite asserts traversal sanitization,
|
|
* not deferred preview timing. */
|
|
withTimeout: async (promise) => promise,
|
|
/* These traversal cases all use non-office filenames — keep the
|
|
* inline (non-finalize) path so existing assertions on a single
|
|
* commitCodeFile call hold. */
|
|
hasOfficeHtmlPath: jest.fn(() => false),
|
|
/* Identity-helper stub mirroring `packages/api/src/files/code/identity.ts`.
|
|
* `processCodeOutput` calls this for every output download URL;
|
|
* traversal cases don't care about the query shape, just that it
|
|
* returns something concatable. */
|
|
buildCodeEnvDownloadQuery: jest.fn(({ kind, id, version }) => {
|
|
const params = new URLSearchParams({ kind, id });
|
|
if (version != null) params.set('version', String(version));
|
|
return `?${params.toString()}`;
|
|
}),
|
|
codeServerHttpAgent: new http.Agent({ keepAlive: false }),
|
|
codeServerHttpsAgent: new https.Agent({ keepAlive: false }),
|
|
};
|
|
});
|
|
|
|
jest.mock('librechat-data-provider', () => ({
|
|
...jest.requireActual('librechat-data-provider'),
|
|
mergeFileConfig: jest.fn(() => ({ serverFileSizeLimit: 100 * 1024 * 1024 })),
|
|
getEndpointFileConfig: jest.fn(() => ({
|
|
fileSizeLimit: 100 * 1024 * 1024,
|
|
supportedMimeTypes: ['*/*'],
|
|
})),
|
|
fileConfig: { checkType: jest.fn(() => true) },
|
|
}));
|
|
|
|
jest.mock('~/models', () => ({
|
|
createFile: jest.fn().mockResolvedValue({}),
|
|
getFiles: jest.fn().mockResolvedValue([]),
|
|
updateFile: jest.fn(),
|
|
claimCodeFile: jest.fn().mockResolvedValue({ file_id: 'mock-uuid', usage: 0 }),
|
|
commitCodeFile: jest.fn().mockResolvedValue(true),
|
|
}));
|
|
|
|
const mockSaveBuffer = jest.fn().mockResolvedValue('/uploads/user123/mock-uuid__output.csv');
|
|
|
|
jest.mock('~/server/services/Files/strategies', () => ({
|
|
getStrategyFunctions: jest.fn(() => ({
|
|
saveBuffer: mockSaveBuffer,
|
|
})),
|
|
}));
|
|
|
|
jest.mock('~/server/services/Files/permissions', () => ({
|
|
filterFilesByAgentAccess: jest.fn().mockResolvedValue([]),
|
|
}));
|
|
|
|
jest.mock('~/server/services/Files/images/convert', () => ({
|
|
convertImage: jest.fn(),
|
|
}));
|
|
|
|
jest.mock('~/server/utils', () => ({
|
|
determineFileType: jest.fn().mockResolvedValue({ mime: 'text/csv' }),
|
|
}));
|
|
|
|
jest.mock('~/server/services/Files/retention', () => ({
|
|
getRetentionExpiry: jest.fn(() => ({})),
|
|
}));
|
|
|
|
const { getRetentionExpiry } = require('~/server/services/Files/retention');
|
|
const { commitCodeFile } = require('~/models');
|
|
const { processCodeOutput } = require('../process');
|
|
|
|
const baseParams = {
|
|
req: {
|
|
user: { id: 'user123', tenantId: 'tenantA' },
|
|
config: {
|
|
fileStrategy: 'local',
|
|
imageOutputType: 'webp',
|
|
fileConfig: {},
|
|
},
|
|
},
|
|
id: 'code-file-id',
|
|
apiKey: 'test-key',
|
|
toolCallId: 'tool-1',
|
|
conversationId: 'conv-1',
|
|
messageId: 'msg-1',
|
|
session_id: 'session-1',
|
|
};
|
|
|
|
describe('processCodeOutput path traversal protection', () => {
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
test('sanitizeArtifactPath is called with the raw artifact name', async () => {
|
|
mockSanitizeArtifactPath.mockReturnValueOnce('output.csv');
|
|
await processCodeOutput({ ...baseParams, name: 'output.csv' });
|
|
expect(mockSanitizeArtifactPath).toHaveBeenCalledWith('output.csv');
|
|
});
|
|
|
|
test('sanitized name is used in saveBuffer fileName (and flattened to a single component)', async () => {
|
|
mockSanitizeArtifactPath.mockReturnValueOnce('sanitized-name.txt');
|
|
await processCodeOutput({ ...baseParams, name: '../../../tmp/poc.txt' });
|
|
|
|
expect(mockSanitizeArtifactPath).toHaveBeenCalledWith('../../../tmp/poc.txt');
|
|
const call = mockSaveBuffer.mock.calls[0][0];
|
|
/* `flattenArtifactPath` is identity for already-flat names; the assert
|
|
* is against the storage-key composition (`<file_id>__<flat>`). */
|
|
expect(call.fileName).toBe('mock-uuid__sanitized-name.txt');
|
|
});
|
|
|
|
test('sanitized name is stored as filename in the file record', async () => {
|
|
mockSanitizeArtifactPath.mockReturnValueOnce('safe-output.csv');
|
|
await processCodeOutput({ ...baseParams, name: 'unsafe/../../output.csv' });
|
|
|
|
const fileArg = commitCodeFile.mock.calls[0][0];
|
|
expect(fileArg.filename).toBe('safe-output.csv');
|
|
expect(fileArg.tenantId).toBe('tenantA');
|
|
});
|
|
|
|
test('getRetentionExpiry is called with the request object', async () => {
|
|
mockSanitizeArtifactPath.mockReturnValueOnce('output.csv');
|
|
await processCodeOutput({ ...baseParams, name: 'output.csv' });
|
|
expect(getRetentionExpiry).toHaveBeenCalledWith(baseParams.req);
|
|
});
|
|
|
|
test('sanitized name is used for image file records', async () => {
|
|
const { convertImage } = require('~/server/services/Files/images/convert');
|
|
convertImage.mockResolvedValueOnce({
|
|
filepath: '/images/user123/mock-uuid.webp',
|
|
bytes: 100,
|
|
});
|
|
|
|
mockSanitizeArtifactPath.mockReturnValueOnce('safe-chart.png');
|
|
await processCodeOutput({ ...baseParams, name: '../../../chart.png' });
|
|
|
|
expect(mockSanitizeArtifactPath).toHaveBeenCalledWith('../../../chart.png');
|
|
const fileArg = commitCodeFile.mock.calls[0][0];
|
|
expect(fileArg.filename).toBe('safe-chart.png');
|
|
expect(fileArg.tenantId).toBe('tenantA');
|
|
});
|
|
});
|