mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-08-27 04:07:05 +00:00
* ⚡ perf: Stop Awaiting the Conversation Access Marker Write Without Redis the CONVO_ACCESS violations namespace is backed by keyv-file, whose debounced write resolves after ~100ms. validateConvoAccess awaited that write before calling next(), so the first message to any existing conversation waited ~100ms before the request was even admitted — once per conversation per ten-minute window, on every default deployment. The marker only short-circuits the next check, so the write no longer gates the request. The same read now stashes the full document on req.resolvedConversation (null when absent) for downstream consumers. First-turn ack on an existing conversation: 109ms -> 5ms. * ⚡ perf: Read the Conversation Once per Chat Turn A chat turn read the same conversation document four times: the access check (two fields), the subagent thread guard (full document), agent initialization (the files field), and the first save. The access check now reads the full document and leaves it on req.resolvedConversation, the guard accepts that pre-resolved document instead of re-reading, and initializeAgent takes the conversation's file refs from it rather than issuing a separate findOne. Two serial round trips removed from every turn; the same document still serves the first save as before. * ⚡ perf: Remove Duplicate JWT Authentication on Agents Routes routes/agents/index.js applies requireJwtAuth and then mounts the v1 router at '/', which applied requireJwtAuth again. Every request through the agents router — chat turns included — ran the passport strategy twice: two signature checks and two user document reads. The v1 router is mounted nowhere else; its separately exported avatar router carries its own auth in files/index.js. * ⚡ perf: Skip the History Read for Root-Parent Turns and Walk the Tree in O(n) loadHistory fetched every message in the conversation and then walked the parent chain from the request's head. For a new conversation — or a new branch from the root of an existing one — the head is the root sentinel, which no message carries as its id, so the walk was empty by construction and the fetch was wasted. It now returns early. getMessagesForConversation found each ancestor with Array.find inside the walk, O(n^2) on a linear conversation (~5ms at 1000 messages). A Map by messageId makes it O(n); first-match semantics are preserved.
197 lines
5.4 KiB
JavaScript
197 lines
5.4 KiB
JavaScript
const express = require('express');
|
|
const { generateCheckAccess } = require('@librechat/api');
|
|
const { PermissionTypes, Permissions, PermissionBits } = require('librechat-data-provider');
|
|
const { configMiddleware, canAccessAgentResource } = require('~/server/middleware');
|
|
const v1 = require('~/server/controllers/agents/v1');
|
|
const { getRoleByName } = require('~/models');
|
|
const actions = require('./actions');
|
|
const tools = require('./tools');
|
|
|
|
const router = express.Router();
|
|
const avatar = express.Router();
|
|
|
|
const checkAgentAccess = generateCheckAccess({
|
|
permissionType: PermissionTypes.AGENTS,
|
|
permissions: [Permissions.USE],
|
|
getRoleByName,
|
|
});
|
|
const checkAgentCreate = generateCheckAccess({
|
|
permissionType: PermissionTypes.AGENTS,
|
|
permissions: [Permissions.USE, Permissions.CREATE],
|
|
getRoleByName,
|
|
});
|
|
|
|
/**
|
|
* Agent actions route.
|
|
* @route GET|POST /agents/actions
|
|
*/
|
|
router.use('/actions', configMiddleware, actions);
|
|
|
|
/**
|
|
* Get a list of available tools for agents.
|
|
* @route GET /agents/tools
|
|
*/
|
|
router.use('/tools', configMiddleware, tools);
|
|
|
|
/**
|
|
* Get all agent categories with counts
|
|
* @route GET /agents/categories
|
|
*/
|
|
router.get('/categories', v1.getAgentCategories);
|
|
/**
|
|
* Creates an agent.
|
|
* @route POST /agents
|
|
* @param {AgentCreateParams} req.body - The agent creation parameters.
|
|
* @returns {Agent} 201 - Success response - application/json
|
|
*/
|
|
router.post('/', checkAgentCreate, configMiddleware, v1.createAgent);
|
|
|
|
/**
|
|
* Retrieves basic agent information (VIEW permission required).
|
|
* Returns safe, non-sensitive agent data for viewing purposes.
|
|
* @route GET /agents/:id
|
|
* @param {string} req.params.id - Agent identifier.
|
|
* @returns {Agent} 200 - Basic agent info - application/json
|
|
*/
|
|
router.get(
|
|
'/:id',
|
|
checkAgentAccess,
|
|
canAccessAgentResource({
|
|
requiredPermission: PermissionBits.VIEW,
|
|
resourceIdParam: 'id',
|
|
}),
|
|
v1.getAgent,
|
|
);
|
|
|
|
/**
|
|
* Retrieves full agent details including sensitive configuration (EDIT permission required).
|
|
* Returns complete agent data for editing/configuration purposes.
|
|
* @route GET /agents/:id/expanded
|
|
* @param {string} req.params.id - Agent identifier.
|
|
* @returns {Agent} 200 - Full agent details - application/json
|
|
*/
|
|
router.get(
|
|
'/:id/expanded',
|
|
checkAgentAccess,
|
|
canAccessAgentResource({
|
|
requiredPermission: PermissionBits.EDIT,
|
|
resourceIdParam: 'id',
|
|
}),
|
|
(req, res) => v1.getAgent(req, res, true), // Expanded version
|
|
);
|
|
|
|
/**
|
|
* Retrieves an agent's version history (EDIT permission required).
|
|
* Loaded lazily so the editor doesn't transfer large histories up front.
|
|
* @route GET /agents/:id/versions
|
|
* @param {string} req.params.id - Agent identifier.
|
|
* @returns {Agent[]} 200 - Agent version history - application/json
|
|
*/
|
|
router.get(
|
|
'/:id/versions',
|
|
checkAgentAccess,
|
|
canAccessAgentResource({
|
|
requiredPermission: PermissionBits.EDIT,
|
|
resourceIdParam: 'id',
|
|
}),
|
|
v1.getAgentVersions,
|
|
);
|
|
/**
|
|
* Updates an agent.
|
|
* @route PATCH /agents/:id
|
|
* @param {string} req.params.id - Agent identifier.
|
|
* @param {AgentUpdateParams} req.body - The agent update parameters.
|
|
* @returns {Agent} 200 - Success response - application/json
|
|
*/
|
|
router.patch(
|
|
'/:id',
|
|
checkAgentCreate,
|
|
configMiddleware,
|
|
canAccessAgentResource({
|
|
requiredPermission: PermissionBits.EDIT,
|
|
resourceIdParam: 'id',
|
|
}),
|
|
configMiddleware,
|
|
v1.updateAgent,
|
|
);
|
|
|
|
/**
|
|
* Duplicates an agent.
|
|
* @route POST /agents/:id/duplicate
|
|
* @param {string} req.params.id - Agent identifier.
|
|
* @returns {Agent} 201 - Success response - application/json
|
|
*/
|
|
router.post(
|
|
'/:id/duplicate',
|
|
checkAgentCreate,
|
|
configMiddleware,
|
|
canAccessAgentResource({
|
|
requiredPermission: PermissionBits.EDIT,
|
|
resourceIdParam: 'id',
|
|
}),
|
|
configMiddleware,
|
|
v1.duplicateAgent,
|
|
);
|
|
|
|
/**
|
|
* Deletes an agent.
|
|
* @route DELETE /agents/:id
|
|
* @param {string} req.params.id - Agent identifier.
|
|
* @returns {Agent} 200 - success response - application/json
|
|
*/
|
|
router.delete(
|
|
'/:id',
|
|
checkAgentCreate,
|
|
canAccessAgentResource({
|
|
requiredPermission: PermissionBits.DELETE,
|
|
resourceIdParam: 'id',
|
|
}),
|
|
v1.deleteAgent,
|
|
);
|
|
|
|
/**
|
|
* Reverts an agent to a previous version.
|
|
* @route POST /agents/:id/revert
|
|
* @param {string} req.params.id - Agent identifier.
|
|
* @param {number} req.body.version_index - Index of the version to revert to.
|
|
* @returns {Agent} 200 - success response - application/json
|
|
*/
|
|
router.post(
|
|
'/:id/revert',
|
|
checkAgentCreate,
|
|
configMiddleware,
|
|
canAccessAgentResource({
|
|
requiredPermission: PermissionBits.EDIT,
|
|
resourceIdParam: 'id',
|
|
}),
|
|
configMiddleware,
|
|
v1.revertAgentVersion,
|
|
);
|
|
|
|
/**
|
|
* Returns a list of agents.
|
|
* @route GET /agents
|
|
* @param {AgentListParams} req.query - The agent list parameters for pagination and sorting.
|
|
* @returns {AgentListResponse} 200 - success response - application/json
|
|
*/
|
|
router.get('/', checkAgentAccess, v1.getListAgents);
|
|
|
|
/**
|
|
* Uploads and updates an avatar for a specific agent.
|
|
* @route POST /agents/:agent_id/avatar
|
|
* @param {string} req.params.agent_id - The ID of the agent.
|
|
* @param {Express.Multer.File} req.file - The avatar image file.
|
|
* @param {string} [req.body.metadata] - Optional metadata for the agent's avatar.
|
|
* @returns {Object} 200 - success response - application/json
|
|
*/
|
|
avatar.post(
|
|
'/:agent_id/avatar/',
|
|
checkAgentAccess,
|
|
canAccessAgentResource({
|
|
requiredPermission: PermissionBits.EDIT,
|
|
resourceIdParam: 'agent_id',
|
|
}),
|
|
v1.uploadAgentAvatar,
|
|
);
|
|
|
|
module.exports = { v1: router, avatar };
|