mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-19 22:43:38 +00:00
843 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
caeb786e97
|
🔀 feat: Show the Conversation Pull Request in the Sidebar List (#16815)
* feat: Show the Conversation Pull Request in the Sidebar List Add a batch lookup route and a sidebar row mark: the state icon with the CI dot, opening the same card beside the row on hover. The row keeps the conversation's own title. * fix: Address Review Findings on the Sidebar Pull Request Batch and Row Mark Cap the whole batch with a configurable deadline, make the row mark a keyboard-reachable button that opens the card on focus, refresh rows when the window regains focus through the shared batch, and show a retryable failure state instead of treating a failed first lookup as no pull request. * fix: Send Sidebar Pull Request Batches One at a Time Queue every batch request behind the one before it, so an oversized list or an overlapping flush cannot multiply the server's configured lookup concurrency, and bound how long one request may hold the queue so a request that never answers cannot stop the rest. * fix: Keep the Batch Request Timeout Above the Server Deadline Default the client's request timeout to just past the longest batchTimeoutSeconds a deployment may configure, so a queued request never starts while the previous request's server-side lookups are still running. * fix: Keep Batch Lookups Inside the Concurrency Limit and Per-Entry Failures Per Entry Share one lookup limiter across every batch request so lookups that outlive a request's deadline keep their slot, answer a missing token only for the conversations that needed it, and point the row at its pull request description only while that text is in the page. * fix: Bound Batch Reads, Scope Concurrency Per Credential, and Gate the Sidebar on the Batch Version Start the batch deadline when the request arrives and bound the config and lane reads, count lookup slots per credential, advertise a batch route version and ask only a server that has it, take no row space for an absent mark, show a failed refresh over a cached empty answer, keep a malformed response from stalling the request queue, and repair the lane recording tests that still used a mock removed on dev. * fix: Move Capability Resolution Into the Package and Harden the Batch Route and Queue Resolve the pull request startup capabilities in packages/api so the route stays wiring only, bound the config and lane reads by the configured deadline, merge identical lanes before taking limiter slots, fall back to the single route when a replica has no batch route, and dispose the batch queue when the signed-in user changes. * fix: Abort the Batch Fallback With Its Request So the Queue Never Overlaps It Give the batch fetcher the request's abort signal and pass it to every single-route call, abort a request that times out or is disposed, and stop the fallback workers from starting more calls once it has. * fix: Forward the Abort Signal to the Batch POST Pass the request's abort signal through the batch fetcher, the data-provider call and Axios, so a batch request that times out or is disposed is cancelled instead of continuing beside the next one, and settle a request promptly when it is aborted. * fix: Close the Pull Request Lookup Follow-Ups and Cancel Abandoned Sidebar Rows |
||
|
|
0e1a758072
|
🗂️ feat: Merge Change and Remove Project Into One Submenu (#16844)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
|
||
|
|
aae49b375f
|
🧹 refactor: Clear the Raw-Color and Unknown-Class Design Suppressions (#16825)
* refactor: Clear the Raw-Color and Unknown-Class Design Suppressions * fix: Keep the Prose Classes style.css Still Reads * fix: Keep the split-parent Marker the Screenshot Spec Waits On * chore: Prune the Recorded Suppressions the Rebase Cleared |
||
|
|
abeb255a96
|
⏹️ fix: Reconcile Stopped Generations Before Detaching the Stream (#16788)
* fix: Reconcile stopped generations before detaching the stream * test: Cover immediate Stop and delayed terminal reconciliation * test: Accept both terminal outcomes of an immediate Stop --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
9068f0e922
|
🔇 fix: Keep Reasoning Out of Read Aloud (#16790)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
* fix: Keep Reasoning Out of Every Read Aloud Path Read aloud spoke the Thoughts section along with the answer. The hover button flattened think parts into the string it handed to TTS, browser autoplay and the hooks parsed content without skipping reasoning, and server streaming spoke the stored text field, which an aborted turn persists with its reasoning included. Add getSpeechText to data-provider as the single source for spoken text: text parts only for structured content, and the legacy :::thinking block stripped from plain text, treating a still-open block as reasoning so streamed speech only ever grows. Route the hover button, browser autoplay and server streaming through it, and skip reasoning in the TTS hooks' own content parsing. * fix: Speak String Message Content Without Its Reasoning Imported or client-built messages can carry their answer as string content rather than parts; read it like plain text instead of falling back to an empty text field. * fix: Keep Answers Between Repeated Legacy Thinking Blocks Strip every closed :::thinking block before treating an unterminated one as reasoning, so a second closed block no longer swallows the answer that follows it. * fix: Skip Read Aloud and Autoplay When Only Reasoning Remains A turn stopped mid-reasoning has no answer to speak once reasoning is filtered. Gate autoplay on the same speech text it will play, so the external engine never opens a stream that can only time out, and hide the Read aloud action when there is nothing to read. Every speech path reads a finalized message, so speak an unmatched :::thinking marker as the answer text the UI shows instead of dropping the rest. * refactor: Move Speech Chunk Polling Into packages/api The decision of what text to stream as speech lived in the legacy CJS service. Move the chunk processor to packages/api as createSpeechChunkProcessor, taking the message cache and lookup from the caller, and leave streamAudio.js wiring them in. Its tests move with it onto an in-memory cache instead of module mocks. * fix: Speak Exactly the Answer the Message View Shows Share the legacy :::thinking parser between the message view and speech, so Read Aloud strips the same block the view collapses instead of a separate pattern drifting from it. Trim structured speech text so a whitespace-only answer is not speakable, and key autoplay's audio cache by the spoken text, as manual playback already is, so audio cached with reasoning before this change is never replayed. * fix: Fall Back to Text When String Content Is Empty |
||
|
|
b56de235f9
|
⚙️ feat: Move Chat Actions Into a Header Options Menu (#16775)
* feat: Move Chat Actions Into a Header Options Menu The header's export/share button becomes a chat options menu with Share, Export, Rename, Pin, Change project, Remove from project, Duplicate, Archive and Delete for the open chat. The sidebar row menu keeps Pin, Mark unread, Rename, Archive and Delete. * fix: Address Review Findings on the Header Chat Options Menu Limit read-only subagent threads to share and export, apply the sidebar's rename gate for running chats, let an unchanged title claim ownership, keep later navigation after a late archive, hide history-only actions for temporary chats, expose dialog semantics on the dialog items, and fix import sorting. * fix: Scope Header Chat Option Dialogs to the Conversation They Opened For ChatView stays mounted across a route change, so dialog flags now carry the conversation id they were opened for and reset when the open chat or the read-only state changes. * fix: Settle Header Delete and Rename Dialogs Against the Open Chat Read the open route when a delete settles, give the delete dialog the id its menu item controls, return focus to the menu item when a rename saves, and only let a close clear the dialog it belongs to. * fix: Ignore a Late Rename Result After the Dialog Is Gone A rename that settles after its dialog unmounted no longer closes the parent state or moves focus to the reused menu item. * fix: Dismiss Header Chat Options When the Route Leaves Their Chat The route moves before the chat state does and the menu and dialogs are portaled outside the hidden pane, so they are now dismissed on a route change and gated on it. A delete that settles after another chat opened no longer closes that chat's menu, and the options read the freshest cached copy of the chat instead of an older point entry. |
||
|
|
3f442e4dbe
|
🪶 perf: Load Tool-Call Previews and Fetch Full Parts on Demand (#16753)
* 🧾 perf: Load Tool-Call Previews and Fetch Full Parts on Demand Long agent conversations shipped every tool output, argument string and subagent transcript on load, though the cards render collapsed: 12-18 MB of message JSON per chat, enough to crash iPhone Safari tabs. A client that adds ?toolPreviews=1 to the conversation load now receives bounded previews of settled tool calls (start and end of long outputs, JSON arguments and outputs kept valid with only their longest strings shortened, exit-status trailers kept whole, subagent transcripts omitted) with explicit markers and full lengths. Opening a card or a subagent panel fetches the stored part from a new owner-scoped endpoint, GET /api/messages/:conversationId/:messageId/parts/:partIndex, cached under its own React Query key. Clients that do not ask, exports and share links keep the full payload; bounds are configurable under toolCallPreviews in librechat.yaml, and a client-authored message that carries previews is refused rather than saved. * 🧾 fix: Validate Part Reads in Parallel and Preview Fork Responses The full-part read now starts beside conversation-access validation instead of after it, and keeps the active-job fallback the conversation read has, so a conversation still live before its first save can expand its previews. Fork, duplicate and shared-link fork responses honor the preview parameter, so they no longer seed the conversation cache with the full history. Background-task results whose structure cannot fit a valid JSON preview go whole, image cards keep their prompts, and the subagent panel offers a retry when its stored part fails to load. * 🧾 fix: Key Hydrated Parts by Preview Revision and Call Identity A fetched part is now cached under the preview's revision and replaces only the fields the server shortened, so a call whose stored output changes later (a harvested background result) is fetched again rather than rolled back. Part lookups carry the run-step and agent identity and refuse an ambiguous fallback, since provider tool-call ids can repeat within one response. A subagent that finished without final text has its transcript omitted like any other settled call, and JSON nested past a fixed depth falls back to a text preview; a call whose preview fails is sent whole instead of failing the conversation load. * 🧾 fix: Release Hydrated Parts With Their History and Bound JSON Work Full tool-call parts fetched for a conversation are removed when its message history is released or cleared, so they cannot outlive it under their own key. The structure-preserving JSON preview now bails out before cloning when the value has more nodes or strings than could ever fit, keeps a __proto__ key as ordinary data, and the part endpoint accepts any safe-integer index instead of an arbitrary ceiling. * 🧾 fix: Count Property Names Before Cloning a JSON Preview Property names are never shortened, so the pre-check now adds their length to its budget and falls back to the text preview before any cloning when they alone could not fit. * 🧾 fix: Preview Artifact and Branch Responses and Rehydrate Subagent Prompts Artifact edits and parallel-response branches merge the message the server returns into the conversation cache, so both requests now ask for previews and their routes honor it. The subagent panel reads the prompt from the stored arguments once they load, and the part endpoint no longer caps identifier length, so any previewed call can be fetched. * 🧾 fix: Preview Only Tool Calls That Can Be Fetched Back by Identity A call without an id has nothing but its position to name it, and the position can shift on the client, so it is left whole instead of being previewed. The part endpoint now requires a tool-call id, so an indexed lookup always confirms the call it returns. * 🧾 fix: Fetch Parts by Exact Identity and Preview Only Unique Ones The part endpoint now finds a call by its exact identity (provider id, run-step id, agent) instead of trusting the client's index, and the preview pass only shortens calls whose identity is unique in their message, so every preview names exactly one stored part. Legacy web-search failures that carry their error phrase mid-output go whole, since the collapsed card reads that phrase anywhere. * 🧾 fix: Bound the JSON Fit Walk Before Queueing and Normalize Empty Identities The structure check now counts an array's or object's children against the node budget before queueing them, so a very wide value is refused without building a work list its size. An empty run-step or agent id is treated as absent by the part lookup, matching how the preview pass and the client already treat it. * 🧾 fix: Key Fetched Parts to the Stored Version and Hydrate Search Details Each preview now carries `previewRevision`, when its message last changed, and the client keys fetched parts to that plus a fingerprint of the whole preview, so any change to the stored call is fetched again. The web-search details card asks for the stored call when it opens, so its query is never left shortened. * 🧾 fix: Cache Fetched Parts by Identity and Hold Copy Until Hydrated The part query key drops the client-side index, which only rides along in the request; the server locates the call by message and exact identity, so a shifted index serves the cached copy instead of downloading it again. Copy controls inside a previewed part are disabled until the stored content arrives, so a slow or failed fetch cannot export shortened text. * 🧾 fix: Shape Shared Forks With the Recipient's Bounds and Keep JSON Numbers Exact A shared-link fork resolves the share owner's config for its content checks, but the forked conversation belongs to the requester, so its preview bounds now come from the requester's tenant and role (prepareResultToolCallPreviews). A structure-preserving JSON preview now requires every number in the text to survive a parse and re-serialization as the same value; an integer past 2^53, an out-of-range exponent or an over-precise decimal falls back to the text preview (or the whole output for parsed-output tools) instead of showing a changed value. |
||
|
|
3a32d8b0d3
|
🏝️ fix: Let a No-Workspace Turn Carry a Remembered Approval Mode (#16763)
* 🏝️ fix: Let a No-Workspace Turn Carry a Remembered Approval Mode
A conversation set to run without attached workspaces failed every turn with
"The selected code approval mode is not permitted by the current policy" when
the reader had picked Accept edits or Full access for a workspace earlier.
With no attached target, the server validated the requested mode against an
empty policy that only allows ask. A turn with no attached target now accepts
any known mode, resolves it to ask for the run, and keeps the conversation's
stored mode instead of overwriting or unsetting it. Unknown values are still
rejected, and any attached target, including a subagent's, keeps the strict
check.
The composer treated an explicit no-workspace chat as still running on the
agent's default machine, so it kept offering and submitting the remembered
mode. It now offers no attached mode there, and the submit path sends ask
whenever the turn resolves to run without a workspace.
* fix: Leave an Unset Approval Mode Unset on a No-Workspace Turn
A turn without an attached target seeded the conversation's approval mode
from the request when the row stored none. A current client sends the gated
ask there, so the first no-workspace turn of a new chat wrote ask and
replaced the remembered pick the composer would otherwise keep offering.
Such a turn now only carries forward a mode the conversation already stores;
a stored mode still comes only from a turn that validated it against its
attached targets.
* fix: Gate the Approval Menu on the Resolved Workspace Mode and the Saved Conversation
The composer hid attached approval modes only for a chat that recorded a
no-workspace decision, while useCodeWorkspace also resolves one for a saved
chat with no recorded decision and for a draft still choosing. The approval
menu, the queued-turn snapshot, and the submit path now read the mode the
composer resolved, so the control matches what the turn sends.
A no-workspace turn kept the mode of the row admission loaded, but a turn
sent with overrideConvoId is saved under another conversation; the stored
mode is now read only when that row is the conversation being saved.
* fix: Preserve the Saved Conversation's Approval Mode Through a No-Workspace Turn
A no-workspace turn chose what to record from the row admission loaded, but
a turn sent with overrideConvoId is saved under another conversation while
its unsets are still computed from that loaded row, so either the source
row's mode was copied onto the target or the target's own mode was unset.
Such a turn now records no mode and declares codeApprovalMode preserved:
the conversation write skips it when computing unsets, so the stored mode of
whichever conversation the turn is saved under stays as it is, and a chat
that stores none keeps offering the remembered pick. Turns with attached
targets record exactly the mode they validated, as before.
|
||
|
|
dc375a8e1c
|
🪪 feat: Name and Face Subagents Like Main Chat Turns (#16692)
* 🪪 feat: Name and Face Subagents Like Main Chat Turns
The subagent panel and its main chat entry points named children by agent
id ("Subagent: agent_…") and framed a parent agent's briefing as a
"System" turn under "Parent agent dispatch". They now use main chat's own
author treatment:
- MessageRow gains `showAuthor` (a user-side turn written by someone other
than the reader carries the agent header, mirrored) and `outlined`
(host-delivered body without a system heading). The agent header is a
shared render helper with static classes, so main chat rows render the
same tree as before.
- Panel: the parent's briefing and follow-ups are filled user turns under
the parent agent's name and avatar; the header, composer placeholder and
child turns share one resolved author. External events stay system turns.
- Main chat: a subagent wake-up is headed by the subagent's name and face,
outlined, with an outcome icon; background-tool wake-ups stay "System".
The subagent card leads with the agent's name, and a detached card shows
the indexed task status from a leaf component.
- Shared conversations resolve the same authors from the shared thread.
- `resolveSubagentAgentId` reads an `agent_` type only when no identity was
recorded, never for a graph child. Ids never reach visible text; an
unresolvable agent is named generically.
* fix: Preserve Subagent Identity and Accessible Status
* fix: Skip Private Avatar Queries on Public Shares
* fix: Preserve Restored Authors and Reuse History Lookups
* fix: Respect Graph Identity and Await Historical Authors
* fix: Retain Indexed Identity and Shared Wakeup Authors
* fix: Render Wakeup Authors in Public Shares
* fix: Resolve Shared Wakeups from Persisted Dispatch Identity
* fix: Preserve Wakeup Provenance and Parallel Self Identity
* fix: Refresh Author Snapshots Between Subagent Dispatches
* fix: Align Wakeup Copy and Dispatch Identity
* fix: Resolve Restored Subagent Authors Consistently
* fix: Preserve Indexed Subagent Display Names
|
||
|
|
d55dbc3bd8
|
🔱 feat: Simplify Steering Controls to Three Modes (#16759)
* 🔱 feat: Simplify Steering Controls to Three Modes
* Preserve Admitted Artifacts During Interrupts
* Preserve Result Admission Across Interrupts
* Gate Interrupt for Provider-Hosted Tools
* Match Interrupt Hints to Availability
---------
Co-authored-by: Lia <lia@librechat.ai>
|
||
|
|
82cde522f2
|
💳 feat: Show Balance in the Context Gauge as Credits, Currency, or Percent (#16762)
* 💳 feat: Show Balance in the Context Gauge as Credits, Currency, or Percent Move the balance out of the account menu into the composer's context gauge, below the context window, and add `balance.display` (credits | currency | percent, default credits) to choose how it reads. Currency reuses `interface.currency` at 1,000,000 credits per USD; percent shows only the share of the period's allotment spent. Settings > Account > Billing renders the same summary from the same hook, so both surfaces show identical figures, bar and refill timing in every mode. * 🧭 fix: Normalize the Balance Display Mode and Reuse a Fresh Reading on Hover Admin overrides reach the client without schema validation, so an unknown `balance.display` now reads as credits instead of being typed as a mode it is not. Hovering the gauge mounts the balance reader each time the card opens; a 30 s stale window stops every hover from refetching, while the explicit refetch after each turn still bypasses it. * 🩹 fix: Restore Gauge Popover Fixes and Tighten Balance States The popover extraction was written from a pre-sync read of TokenUsage, so it dropped dev's viewport caps and scrolling, the hideOnInteractOutside close fix, the Tailwind v4 outline-hidden rename, and the card's max-w-full; restore them. Refill copy now says when a refill becomes available rather than promising a deposit, since one lands only once the interval has passed and a charge would exhaust the balance. An empty balance reads as fully used even without an allotment, percent mode without one says usage is unavailable instead of leaving the figure blank, the balance-only ring takes the balance tone (amber until empty) and is a meter only once it has a value. * 🪙 fix: Read a Non-Positive Refill Amount as No Auto-Refill in Settings The server never refills when the amount is not positive, and the balance summary already says so; Settings showed its load error instead. * 💸 fix: Show the Insufficient-Funds Error in the Balance Display Mode The token-balance error still printed raw credit figures, so `percent` leaked the numbers it hides and `currency` mixed units with the gauge. It now reads the same display mode and formatter as the balance summary: credits as before, money in currency mode, no figures in percent mode. The auto-refill settings row also renders its own loading and failure states, since settings search can show it without the balance row beside it. * 🎚️ fix: Keep Fractional Credits and Drop the Moved Popover's Suppression Credit amounts keep up to two decimals, so an insufficient-funds message no longer reads 100.4 against 100.3 as 100 against 100; whole amounts still print without decimals. The design-rule backlog may not follow code into a new file, so the extracted popover uses the standard `transition` utility instead of the arbitrary `transition-[opacity,transform]` (which also misses Tailwind v4's separate `translate` and `scale` properties) and its suppression is removed. The composer geometry spec now reads the classes from `Popover.tsx`, where the gauge button lives. |
||
|
|
c23fbc8f77
|
🧬 fix: Default Subagents to Their Parent's Code Machine and Workspace (#16756)
* 🧬 fix: Default Subagents to Their Parent's Code Machine and Workspace
A subagent resolved its code machine from its own saved fields only, so
when a chat routed the parent to an allowlisted machine the subagent fell
back to its own default and whatever workspace the conversation had
selected there, or failed the parent's whole turn when none existed.
Subagents now inherit the parent's resolved attached machine when it is
their own default or on their allowlist where per-chat choice applies,
the principal can use it, the sealed decision already selected it, and no
selection names the subagent as an explicit owner. Inheritance is derived
per request from the sealed decision and current agent configuration and
fed to every routing site; it is never persisted, so existing chats and
older clients get it without a decision change. The composer mirrors it.
A subagent whose machine has no usable workspace is advertised to the
parent as unavailable instead of failing the turn; a locked decision
stays fatal.
* fix: Inherit Across Every Spawning Path, Graph Members and Deferred Code Tools
A subagent now inherits only when every agent that can spawn it, at any
depth, runs on the same machine; spawn cycles keep their own routes.
Subagent graph members inherit like explicit subagents. The deferred
execute_code loader passes inheritance to its fallback resolver. Subagent
reads and VIEW checks move to a packages/api loader shared by inheritance,
lazy descriptors and graph members. The composer lets a draft's subagent
follow its parent's machine before a workspace is picked, and keeps an
inheriting subagent's former selection without asking for a move.
* fix: Prune Spawn Back-Edges, Gate the Composer on an Inheritance Capability
Spawning parents follow the run's path semantics, so a back-edge the
descriptor tree prunes no longer blocks inheritance, and agents that spawn
each other follow their single outside parent machine when it routes them
all there. Only admitted subagents count toward the walk's node limit.
Graph members re-read and re-check VIEW when they initialize. The composer
echoes an inheriting subagent's former selection without gating on that
machine, and mirrors inheritance only when the API advertises
codeWorkspaceInheritanceVersion; approval modes keep intersecting every
machine an agent could use.
* fix: Settle Each Mutually Spawning Group on Its Own
Independent spawn cycles no longer merge into one group, so a pair under
one parent follows that parent even when another pair follows a different
machine. Also types the data-provider spec for its ES5 target.
* fix: Bound the Inheritance Walk, Normalize Parallel Roots, Move Subagent Availability to TS
The walk reads in batches no larger than the remaining node budget, stops
once the limit is reached, and runs through the run's subagent load limiter.
Roots are keyed by saved agent ID, so a parallel root such as id____1 can
never receive an inheritance entry. Resolving a lazy subagent's code route,
reporting it unavailable, and guarding its descriptor now live in
packages/api (resolveSubagentCodeAvailability, guardUnavailableSubagent).
* fix: Keep Missing Subagent Loads Parallel Near the Node Limit
Batches never shrink below eight IDs, so missing or unviewable subagents
near the limit still load in parallel under the injected limiter, and at
most a handful of reads land past the limit.
|
||
|
|
7e575c047f
|
🔍 feat: App-Wide UI Scale Setting (#14903)
* feat: add app-wide UI scale setting * test: align dev's new header, drawer and combobox specs with the scaled shell * fix: keep design-recorded arbitrary values off the same-count swap * fix: scale composer and reasoning spacing on the spacing scale * test: reach scaled rows and wait on the composer under the unpainted drawer * test: cover the scaled composer at both ends of the range * test: reload the composer scenario at each scale from the live page * fix: leave the root style untouched at the default scale * test: align dev's tool output and subagent inset specs with the rem classes * fix: scale a caller's combobox height cap with its rows * fix: size the conversation list's row estimate on the scaled drawer breakpoint * test: align dev's conversation row status spec with the scaled drawer breakpoint * style: sort the settings dialog imports after the dialog layer merge * fix: scale the collapsed combobox's fallback popover width * fix: size the upload glyph on both axes so it grows with the scale |
||
|
|
3e4b01834f
|
🫗 perf: Release Message Histories of Conversations the User Has Left (#16747)
* 🫗 perf: Release Message Histories of Conversations the User Has Left Long agent conversations hold 12-18 MB of message JSON each in the React Query cache, and the default 5-minute cacheTime kept every conversation visited in that window. Switching between a few of them on mobile Safari grew the JS heap past 300 MB and crashed the tab. retainMessages tracks when each per-conversation history loses its last observer and releases it once it has no observers, is not fetching, is not pinned, and is either older than 60 s or beyond the single most recently left conversation. The routed conversation, conversations with a running job, and conversations awaiting an approval decision stay pinned; releases wait while any mutation is pending. Returning to a released conversation refetches its history. * 🫗 fix: Own History Collection, Configure the Grace, and Pin by Server State Per-conversation histories get an infinite cacheTime while retention runs, so React Query's own five-minute collection can no longer drop a history a running job still pins; newly seeded histories schedule a pass; the grace and recent count come from interface.historyCacheTtlMs and interface.historyCacheRecent; the approval pin is replaced by the active-jobs set, which already lists jobs paused for a live approval; and Assistants histories stay pinned because deletion reads their thread id from the cache. * 🫗 fix: Re-arm Collection for Histories Already Counting Down and Recheck Pins Promptly A history left before retention started still had React Query's five-minute GC timer; a momentary observer now re-arms it under the infinite cacheTime. Histories kept only because they are pinned or fetching are judged again after 5 s instead of a full TTL, so a run that ends releases its transcript promptly. * 🫗 fix: Exempt Assistants Histories Without Polling and Leave Fetching Histories Alone Assistants histories are now exempt rather than pinned, so they are kept without a recurring recheck timer. The startup re-arm skips histories with a fetch in flight, since detaching a momentary last observer would cancel the request; settling the fetch re-arms collection on its own. |
||
|
|
0e3c9088f6
|
🫰 feat: Configure Tool Approval Modes Per Agent (#16707)
* 🫰 feat: Configure Tool Approval Modes Per Agent
* fix: Fence Remembered Tool Approval Authority
* fix: Unify Tool Approval Execution Invariants
* fix: Revalidate Learned Approval at MCP Invocation
* fix: Preserve One-Time MCP Review at Invocation
* fix: Execute Reviewed Calls on Templated MCP Connections
* fix: Scope Approval Witnesses to Executing Agents
* fix: Retain Approval Bindings for Hook-Rewritten Inputs
* fix: Pin Review Authority and Retire Settled Tool Calls
* fix: Fingerprint Effective MCP Request Headers
* fix: Preserve Routing Around Renewable MCP Token Fragments
* fix: Bind Tool Consent to OAuth Credential Generations
* test: Keep Mobile Approval Save Outside Drawer Escape Race
* fix: Fence OAuth Consent at MCP Transport Retries
* fix: Let Shared Agent Viewers Reset Personal Consent
* fix: Preserve Renewed Consent Across Reset Races
* fix: Resolve Verified Aliases for Personal Tool Reset
* fix: Fence Renewed OAuth Consent and Credential Review
* fix: Require Foreground Execution for Review-Only MCP Calls
* fix: Pin Invocation Ownership and Stable MCP Consent
* fix: Fence Superseded Tool Consent Completion Writes
* fix: Scope Consent Epochs to Effective MCP Authentication
* fix: Scope Approval Admission to Reachable Agent Tools
* fix: Preserve Approval Epochs for Runtime-Detected OAuth
* fix: Address Tool Approval Review Findings
* fix: Preserve Captured Consent When Tool Approval Is Inherited
* fix: Preserve Approval Admission Through Lazy Metadata
* fix: Fence Programmatic Reviews and Unresolved Lazy Approval Keys
* fix: Account for Normalized and Skill-Contributed Lazy Tools
* fix: Scope Lazy Approval to Selected Tool Spellings and Servers
* fix: Honor Disabled MCP Capability During Lazy Approval Admission
* test: Preserve Approval Merge Regressions After Rebase
* fix: Preserve One-Time Review During Non-OAuth Grant Outages
* fix: Retain One-Time Consent Across Resume Recovery
* fix: Preserve Reviewed Consent Through Transport Outages
* fix: Preserve Case-Variant Lazy Approval Hook Admission
---------
Co-authored-by: Lia <lia@librechat.ai>
|
||
|
|
741978c954
|
🔭 feat: Recover Stale Chunks Without the Error Page and Ship Client Logs to RUM (#16701)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
* 🔭 feat: Recover Stale Chunks Without the Error Page and Ship Client Logs to RUM Stale chunks: a tab left open across a deploy that opens a code-split panel requests a hashed chunk the new deploy removed. Vite's preload handler hands the failure to the stale-asset recovery, which reloads, but the import then resolves to `undefined` and `React.lazy` throws a TypeError into the route error boundary, so the error page flashes before the reload. Lazy imports now go through `lazyWithRecovery`/`importWithRecovery`, which turn that result into a `ChunkLoadError`; the route boundary recognizes chunk failures (and any error while a recovery reload is underway), asks the page recovery once, and renders a localized "Updating to the latest version…" status. When the loop guard declines, the normal error page with its reload action shows instead. The page recovery is now idempotent within a page, so concurrent callers join the in-flight reload rather than tripping the guard. Client logs: with RUM in proxy mode, the client logger's warn/error calls, error-boundary catches and stale-asset recovery events are exported as OTLP log records through the authenticated `/api/rum/v1/logs` proxy. Records carry allowlisted, scrubbed fields only, follow RUM session sampling, dedupe repeats with a count, are budgeted per minute and per page, batch with backoff, flush with keepalive on page hide, and stop after persistent failures. The proxy now refuses non-OTLP content types and applies a per-user rate limit. `RUM_CLIENT_LOGS=false` turns the export off. * 🔒 fix: Keep Client Logs Opt-In and Drop Application Error Messages - RUM_CLIENT_LOGS now defaults to off, like console capture, so enabling RUM proxy mode never starts a new log stream on its own. - Error messages are exported only for engine, browser and library generated types (TypeError, SyntaxError, DOMException, AxiosError, chunk failures); application errors keep type, status and stack only, since their messages can echo prompt or response text. All quoted fragments are now redacted. - Batches are measured in encoded UTF-8 bytes of the exact request body, and page hide drains every queued record that fits the keepalive quota. - Queued stale-asset events are delivered as soon as the log exporter starts, independent of the RUM SDK loading, and marked so they are never logged twice. * 🔒 fix: Export Only Known Generated Error Messages and Ack Queued Events - Error messages are exported only when the whole text matches a known engine, browser or library message shape (property access on undefined, "x is not a function", fetch/abort/axios status, chunk and CSS preload failures). The error class alone no longer qualifies, since any code can throw a TypeError carrying arbitrary text. - Queued stale-asset events are marked logged only after the collector accepts the record carrying them, so an undelivered event replays on the next page; in-flight events are skipped by the SDK path. - A fractional RUM_PROXY_USER_MAX below one falls back to the default instead of flooring to a limit of zero. * 🔒 fix: Hold Unacknowledged Asset Events, Re-send In-Flight Logs on Hide - The RUM SDK flush no longer drops queued stale-asset events whose client log record is still unacknowledged: they stay queued and persisted, flagged so their SDK action is not repeated, and leave the queue once the collector accepts the record. - Page hide re-sends the records of an unanswered regular request with keepalive; each record belongs to the latest request carrying it, so a late response to the original request neither marks nor requeues it. - Client-log export stops when the authenticated layout unmounts. - The proxy refuses /v1/logs while client logs, console capture and replay are all off, so turning RUM_CLIENT_LOGS off also stops tabs that still hold an older startup config. * 🔒 fix: Export Only Complete Stack Frames, Never the Message Header Stack reduction now strips the V8 `name: message` header (including every line of a multi-line message) and keeps only lines with a complete V8, Gecko or WebKit frame shape that ends in a URL or absolute path with a line number. A message ending in a source-position-like suffix can no longer pass as a frame. * fix: centralize RUM delivery and asset recovery lifecycle * fix: preserve RUM page lifetime and collector acknowledgements * fix: retain page transport quotas and recover functional chunks * fix: scope RUM client sessions to authenticated identity --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
19092e55bd
|
🖲️ fix: Enable Running Chat Menus and Preserve Renamed Titles (#16697)
Reconciles current dev while preserving manual title ownership, existing menus, and configuration regressions. Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
1f195dcf9d
|
📩 fix: Stage URL Prompts Before Agent Submission (#16647)
* fix: Stage URL prompts before agent submission * test: Preserve startup cache in URL composer coverage * fix: Preserve URL drafts and schema-normalized spec readiness * fix: Scope URL submission lifecycle and retain spec overrides * fix: Match retained tools and inherited project transitions * fix: Preserve source drafts while staging URL prompts * fix: Reconcile URL routes and persist settled prompts * fix: Preserve existing project conversation ownership * test: Await settled activity fold before checking its prose * fix: Hold dictation sends during URL preparation * fix: Hold live-run composer actions during URL preparation * fix: Process subsequent URL prompt navigations --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
35db010412 | feat: Simplify Queue Row Actions And Steer Controls | ||
|
|
ac2b51e98f | fix: Order Server Snapshots Against Pending Read Intent | ||
|
|
c85795d08f | fix: Fence Reply Read State and Preserve Snapshot Clears | ||
|
|
c41413ad21 | fix: Keep Manual Unread Reminders in Date Groups | ||
|
|
b24226672d
|
🌊 perf: Trim Per-Token and Per-Render Work in Streaming and Lists (#16718)
* perf: Trim Per-Token and Per-Render Work in Streaming and Lists * test: Assert Rendered Diff Rows Alongside Render Counts * refactor: Read the Active Sidebar Row Through the Existing Index Selector Drops the new Recoil selector: conversationIdByIndex(0) already yields a primitive id, so rows still skip re-renders on every conversation write. The DiffView row test keeps the real cn behind a spy and derives the per-row cost from the first render. * test: Cover the Sidebar Active Row Across Chat Switches and New Chat |
||
|
|
c945cafa34
|
🏃 fix: List Every Running Chat in the Sidebar's Running Group (#16668)
* 🏃 fix: List Every Running Chat in the Sidebar's Running Group
The Running group partitioned the Chats list's own rows, so a running chat
filed in a project, a pinned chat, or one past the loaded pages never
appeared in it. Running chats the loaded rows do not hold are now fetched
by id and merged in newest first, with a project badge on filed chats.
Narrowed lists (search, filters, facets, archive) keep only their own rows.
* fix: Keep Fetched Running Rows Current, Accessible, and Scoped
- Fetch only under the newest-first sort that shows the Running group.
- Re-ask within two seconds for a record not written yet, so a short
run is not missed; keep the 15-second refresh once it exists.
- Leave archived chats out of Running.
- Patch and clear the fetched rows through updateConvoInAllQueries and
removeConvoFromAllQueries, so renames, pins and removals show at once.
- Carry the shared-link state the list endpoints derive.
- Seed an empty conversation cache with the fetched record for navigation.
- Describe the focusable row with its project name.
* fix: Preserve Running Chat Cache Updates and Picker Keyboard Activation
* fix: Open the Assistant Picker Through Its Supported Keyboard Handler
* test: Keep SSE Cleanup Query Client Cancellation Compatible
* fix: Keep Temporary Chats Out of the Running Sidebar
* fix: Preserve Running Rows Across Initial Fetch Cancellation
* fix: Preserve Running Removal and Server Read Authority
* fix: Record Running Removal Before Query Creation
* test: Type Running Query Regression Props Explicitly
* fix: Keep Chat Settings Out of Running Sidebar Rows
---------
Co-authored-by: Lia <lia@librechat.ai>
|
||
|
|
0c5e1ce67f
|
📕 fix: Explain Native Web Search Permission Denials (#16691)
Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
fc05ea3946
|
🙋 feat: Refine the Ask Question Card and Smooth Batched Question Steps (#16641)
* feat: Refine the Ask Question Surfaces and Drop the Stop Shortcut Hint * feat: Smooth Step Changes in Batched Questions With Numbered Option Rows * fix: Swap Batched Question Answers Instantly While the Height Eases * fix: Keep the Batch Card's Place in the Thread and the Answer Placeholder While Locked * feat: Instant Option Row Hover and Typed Answers Replace Choices * style: Fade Option Rows Slowly When They Lock * feat: Swap Batched Questions Instantly While Only the Height Eases * fix: Ease the Batch Status Lines and Keep Question Controls Unselectable * fix: Stop the Batch Answer Area From Showing a Scrollbar * fix: Keep the Locked Composer Placeholder Out of Text Selection * feat: Check Mark on a Chosen Single-Select Answer * feat: Turn the Question Move Chevron During the Composer and Chat Morph * fix: Ease Only the Batch Card's Outer Height When Switching Questions * fix: Pin the Batch Header and Buttons to the Card Edges While Its Height Eases * fix: Confirm Batch Answers on Enter, Bound Long Prompts, and Keep the Form on Jotai * test: Scenarios for Batched Ask Question Answers * test: Pause the Fake Model on a Real Question Batch for the Ask Scenarios * test: Run the Ask Scenarios in a Desktop Context * fix: Cap the Batch Question Popover to the Viewport * fix: Scroll the Capped Batch Card, Guard IME Enter, and Keep Focus on the Next Question |
||
|
|
35a2bee409
|
🗂️ feat: Choose Conversation Checkout Mode (#16679)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
* feat: Choose the conversation checkout mode * fix: Preserve checkout choices across submission and recovery * test: Match checkout policy defaults and share mode enum * fix: Offer shared checkout and require deliberate transition modes * fix: Retain explicit mode when changing repository selection * test: Match repository menu accessible labels |
||
|
|
bc9af0785d
|
💬 fix: Keep Healthy Workspace Detach Available (#16670)
* fix: Keep healthy workspace detach available in chat * test: Clarify healthy workspace detach coverage * fix: Restore workspace detach static checks --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
73d704656e
|
📔 feat: Preserve Owner Text During PII Redaction (#16311)
* 📔 feat: Preserve Owner Text During PII Redaction * 🧵 fix: Keep Ordinary Chat Views Outside Private Text Provider * 🧷 fix: Preserve Owner Text Across Copy and Edit Paths * 🔏 fix: Protect PII on Denial and Abort Paths * fix: preserve protected text through denial, stop, and owner reload * test: cover preliminary private metadata in disconnect fixture * test: carry preliminary metadata in resume controller fixture * test: preserve Stop prerequisite identity in tenant fixture * fix: keep protected owner text out of search and exports * fix: preserve trusted PII placeholders through provider inspection * fix: coordinate protected turns across Stop and native sharing * fix: Preserve Private Text Admission and Query Lifecycles * fix: Track Private Query Effect Dependencies * fix: Fence Protected Admission and Screenshot Targets * fix: Share Protected Admission and Preserve Native Token Trust * test: Wait for Private Message Concurrency Indexes * fix: Preserve Protected Admission Across Recovery and Titles * fix: Coordinate Protected Root Admission and Early Stop --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
2eee568542
|
🧳 feat: Choose Agent-Allowed Machines For New Chats (#16651)
* feat: Let New Chats Choose Agent-Allowed Machines * test: Keep Machine Choice Contracts And Native Selectors In Sync * fix: Preserve Graph Machine Choices And Reference Lifecycles * fix: Explain Graph Workspace Requirements And Validate Machine Choices * test: Cover Default And Non-Default Graph Machine Choices * test: Keep Unauthorized Machine Duplication Mocks Isolated * fix: Preserve Graph Agent Machine Ownership And Explain Requirements * fix: Preserve Stable Workspace Ownership Across Runtime And Config Changes * test: Wait For Verified Generation Readiness In Native Canaries |
||
|
|
3699557010
|
🍵 fix: Preserve Workspace Decisions in Warm Chat Caches (#16648)
* fix: preserve acknowledged workspace decisions in chat caches * fix: fold code decisions after conversation construction --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
4d27facffe
|
🛷 perf: Reduce Browser Work When Sending Documents (#16646)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
92432e95d5
|
🔐 feat: Enforce Required Two-Factor Authentication (#14731)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
* feat: enforce required two-factor authentication Require local and LDAP accounts to enroll in TOTP before they can use the app when ENFORCE_TWO_FACTOR_AUTHENTICATION is set. Sign-in, refresh, bearer verification, optional share auth and image authorization all route an unenrolled account into a staged setup flow, and every bearer credential minted before enrollment or a password reset is retired. Password reset retirement uses the existing credentialsChangedAt stamp, and commitPasswordReset clears any staged enrollment in the same write. Passkey sign-in follows the same enrollment gate as password sign-in. * test: cover passkey sign-in handing off to required enrollment * refactor: keep Mongoose user types out of two-factor auth contracts * fix: withdraw a minted session when its retirement recheck fails * fix: hold Agent API keys and the reset CLI to the required two-factor policy * fix: adopt a setup token handed off after the setup screen mounted * fix: move every tab that receives an enrollment hand-off into setup * fix: read the enrollment gate's retirement cutoff in system scope * fix: clear minted session cookies before the fallible session deletion * fix: adopt a setup token persisted before the setup screen subscribed |
||
|
|
e878f864ea
|
🧩 refactor: Serve Chat Context Through a Facade-Owned Provider (#16610)
* refactor: Serve the Marketplace Chat Through a Facade-Owned Provider ChatProvider builds a pane's chat contract and serves it to the facade, so a host no longer imports useChatHelpers to fill ChatContext itself. The marketplace is its first host; its specs stub the helper module the provider imports. * test: Start a Chat From a Marketplace Agent Card Opens an agent's marketplace card, starts a chat from it, and expects the new chat to send its turn to that agent and show the reply. * test: Open the Marketplace Card Through Its Button The card heading sits under the card's click layer, so the scenario clicks the button that takes its accessible name from the heading. * test: Wait for the Marketplace Agent Before Sending The chat route applies agent_id on a short query-param poll and then drops it from the URL, so the scenario waits for the parameter to go before it sends the turn. * test: Type the useChatHelpers Mocks With the Hook's Parameters The provider and marketplace specs pass index and paramId through explicitly instead of an unknown[] spread, and the provider spec builds a complete typed chat contract. |
||
|
|
76b0ea82f5
|
⏯️ feat: Resume Streams and Send AI SDK Messages Through the Chat Facade (#16609)
* feat: Resume Streams and Send AI SDK Messages Through the Chat Facade useChat and useChatActions gain resumeStream, which asks the pane's resume-on-load path to re-check the stream status and reattach through the host transport, and sendMessage now also takes an AI SDK user message of text parts, sent as the ask call it describes. The facade spec covers the new members and the refused-send and failed-stop paths; the transport spec resumes a running generation against a fake transport, stays detached when nothing runs, and reports a reattached stream that fails. * refactor: Keep the Resume Request With the Chat Feature The resume-request atom is written by the facade and read by the chat's resume path, so it moves from the app store to hooks/Chat. * perf: Hold One Resume Request Instead of One per Conversation A request only matters to the pane showing its conversation, so a single atom with the conversation id and a count replaces the per-conversation family, which kept an atom for every conversation a session ever asked to resume. * fix: Keep Each Conversation's Resume Request Until Its Pane Answers A single request slot let a second pane's resumeStream overwrite the first before either pane's effect ran, so the first request was dropped. Requests are now a set of conversation ids: the facade adds its chat, and the pane showing that conversation consumes the entry and answers it. * fix: Attach an AI SDK Message With a Null Parent at the Root A root message's view carries a null parentMessageId, which ask reads as unspecified and replaces with the branch tail. sendMessage now passes the no-parent sentinel for an explicit null, so the turn attaches where its metadata says. * fix: Hold a Resume Request Until Its Conversation Loads, and Send to the Facade's Chat A pane navigating away from an Assistants conversation still reads that endpoint while the route already names the next one, so it consumed a resume request it could not answer. The request now waits until the pane has loaded the route's conversation. sendMessage's AI SDK input also stops accepting a conversationId: the turn goes to the facade's own chat. * test: Keep the Facade Resume Tests in Their Own Atom Store The resume-request tests wrote to jotai's module-global default store and left their entries for later tests; they now render under IsolatedAtomStore and read that store. |
||
|
|
345a20fe3a
|
🪟 feat: Undock the Artifacts Pane into Its Own Window (#15911)
* 🪟 feat: Undock the Artifacts Pane into Its Own Window The artifacts pane could only live in the chat's side panel, so viewing an artifact meant giving up half the conversation and there was no way to put it on a second screen. A header action now moves the pane into a separate browser window and back. The pane stays in the chat tab's React tree and is portaled into the popup's document, so artifacts keep streaming into it and docking back is a re-render rather than a reload. Everything a portal does not carry is mirrored: the host stylesheets (re-synced for lazy chunks, HMR and CSSOM-only rules), the resolved theme, a base URL for relative assets, and Sandpack's frame messages, which would otherwise never reach the listener the opener installed. * 🪟 fix: Keep the Artifacts Pane Whole When It Changes Windows Review of the undock change surfaced one cause behind most of its findings: the pane is a new component instance in every host, so anything a mount decides was lost or wrongly reset when it moved. - The code editor buffer now carries the artifact it belongs to, so a remount restores unsaved text instead of falling back to the persisted content, and the edit the debounce never got to send is handed to the mutation on mount. The share hosts take one provider around every branch for the same reason. - The artifact registry is cleared by the host that owns it: the pane keeps it while it only changes windows, and leaving the route wipes it, so no artifact follows the user to a shared conversation. - Fullscreen exits through the document that owns the container, Mermaid pan listens where its canvas lives, and Copy reports success only once the write resolves, with a toast when it does not. - Style mirroring compares what a sheet actually contains: rules a page inserts through the CSSOM are serialized, and a rewrite the observer saw refreshes its clone even when nothing measurable changed. - A child-activity panel opened while the pane is undocked stays open; the two panels are exclusive only while they compete for the side panel. Adds the scenario suite for the window behaviors (`@scenario:` tagged) plus unit coverage for the registry lifetime, the panel slot and buffer ownership. * 🧭 fix: Carry the Artifacts Tab Across a Window Change The pane's active tab lived in the component instance, so undocking from the code tab landed the user back on the preview — with their unsaved text out of sight, which reads as losing it. The tab is pane state now, next to the editor buffer it belongs with, and the scenario asserts both survive the move. * 🧹 chore: Drop Unused Imports From the Presentation Spec * 🎯 fix: Bound the Artifacts Pane's Shared State to Its Session The second review round found the cost of state that outlives an instance, all in the seams the first round opened. - Download now reads the editor buffer only when it belongs to the artifact on screen, so selecting another artifact cannot export the previous one's edits. - The active tab is reset when the pane session ends — close or conversation change — instead of following a later artifact onto the code tab. - A mutation started by a previous pane instance can no longer report back, so the mount releases the stale "mutating" flag before handing over the restored text; otherwise the edit queued behind a completion that never arrives. - The undocked window's size and position are read while it still has them, in its `pagehide`, so closing through the browser remembers the bounds too. - Docking from the window moves focus to the control that replaces the one the user pressed, which a keyboard user otherwise loses to the document. - The share host keeps one `EditorProvider` mounted across the closed and open branches, so opening the overlay no longer remounts the transcript. * 🎨 fix: Paint the Undocked Window Before Its Sheet Arrives A mirrored stylesheet is a fetch, so the popup showed its default white canvas for that moment — plain against a dark app, and visible to the scenario as a transparent pane. The host's resolved surface colour is now the `var()` fallback in the popup's own layout sheet, so the window opens on the app's canvas and the real token takes over when it lands. The two scenarios that read settled state — the painted canvas, and a keyboard Enter that closes the window it was pressed in — now wait for it instead of sampling the first frame. * 🔭 fix: Focus the Dock Target Once the Pane Has Mounted\n\nThe focus handoff ran before the pane rendered its toolbar, so the control it\nwas meant to focus did not exist yet and the request was never spent. It now\nwaits for the mount that creates that control. * 🧩 fix: Give the Edit Pipeline and the Transcript One Owner Each Round three found the same shape three more times: work that belongs to a session was still decided by an instance or by a branch. - The editor no longer infers whether a previous instance's save is running. React Query keeps a mutation's callbacks on the mutation, so that request settles the shared flag itself; the new instance waits for idle and submits the restored buffer once, instead of clearing a flag it does not own and resubmitting against an `original` the earlier request may have replaced. - The shared conversation keeps its transcript in one place — always the first panel of the resizable group — so opening the pane, undocking it or docking it again changes only the pane's host, not the transcript's ancestry. - The clipboard fallback runs in the pane's own document, so an undocked pane on a deployment without the Clipboard API can still copy instead of only reporting failure. * 🧷 fix: Tie the Editor Buffer and Focus to the Pane Session Round four found the last places where the retained buffer and the focus handoff were decided by a code path rather than by the session boundary. - Closing the pane discards the buffer, the tab and any pending focus request, so reopening an artifact starts from what is saved instead of restoring — and silently resubmitting — text the user abandoned. - Only the buffer an instance inherits at mount is drained. Navigating back to an artifact restores its own unsaved text in the editor instead of writing the persisted content over it, which used to queue that content behind the edit and undo it. - Closing the window through the browser hands focus back exactly as the Dock control does, rather than leaving a keyboard user on the document body. - The clipboard fallback restores focus by capability rather than `instanceof`, which never matches across the popup's realm. * 🔐 fix: Make Undocking Configurable and Its Saves Session-Bound - `interface.artifactUndocking` is a `configSchema` field, default enabled, so a deployment that cannot use popups keeps the docked pane. The hosts resolve it — the chat host from the startup config, the shared host from the shared-link config, which now carries the flag — and hand it to the pane through the context it already takes, rather than the pane reading config itself. - A save carries the editing session it was started in. React Query keeps its callbacks after the editor is gone, and those callbacks used to write the buffer a closed session had just cleared and submit its queued edit; they now stop at a session boundary, so a closed pane mutates nothing and leaves no text behind for the next one. * ✂️ fix: Stop the Editor from Overwriting Another Artifact's Unsaved Text - A write this component makes into the Monaco model comes back through `onChange` exactly like a keystroke. Restoring an artifact's text therefore looked like typing and keyed the shared buffer to the artifact now on screen — so selecting another artifact before the debounce fired replaced the text the first one was still holding, and returning to it showed the persisted content. The value written here is now recognised and consumed, and the retained buffer is sent deliberately when its artifact comes back, which is where its cancelled debounce finally becomes a save. - The save lock is the session's, not a request's. A save that outlives its session no longer clears the lock or the failure notice a later session took, and ending a session releases it — while an edit typed behind a lock whose owner is gone is sent by the editor holding it as soon as the lock is free, instead of waiting for the user to type again. * 🔔 fix: Report Failures in the Window the User Is Looking At The app's toast surface is mounted once in the chat tab, so a notice raised from the undocked pane — a copy that no clipboard path accepted, for instance — appeared in a document nobody was looking at. The window now carries a Radix toast provider and viewport of its own around the portaled pane; the toast state is shared, so the same notice is shown wherever the user is rather than routed by hand at each call site. * 🚧 fix: Offer Undocking Only Once the Deployment Has Answered An absent config read as enabled, which is the default, but a config request in flight reads the same way: a user could undock during that window and the arriving answer would then take the Dock control away with it. Both hosts now treat an unanswered config as no capability, and the pane keeps the control that docks it whenever it is undocked, so a capability that disappears cannot strand the pane in a window with no way back. * 🎯 fix: Land Queued Edits, the Config Toggle and Focus on the Window - A queued edit is sent against the content the artifact actually holds. The save that held the lock has already replaced what that edit was typed against, so submitting the captured `original` had the endpoint reject the newest text and leave it in the buffer alone. - `interface.artifactUndocking` now survives interface loading: `loadDefaultInterface` rebuilds the object property by property, so the flag never reached `/api/config` or the shared-link payload and a deployment that set `false` still saw the control. - Undocking hands focus to the pane the way docking already did. The control the user pressed goes away with the docked toolbar, so a keyboard user was left on the empty document of the window that had just opened; the focus request is now a move in either direction, which is what it is named after. * 🔓 fix: Let the Request Own the Save, Not the Session The save lock was a flag the editor set and cleared, which gave two ways to be wrong: a callback whose session had ended cleared a lock the next session was waiting on, and ending a session released a lock whose request was still running — so a pane reopened mid-save could start a second read-replace-save against content the first request was about to change. The state is now the request's. The artifact save carries a mutation key and `isMutating` is read from React Query's mutation cache, so it is true exactly while a save is in flight, whoever started it: nothing to release, nothing to leave behind, and an editor that appears mid-save queues its edit and sends it — rebased on the content that landed — once the request settles. * ⏱️ test: Give the Undocked Preview Time to Compile * 📌 fix: Rebase a Queued Edit on What the Save Actually Wrote The artifact registry catches up when the edited message propagates, not when the save returns, so an edit sent in between was rebased on content the server had already replaced and the endpoint rejected it. The text the last save wrote is on the request itself: the drain reads it from the keyed mutation in React Query's cache and falls back to the registry only when there is no save to speak of. The same applies to a buffer inherited at mount, which is submitted against that record too. * 🧷 fix: Keep the Pane's Tab and Its Storage Off the Instance Both findings of the review at a03ee0f7 are the same shape as the ones before them: something the pane needs was reached for where it does not survive. - The tab is pane state, but the reset that keeps it honest was an instance ref. A host change mounts a new pane, so that ref started empty, read the artifact already on screen as freshly opened and wrote `preview` back — undocking and docking both returned the user to the preview, which reads as the code they were editing having been thrown away. The marker moves to the atom beside the tab it guards, and ends with the pane session like the rest of it. Opening a *different* artifact still returns to the preview. - `localStorage` was reached for at the call site. A policy that denies Web Storage throws from the getter itself, before the guard around `getItem` could run, so undocking threw instead of falling back to default bounds and the redock and teardown paths threw on their way home — stranding the pane in a window whose control the user had just pressed. Both helpers take the window and touch storage inside their own guard. The scenario that should have caught the tab defect asserted `aria-checked` once, which matches the frame before the reset lands, so it is polled now. * 🧪 test: Drop the Denied-Storage Scenario the Shell Cannot Support Verification at c94e5ef showed the scenario asserting a capability LibreChat does not have: denying Web Storage in the browser replaces the page with the error boundary ("denied") before the pane's controls are reachable, so the popup never opened and the test timed out in all three projects. The finding behind it was about one call site — the pane reaching for `source.localStorage` outside the guard around its `getItem` — and that stays fixed and covered by the unit tests in `undockedWindow.spec.ts`, which reproduce the throwing getter and fail without the fix. Surviving denied storage app-wide is the shell's problem, not the pane's, and is tracked at berry-13/LibreChat#41. The spec says why the scenario is absent so it is not added back. * 🔗 fix: Match the Artifact Trigger's Name as Dev Now Builds It The scenarios opened the artifact by its full accessible name, spelled out as "<title> Click to open". Dev's "Unify Artifact Triggers as Tool Rows" (#15915) folded the format badge and whether the row renders a preview into that name, so it now reads "E2E HTML Artifact HTML Opens as a rendered preview Click to open" and an exact match finds nothing. Every scenario in the file failed at its first click, three retries deep, which is what pushed the e2e shard past its 30 minute ceiling. This did not show up locally because the mock harness serves `client/dist`, and mine was built before the rebase. The old bundle still rendered the old name, so the stale locator passed here and failed in CI — and dev's own `plain-text-artifact-row` spec failed locally for the mirror-image reason. Both pass against a freshly built client. The trigger is matched on its title now, the way dev's spec does it, so the badge and the preview hint can change again without breaking the file. * 🍞 fix: Share One Toast Viewport Between the App and the Window The undocked artifacts window needs a toast viewport of its own, and it carried its own copy of the app shell's class list — so any change to toast placement, stacking or width would have had to be made twice, or the popup's notices would drift from the app's.\n\nThe viewport is now one composition in \, rendered by both hosts. It keeps the class list it always had and still takes a \, so the popup can adjust its own placement without forking the primitive. * 🚫 fix: Keep a Rejected Edit Rejected Across a Host Change A save the endpoint answers with 400 is deterministic, and the editor already refuses to send that exact text again. The refusal lived in the editor instance while the text itself lives in the shared buffer, so moving the pane to another host — which remounts the editor — dropped the marker and the inherited-buffer drain immediately sent the rejected text back, against the same original that produced the 400. Every dock or undock cost another rejected request, with no new edit from the user.\n\nThe marker now sits beside the buffer it describes, in the editor session, and names the artifact it was recorded for. A remount inherits it; a successful save clears it; ending the session clears it with the buffer. Returning to an artifact no longer resends its rejected text either, for the same reason. A genuine new edit still saves. * 🧭 fix: Key the Artifact Registry to the Host's Conversation The guard that bounds the artifact registry to one conversation decided that the conversation had changed by reading the chat tab's Recoil slot, which the shared route never sets. A shared conversation's host stays mounted while the reader moves between shared links, so on that route the change was invisible and only the unmount cleanup ever fired: artifacts from the previous link stayed in the registry, and opening an artifact in the next one could list and navigate back to the previous share's content.\n\nThe identity is now the host's to supply — the chat tab passes its Recoil slot, a shared conversation passes its own id — which is also what keeps the hook from reaching into app-global state for something only its caller knows. The first observed identity still does not wipe, so the loading transition into a shared conversation keeps the artifacts that belong to it. * 🧪 test: Cover the Shared Host, a Blocked Popup and a Rejected Save Three paths the pane reaches that no scenario exercised: a shared conversation, whose host resolves the undock capability from the shared-link config; a browser that refuses the popup, where the pane has to stay put and say so; and an edit the endpoint rejected, which must not go back on the wire because the pane changed hosts. * 📝 docs: Document the Artifact Undocking Toggle in the Example Config \ reached the schema and the shared-link config without ever appearing in the example file a deployment copies, so the lever existed but was undiscoverable. Documented with the default that reproduces today's behavior. * 🔐 fix: Make the Undock Capability the Host's Answer, Not a Default \ filled \ with \ when a host left it out, so a host that forgot would offer a window the deployment may have turned off — the one field in that context with no sensible fallback. It is now required, which makes forgetting it a compile error instead of a capability grant. * 🕰️ fix: Read an Absent Conversation as Loading, Not as a Switch The registry guard normalized a missing identity to a sentinel and stored it, so a host that reported nothing for a render — a shared link whose data refetches, a chat tab reading its slot before it is filled — looked like a move to another conversation. The reader lost the artifact they had open, and the same conversation coming back read as a first sighting.\n\nAn absent id is now no news at all: the last real identity stays the one the next id is compared against, so returning to it changes nothing and a real switch still wipes. Reported by Devin review of 097f9bfadd (BUG-0002), which also caught that ShareArtifactsContainer's comment already promised this behavior. * 🏷️ fix: File a Refused Save Under the Artifact That Was Refused The rejection marker was written with whichever artifact the pane happened to be showing when the 400 landed. A save answers after the user may have moved on, so a refusal for artifact A filed under artifact B left A free to send the same refused text again as soon as the user came back to it — and cleared B's own marker on A's next success.\n\nThe artifact a save was started for is captured when the request goes out, and both callbacks use it: the refusal names that artifact, and a success clears only that artifact's marker. Reported by Codex on 097f9bfadd. * 🖥️ fix: Do Not Reopen the Pane on a Monitor That Is Gone Remembered bounds are coordinates, and they outlive the monitor arrangement that produced them. Undocking takes the pane out of the page along with the only control that docks it, so a window reopened onto a display that no longer exists takes the artifact somewhere the user cannot reach.\n\nThe remembered rectangle is now used only when it can still be reached: it either overlaps this display's work area, or the browser says another display is attached, which is the case the feature exists for. A desktop reporting exactly one display is the only one where the rectangle is provably gone, and there the pane opens at the default bounds. A browser that does not report other displays keeps the user's placement. Reported by Devin review of a85d5c348e (BUG-0001). * 🪞 fix: Follow a Stylesheet the Host Switches, Not Only Rewrites The style mirror watched for nodes and text, so a sheet whose attributes changed — a \ switch, a \ flag, a \ that stops it being a stylesheet — left the popup showing styling the host had moved on from, with nothing to bring it back into line.\n\nThose attributes are part of the signature now, the observer watches them, and an update applies them to the clone alongside its content. Reported by Devin review of a853d48c90 (BUG-0002). * ♻️ fix: Rebase Every Resubmitted Edit on What the Last Save Wrote An edit replaces whatever the last save wrote, and the artifact registry only catches up when the edited message propagates. Three separate paths resubmit retained text — a queued edit, a buffer inherited at mount, and the edit restored when the user comes back to an artifact — and each had to learn that separately; the restore path had not, so it sent \ as the original, the endpoint refused it with a 400, and the text the user typed never landed.\n\nThe rebase now happens once, where the request is built: \ resolves the original from the save's own record unless a caller overrides it, so no path can forget — including the ordinary keystroke debounce, which had the same gap right after a save. Reported by Codex on a7c047cc2a, and the third finding in this family. * 🧪 test: Let the Shared-Link Dock Click Race Its Own Window Docking closes the window the click was made in, so the click can resolve against a page that has already gone — the same race the focus scenario already tolerates. The assertion that matters, the pane arriving back in the shared page, is unchanged. Seen once on desktop-dark while verifying a7c047cc2a. * 🪞 fix: Clone a Stylesheet in the State the Host Has It The attribute mirror kept a sheet current once the window was open, but the clone was built without those attributes — so a sheet the host had already switched off, or aimed at another medium, arrived in the popup switched on. Its signature matched from that moment, so the sync had nothing to correct.\n\nThe clone now carries the same attributes the sync keeps current. Reported by Devin review of c5d51b85fb (BUG-0002), and the same cause as its predecessor in that round. * 🧪 test: Match the Blocked-Popup Notice Where It Is Shown The notice is rendered in the toast and repeated in the live region, so the text matched two nodes and the assertion tripped strict mode on the slower mobile project. Either node proves the user was told; the assertion now takes the first. * 🗑️ fix: Never Let a Cleared Editor Save Itself as a Deletion Typing has always refused to save an empty editor: a user who selects all and deletes is mid-edit, not asking for the artifact's content to be removed. The paths that resubmit retained text did not know that, so a buffer holding an empty string was sent the moment the pane changed hosts or the user came back to the artifact — persisting a deletion nobody confirmed.\n\nThe rule now sits with the other decisions about whether a request goes out, in \, so the debounce, the queued edit, the inherited buffer and the restore all share it. Reported by Codex on a9a51439a5 (P1). * 🧹 fix: Retire the Inherited Buffer Once a Newer Edit Is in Play A host change hands the replacement editor the text its predecessor never sent, and the drain submits that once the save pipeline is idle. If the user kept typing in the replacement, the newer text queued behind the running save — and when it landed, the drain still had the older buffer in play and sent it, putting the artifact back the way it was.\n\nAnything an instance submits or queues now retires the buffer it inherited at mount, so the newest text is the last word. The drain passes the inherited text itself, which is how it stays exempt. Reported by Codex on 04a9f685b6 (P1). * 🎨 style: Satisfy the Tailwind v4 Class Order From Canary * 🧺 fix: Retain a Displaced Buffer Under the Artifact That Owns It Editing one artifact evicted another's unsaved text from the shared code buffer: the selection change had cancelled that edit's debounce, so the overwritten copy was the only place it lived and coming back to the artifact fell through to its persisted content. A buffer another artifact displaces is now retained under its owner, and the editor restores and sends it from there on the way back. Reported by Codex on 591ab13c96 (P1). * 🧪 test: Key the Tabs Spec's Mocked Buffer to Its Artifact The pane-wholeness change gated the preview on the buffer naming the artifact on screen, but the spec's useCodeState mock never set codeArtifactId, so the edited preview never applied. The mock now carries the owner the component reads, and the editor spec's mock grows the retained-buffer field the component destructures. * 🧪 test: Prove a Displaced Edit Returns With Its Artifact The displaced-buffer scenario gets its contract-level coverage: an edit the user leaves on one artifact, an edit that displaces it on another, and a return that has to land on the first artifact's own unsaved text. The fake model grows a reply carrying two artifacts so both trigger rows exist in one conversation, and its one nested ternary is unrolled so the file lints under the repo rules CI applies to staged files. * fix: Resolve Every Artifact Surface and Refusal Per Artifact Preview, download and the Mermaid host now read an artifact's retained buffer the same way the editor does, rejection markers are kept per artifact so one refusal no longer overwrites another, and the saved-content history is only preferred while the registry still sits on this session's chain of saves. * fix: Hold an Inherited Edit Until the Editor Can Save It A buffer inherited across a host change while a response was generating was marked drained before the read-only guard dropped the save, and the read-only transition then replaced it with persisted content. The drain now waits for editing to return and writes the inherited text back after that transition. * chore: Sort the Presentation Spec's Imports After the Canary Rebase * test: Prove Each Artifact Surface and Save Path End to End Covers the download of a displaced edit, a refusal per artifact, an edit after another session changed the artifact, and an edit carried through a response by a host change. * test: Give the Undocked Presentation Case the Canary Query Client * test: Start Artifact Scenarios From a Settled Reply on the Desktop Layout * test: Stub the Command Executor Stamp in the Callbacks Spec Mock Canary's #16556 calls stampCommandExecutor from callbacks.js, but this spec's @librechat/api mock predates it, so three cases failed on canary itself. The mock now carries the real helper, as it already does for isCodeArtifactToolOutput. * fix: Track What the Server Holds Per Artifact Instead of Inferring It The editor reconstructed the server's content from the mutation cache and treated every buffer as unsaved. A save now records what it wrote in a per-artifact ledger that the registry retires once it catches up, so a change made elsewhere (including a revert to an earlier value) wins over this tab's history, and text this tab already saved is never sent again by a host change or a return to the artifact. * fix: Hide the Undocked Pane While Its Conversation Route Is Pending The route keeps the previous conversation mounted but hidden while another one loads or fails to, and the undocked portal escaped that ancestry. The host now passes its pending state down and the window hides the pane with it. * fix: Mark the Saved Buffer Copy and Retire Lag the Registry Has Passed A buffer is saved only while it is the copy a save wrote, so editing away and back to the same text is still sent. Lag values the registry has already moved past are dropped in order, so a later change back to one of them is read as a change made elsewhere. * test: Drop the Callbacks Mock Stub Canary Now Carries * perf: Prune Settled Save Records When the Editing Session Ends |
||
|
|
e543f9b184
|
🧹 refactor: Keep Store Imports Out of the Chat Hooks (#16620)
The app's message parts host reads the stores, so it moves from hooks/Chat/parts to Providers/MessagePartsHostContext, beside ChatSettingsContext. The PTC trace types move to common, and PendingSteer joins the queue types in hooks/Chat/queue, so the chat contract names no store module. |
||
|
|
7e466a498d
|
🎛️ refactor: Hand Chat Preferences to the Host and the Follow-Up Queue to Jotai (#16604)
* refactor: Supply saveDrafts and isTemporary Through Chat Settings Both preferences are app-global: the settings dialog writes saveDrafts, and the chat route and keyboard shortcuts write isTemporary. Every chat reader (composer, autosave, pasted-text edit, new chat and new convo, file uploads, submissions, the temporary toggle, landing, run code) now takes them from the host ChatSettings context, which the app fills from its store. ChatView still reads saveDrafts from the store while #15911 owns it. * test: Cover Chat Settings Preferences End to End * fix: Read the Temporary Flag at Run Time in Run Code * test: Supply saveDrafts Through Chat Settings in the Hook Specs * test: Pin the Run Code Retention Flag With a Stable Code Ref * test: Turn Temporary Chat On Through Its Toggle in the Scenario * refactor: Move the Queue Run-End Atoms to Jotai The follow-up queue, its settled receipts and pending enqueue ids, the pane and parked run-end signals, and the interrupt-drain flag are written and read only by chat logic (queue drain, steering, the SSE hook, the queue rail). They now live in store/queue as Jotai atoms with every consumer converted. The run-end FIFO keeps its nullable one-shot API as a writable derived atom. * test: Cover the Chat-Owned Queue State End to End * test: Give Each Queue Rail Its Own Store in the Split-View Spec * test: Drop the Parked Run-End Scenario Canary Does Not Meet * refactor: Keep the Queue State Inside the Chat Feature The queue atoms and their types move from store/queue to hooks/Chat/queue, next to the drain that owns them. store/families re-exports the types so existing imports keep working. * refactor: Import the Queue Types From the Chat Feature * test: Scope the Split-View Queue Spec to What Its Harness Proves * test: Run the Split-View Queue Spec on One Shared Store |
||
|
|
d3d9bc9703 |
🖍️ feat: Give the Remaining Component Colour Literals Theme Roles (#16597)
* feat: Give the Last Component Colour Literals Theme Roles
The default avatar's hairline, the file drop zone's artwork and a dragged badge's lift were literals in Avatar, Icon, MessageIcon, DragDropOverlay and Badge, so no theme could reach them. avatar-edge, the illustration roles and the elevationDrag appearance role now carry them, each defaulting to the literal it replaces in every bundled theme. ClickHouse paints the artwork from Click UI's info ramp.
Canvas, favicon and screenshot code read roles through readThemeColor instead of wrapping channel triplets by hand. The Reasoning fade mask, two comments and dead commented-out SVG fills no longer carry colour literals, and the allowlist is regrouped into nine justified entries.
* test: Pin the Avatar Hairline, Drop Zone Artwork and Drag Lift Roles
* refactor: Export readThemeColor Beside the Theme Atoms
* test: Compare the Avatar Hairline by the Pixel It Paints
* test: Compare the Drag Lift as the Browser Computes It
* test: Attach Drop Zone Artwork Captures to the Report
* test: Pick the Drag Lift Theme From One Init Script
(cherry picked from commit
|
||
|
|
d016c5b586 |
🧩 refactor: Message Parts Host Context (#16591)
(cherry picked from commit
|
||
|
|
379554a8cf |
🚦 refactor: Route Chat Send, Stop, Steer and Queue Through the Transport (#16593)
* refactor: Start and Stream Agent Turns Through the Chat Transport
useResumableSSE now POSTs the turn with transport.start and attaches with
transport.stream({ token }).reconnectToStream, both read from ChatTransportContext.
The new transport spec renders the hook with a fake transport and covers the started
and rejected start.
* refactor: Stream Assistants Turns Through the Chat Transport
useSSE sends the turn with transport.stream({ token }).send from ChatTransportContext.
The transport spec covers the request it makes, closing on unmount, and a stream error.
* refactor: Stop Generations Through the Chat Transport
useAbortStreamMutation takes its mutation from transport.abort, and the Assistants
abort request moves from a fetch in useEventHandlers to transport.abortRun. The transport
spec stops an agents run and an Assistants run against a fake transport, including a
rejected stop.
* refactor: Steer Running Generations Through the Chat Transport
The steer, cancel-steer and arm-steer mutation hooks take their requests from
transport.steer, transport.cancelSteer and transport.armSteer. The transport spec
steers a running generation against a fake transport and checks that a refused steer
is kept as a queued turn.
* refactor: Queue Turns Through the Chat Transport
The queued-turn projection reads through transport.listQueued, and the enqueue and
cancel mutation hooks take transport.enqueue and transport.cancelQueued. The transport
spec reads, adds and withdraws a server queued turn against a fake transport, and keeps a
turn local when the server has no queue. The steer tests now answer the projection from
the fake transport instead of the request layer.
* test: Type the Transport Spec's Recoil Seeds
The seed callbacks take recoil's MutableSnapshot instead of a type read off RecoilRoot's
props union, which has no initializeState member on every branch. Drops the unused emit
helper.
* test: Cover Steer Cancel and Arm at the Transport Boundary
useSteerReclaim withdraws a waiting steer through transport.cancelSteer and
useSteerEscalate arms one through transport.armSteer, each against the fake transport.
(cherry picked from commit
|
||
|
|
b8cbc56f45 |
refactor: Let the Chat Contract Own Settings and Transport (#16592)
The host-supplied surface (app-global chat settings and the wire turns run over) is now
typed in hooks/Chat/contract.ts. ChatSettingsContext takes its types from there, and a new
ChatTransportContext carries a Transport whose default wraps the existing SSE transport and
generation request functions. The host route supplies both. Nothing reads the transport yet.
(cherry picked from commit
|
||
|
|
bbb58a867e |
⛴️ fix: Preserve Canary Sync Resolutions (#16457)
Retain the tracked-file integration outcomes recorded by original canary sync PR #16457. No new implementation is introduced. Shared and ambiguous corrections are carried by the final sync-resolution commit so the resulting tracked tree equals frozen canary |
||
|
|
9dc8db0ea8 |
🛶 fix: Preserve Canary Sync Resolutions (#16361)
Retain the tracked-file integration outcomes recorded by original canary sync PR #16361. No new implementation is introduced. Shared and ambiguous corrections are carried by the final sync-resolution commit so the resulting tracked tree equals frozen canary |
||
|
|
5b84c4b57f |
⏳ feat: Add Ephemeral Retention Mode for Forced Temporary Chats (#13811)
* feat: add ephemeral retention mode for forced temporary chats
Adds RetentionMode.EPHEMERAL, which forces every newly saved chat
temporary: hidden from history and search, given the temporary-chat
expiration, and with the toggle locked on.
Forces isTemporary and applies the temporary expiration in the normal
conversation and message save methods, routes Assistants/Threads
messages through the normal message save, applies the all-data
retention policy to file uploads and shared links, and stamps imports,
forks, and duplicates. Locks the frontend toggle and keyboard shortcut
behind an administrator-enforced badge.
The default temporary mode and the existing all mode are unchanged.
* fix: enforce ephemeral retention when resuming paused chats
* fix: preserve forced retention across pauses and assistant turns
* test: Use Real Module IDs for Installed Package Mocks
* test: Wait for Resumed Retention Persistence
* test: Control Mongo Index Setup in OpenID Fixture
* test: Close Mobile Drawer Before Retention Resume Scenario
* fix: Store Responses API Messages Under the Retention Write Context
Input and output messages were saved with the raw request, so under
ephemeral retention they missed the forced-temporary classification the
conversation received. Route both through getConversationWriteContext
and announce the stored reply as saved.
* fix: Align Resumed Responses With the Parent Retention Deadline
A resumed response was saved with a fresh forced-temporary window while
the re-stamp kept the conversation's earlier deadline, so a chat that
paused again could leave its response stored after the conversation
expired. Stamp the saved response with the parent's deadline.
* fix: Clear Released Bookmark Tags When Forcing a Chat Temporary
stampForcedRetention released a converted chat's bookmark counts but
kept its tags, so deleting that chat before TTL removal decremented the
same tags again and reduced counts owned by other visible chats. Clear
the tags in the conditional conversion update that releases them.
* fix: Store No Bookmark Tags on Forced-Temporary Imports
An ephemeral import, fork or duplicate skipped its tag count increment
but kept the source tags, so deleting the copy before TTL removal
decremented counts owned by other visible chats. Store the same tags the
import counts, which is none for a forced-temporary copy.
* test: Provide the Forced-Temporary Retention Helper to the Header Stacking Mock
* test: Reuse One Admin Login per Worker in Ephemeral Retention Scenarios
* fix: Keep Legacy Temporary Chats Temporary When Forking Under All-Data Retention
* fix: Convert a Resumed Chat Under Ephemeral Retention Before It Can Re-Pause Empty
* fix: Treat a Reloaded Pre-Policy Run as Temporary Once Retention Is Forced
* fix: Stamp Messages with the Deadline a Concurrent Retention Stamp Stored
* fix: Wait for the Startup Config Before Rebuilding a Resumed Submission
* test: Wait for the Resumed Response Row in the Ephemeral Resume Scenario
* test: Provide the Real Command Executor Stamp to the Callbacks Mock
(cherry picked from commit
|
||
|
|
ea938f6054 |
🚦 feat: Show Exit Status and Stderr for Attached Workspace Commands (#16556)
* feat: Show Exit Status for Attached Workspace Commands
Parse the exit trailer the attached-workspace bash_tool writes so the card
fails a non-zero exit, a signal or a timeout, names the reason beside the
failure suffix, and renders stderr distinctly. The group outcome reads the
same parser so its failed count matches the card. Sandbox output without the
trailer keeps the existing heuristics.
* fix: Parse Exit Status Only for Attached Workspace Calls
The sandbox and attached-workspace tools are both named bash_tool, and the
sandbox output is trimmed, so a sandbox command that printed
"[exit code: 1]" last was read as a failed attached-workspace run by the
card and the group outcome.
The execute handler now records a run step when the resolved tool instance
is the one createAttachedWorkspaceBashTool built (tracked by object
identity), and the step-completed handler stamps executor:
'attached_workspace' on the streamed tool call and the aggregated part.
Redis replay and the client SSE merge carry the field through. BashCall
and outcome.ts parse the trailer only when the marker is set.
* fix: Count Styled Terminal Lines Like Plain Ones When Output Ends in a Newline
(cherry picked from commit
|
||
|
|
206ef476f6 |
⛴️ fix: Align Canary Timing Types and CI Formatting
(cherry picked from commit
|
||
|
|
3f7336cbcd |
🎛️ refactor: Supply App-Global Chat Settings From the Host (#16466)
* refactor: Supply App-Global Chat Settings From the Host
The chat hooks read the during-run default, steer interrupts, save drafts,
temporary chat and the artifacts reset from a ChatSettings context that Root
fills from the existing Recoil atoms. liveAppliedSteerIds moves to Jotai with
its reader and writer, and manual compaction submits through the useChat
facade.
* fix: Keep Compaction Off the Message Frame and Read One Interrupt Default
Compaction reads status through useChatActions, which re-renders only when
the status changes instead of mapping every stream frame. The during-run send
button reads the interrupt default from the steering controls instead of a
second store read.
* fix: Supply Only Preferences Every Chat Reader Can Take From the Host
saveDrafts and isTemporary are also read by useNewConvo, useAutoSave and the
upload path, and by ChatView, ChatForm and the resume hook, so a host value
for them would split one preference across two sources. They stay on the
store until all of their readers can move together.
(cherry picked from commit
|
||
|
|
ca8fb372e7 |
🔌 fix: Reattach a Resume Stream Whose Body Ends Before Final (#16438)
(cherry picked from commit
|
||
|
|
c92ea0a470 |
🧭 feat: Palette Show All Catalogs, MCP Status and Composer Polish (#16422)
(cherry picked from commit
|