mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-18 05:52:10 +00:00
234 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
5b8bb3c31f
|
⏱️ fix: Bound Remaining Outbound Calls With Timeout Budgets (#17468)
* fix: Bound outbound HTTP calls that had no timeout Add timeouts.toolsMs, speechMs and imageGenerationMs to the timeouts block and apply the existing budgets to the RAG delete paths, built-in tool APIs, TTS/STT providers (TTS also aborts when the client closes), Stable Diffusion, Firebase reads and Mailgun. Calls made before app config exists (remote config, RAG health, service key URL, Google refresh) get a fixed 10 second budget. * fix: Honor configured budgets for RAG deletes and per-chunk TTS deadlines * refactor: Share one budget helper between speech and image CJS callers * test: Cover a stalled RAG delete with a mock scenario * test: Wait for the RAG embed before stalling the delete * test: Embed at upload so the stalled delete has a vector to remove * fix: Close a started TTS response on a late chunk timeout and share the service budget helper * fix: Fail startup when the remote config fetch times out |
||
|
|
74e7252c3e
|
📊 feat: Let Deployments Skip the Analytics Consent Prompt (#17552)
Some checks are pending
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Vote Gate / Gate (push) Waiting to run
Codegraph E2E Votes / vote (shard 1/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 10/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 2/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 3/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 4/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 5/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 6/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 7/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 8/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 9/10) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
* feat: Let Deployments Skip the Analytics Consent Prompt * test: Cover the consent-free analytics setting |
||
|
|
7e7f559ea6
|
🏎️ perf: Parallelize Independent Agent and Schedule Lookups (#17465)
* perf: Parallelize Serial Lookups on Agent Load, Discovery, Skills, and Schedules * fix: Address Review Findings on Parallel Lookups Stage same-level discovery results before collecting edges so a shared sibling is initialized once, bound resume snapshot fetches to small chunks so over-budget graphs stop early, and surface the first ordered image failure without waiting on later reads. Update the skill name test for bounded concurrency. * test: Tag Existing Mock Specs as Acceptance Scenarios for Parallel Lookups * feat: Make Parallel Lookup Bounds Configurable Add a concurrency section to librechat.yaml for MCP catalog, skill name, skill file and resume agent lookups. Defaults equal the previous hard-coded values. * style: Sort Imports for Configurable Lookup Bounds * test: Match Model Spec Skill Resolution Args With App Config * test: Close the Builder Drawer Before Chatting on Narrow Viewports * fix: Surface Fatal Discovery Errors Without Awaiting Later Siblings * fix: Reject Discovery on the First Fatal Load Regardless of Queue Order * fix: Keep Image Encoding Fail-Fast With Parallel Reads * fix: Reject Resume Snapshot Lookups Without Waiting on the Whole Chunk * feat: Make Connected Agent Discovery Concurrency Configurable |
||
|
|
c81e244afd
|
🗂️ perf: Index Hot Lookups and Fix the Message Cursor (#17464)
Some checks are pending
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Vote Gate / Gate (push) Waiting to run
Codegraph E2E Votes / vote (shard 1/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 10/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 2/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 3/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 4/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 5/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 6/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 7/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 8/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 9/10) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
* perf: Index Hot Lookups and Make Message Cursor Pagination Stable Add narrow indexes for session refresh-token deletes, user-only tool call deletes, queued-turn delivery and reconciliation claims, agent code environment references, and updatedAt message pages. Add a TTL index to the KeyvMongo collection. getMessagesByCursor now sorts and pages on a unique (sortField, _id) tiebreaker with a millisecond-precise cursor while still accepting legacy cursors, and GET /api/messages caps pageSize in a TypeScript helper. * fix: Keep the Message Id for the Cursor Under the Client Projection * fix: Declare select on the Message Cursor Method Type * feat: Make the Message Page Size Ceiling Configurable * fix: Clamp the Default Message Page Size to the Configured Ceiling * test: Cover Message Cursor Paging and Page Size Cap End to End * fix: Continue Message Cursors Whose Sort Value Is Empty * fix: Include Missing Sort Values When Paging Messages Descending * perf: Resolve the Message Page Ceiling Beside the Ownership Read * fix: Observe the Ownership Read While the Page Size Resolves * style: Sort Imports in the Message Page Module * refactor: Move Page Size Read Observation Into the API Package * fix: Keep Missing and Empty Sort Values Distinct in the Message Cursor * fix: Page Past Messages With a Missing Timestamp |
||
|
|
7d0e79786f
|
🪶 fix: Time Out Client Refresh and Trim Lodash Imports (#17467)
* perf: Bound client hygiene paths (lodash imports, timeouts, listener cleanup, upload concurrency) * feat: Make client request timeouts configurable * test: Cover the configured refresh deadline end to end * feat: Rename client timeouts to client limits and expose upload concurrency * fix: Keep the published refresh deadline for the next page load |
||
|
|
784582850a
|
🧯 fix: Guard SSE Writes and Interval Cleanups Against Crashes (#17462)
* fix: Harden Timer Sweeps, SSE Writes, and Violation Counters Guard SSE writes against ended or destroyed responses through one helper, catch and single-flight the job store and TTL cache cleanup timers, serialize in-process counter updates, cap the violation log, prune stale OAuth failure records, batch the active-job lookup, and count Redis keys with DBSIZE. * refactor: Drop the redundant violation log entry copy * refactor: Log single-flight sweep failures from the API package * test: Cover active generation listing and client disconnect mid-stream * refactor: Configure violation log retention and move title timeout into the API package * feat: Configure OAuth failure retention through mcpSettings * fix: Prune OAuth failures promptly under short retention |
||
|
|
f05f50460a
|
🔭 feat: Admin Config Read APIs (Resolved and Effective Config, Scope Catalog, Env Status) (#17383)
* 🔭 feat: Admin Config Read APIs (Resolved and Effective Config, Scope Catalog, Env Status) Admin clients could read one config document at a time, or the deployment's merged config, but nothing showed what a profile or a user resolves to: a client had to re-implement the merge (Base-first precedence, merge keys, tombstones, the interface permission filter, base-only fields, runtime stops, secret rebinding, the env allowlist) to preview it, and had no way to see why part of a profile is ignored. Endpoint, model and tool pickers came from the end-user routes, called as the signed-in admin, so they showed the admin's own scope and keys and needed a browser User-Agent. The admin config API now has four read routes. GET /resolved/:principalType/:principalId and GET /effective?userId= return librechat.yaml, the documents that merge over it in merge order, each with the parts the merge does not apply and why, and the result, in librechat.yaml shape. They come from resolveConfigLayers, which tracks the same fold the served merge runs and is pinned to it by parity tests, and from the stored documents rather than the override cache. GET /catalog lists the endpoints (with the reason one is not served), models (served, configured and defaults), MCP servers and tools a scope serves, resolved for the scope rather than the caller and never with a user's stored key; GET /env-status reports whether each env name the config uses is set, never its value. Every read is filtered to the sections the caller can read, redacted as reads redact, and scoped to the caller's tenant. The admin Langfuse routes now say why a deployment offers no connection settings. Meta reports resolvedApi, catalogApi, envStatus and limits.catalogModelsTtlMs. * 🪞 fix: Report Duplicate Custom Endpoints from the Served Definition When librechat.yaml defines a custom endpoint name twice, or both `Ollama` and `ollama`, the catalog kept the first definition for a name's env names, reason and models, while `loadCustomEndpointsConfig` serves the last servable one. An entry could pair the served config of one definition with the env names of another. `resolveServedCustomEndpoints` now holds the runtime rule (the last definition with a name, key, base URL and models wins under its served name), and `loadCustomEndpointsConfig`, `loadConfigModels` and the catalog all use it. A name with no servable definition is reported from its last one. * ⏱️ feat: Make the Admin Catalog Model-List Lifetime Configurable `GET /api/admin/config/catalog` reused a scope's model lists for a fixed two minutes. The new librechat.yaml field `endpoints.catalogModelsTtlMs` sets that lifetime (milliseconds, `0` to one hour, two minutes by default); `0` resolves the lists on every read. It is a base-only path, so a profile cannot change it and `GET /meta` reports one value, now read from the deployment's config on each request as `limits.catalogModelsTtlMs`. |
||
|
|
6189220697
|
🏷️ fix: Resolve endpoints.all Title Settings per Field and Fold Ollama Endpoint Names (#17316)
Some checks failed
Codegraph E2E Votes / vote (shard 10/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 2/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 3/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 4/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 5/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 6/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 7/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 8/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 9/10) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Publish `@librechat/client` to NPM / pack (push) Waiting to run
Publish `@librechat/client` to NPM / publish-npm (push) Blocked by required conditions
Docker Dev Images Build / publish (push) Waiting to run
Sync Helm Chart Tags / Ignore non-main push (push) Waiting to run
Sync Helm Chart Tags / Sync chart tags (push) Waiting to run
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Has been cancelled
Publish `librechat-data-provider` to NPM / pack (push) Has been cancelled
Publish `@librechat/data-schemas` to NPM / pack (push) Has been cancelled
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Has been cancelled
Publish `librechat-data-provider` to NPM / publish-npm (push) Has been cancelled
Publish `@librechat/data-schemas` to NPM / publish-npm (push) Has been cancelled
* 🏷️ fix: Resolve endpoints.all Title Settings per Field and Fold Ollama Endpoint Names Conversation titles picked `endpoints.all` as a whole block, so any `all` block (even one holding only streamRate, headers or activity label keys) hid every per-endpoint titleConvo, titleModel, titleMethod, titleEndpoint and title prompt. `resolveTitleConfig` resolves each field from `all`, then the named endpoint, then the custom endpoint entry, keeping titleEndpoint and titleModel as one choice from the first layer that sets either. Config overrides merged `endpoints.custom` by exact name while the runtime serves names through `normalizeEndpointName`, so an override `ollama` survived beside the YAML `Ollama` and split the endpoint between two baseURLs and keys. The merge key now folds the same way (the YAML spelling is kept), merge-key issues, issue attribution and secret preservation use the same identity, and the effective config serves `modelSpecs.addedEndpoints`, `modelSpecs.list[].preset.endpoint` and `endpoints.agents.allowedProviders` in served names without repeats. A stored document that already names one endpoint in two spellings is combined at merge in document order, so requests keep the host and key of the first item instead of moving to the YAML entry; omit-to-keep secret preservation reads the same combined entry. A new write naming both spellings is rejected as a duplicate. An agent saved as `Ollama` now runs on the served `ollama`: the model catalog lookup (`resolveModelCatalogKey`) falls back to the served name, and `initializeAgent` folds the provider before the allowedProviders check and provider setup. * 🏷️ fix: Report Per-Field endpoints.all Title Resolution in the Admin Config Meta resolveTitleConfig resolves endpoints.all title settings one field at a time, so GET /api/admin/config/meta now reports rules.titleResolution as 'field'. meta.spec ties the reported value to resolveTitleConfig: with endpoints.all = { streamRate: 1 } and openAI.titleModel = 'x', the rule is 'field' exactly when the endpoint's titleModel survives. * 🧪 test: Expect Segments on the Folded duplicate_merge_key Write Issue Admin config write issues carry segments since #17322; the folded Ollama/ollama duplicate test now asserts them. * 🏷️ fix: Match Folded Custom Endpoint Names in Admin Config Change Ops The changes endpoint from dev matched entry keys exactly, while the config merge, merge-key issues and secret preservation fold `Ollama`/`ollama` into one custom endpoint. An upsertEntry `ollama` over a stored `Ollama` copied the stored key, appended a second entry and failed as duplicate_merge_key; removeEntry `ollama` left a stored `Ollama` in place; a rename onto another spelling passed entry_exists; and the librechat.yaml entry check missed `ollama` against the YAML `Ollama`. - data-schemas: `getConfigEntryIdentity` folds a key by its override path; `getConfigEntryMatcher` backs upsertEntry, removeEntry, rename, written-path attribution and the stored-counterpart lookup; issue locations use the same identity. A rename of an entry stored in two spellings moves the one entry the runtime merge combines (`combineFoldedConfigEntries`). - api: the YAML-entry rename guard and the per-batch duplicate check compare entries by the same identity. - Tests: unit coverage for each op across spellings, and handler integration tests against MongoDB for upsert with secret preservation (single and two-spelling documents), removal, entry_exists, inherited_entry and duplicate changes in one batch. |
||
|
|
9ea3c5647d
|
🔑 fix: Use Admin-Stored Web Search Credentials at Runtime (#17323)
* 🔑 fix: Use Admin-Stored Web Search Credentials at Runtime Use admin-stored (encrypted or literal) web search credentials as system credentials at runtime, add the Keenable key to the secret registry, bind a stored key to the layer that set its URL, and require re-entering the key when a write changes or removes that URL (checked atomically with a version precondition). * 🧹 fix: Keep Dotted-Key Write Guarantees on Version-Checked Web Search Writes A version-checked write the caller saw absent first creates an empty document. When the database then refuses the write (a key name it cannot store, answered 422 CONFIG_KEY_NOT_STORABLE), remove that document again so a refused write stores nothing, unless another write has changed it. Secret re-entry issues now carry `segments` like every other config issue. * 🚩 feat: Publish the webSearchStoredKeys Feature Flag in the Config Contract GET /api/admin/config/meta now reports `webSearchStoredKeys: true`, so an admin client can stop warning that only ${VAR} web search references work at runtime. meta.spec probes the behaviour behind it: an encrypted stored key reaches web search auth, the Keenable key is encrypted on write, and changing a URL beside a stored key requires entering the key again. * 🧪 test: Type the Refused-Write Driver Stub in the Config Methods Spec * 🧪 test: Expect the Write Precondition Arguments in the Admin Config Route Test The handler passes a session slot and an optional version precondition to patchConfigFields since the web search re-entry check; the route test added in #17322 asserted the earlier five-argument call. * 🧹 fix: Surface a Failed Cleanup of the Empty Config Document When a version-checked write the database refused cannot remove the empty document created for it, let that failure reach the handler (500) instead of logging it and answering 422 CONFIG_KEY_NOT_STORABLE, which promises that nothing was stored. * 📝 docs: State the Web Search Stored-Key Binding Rule Exactly in the webSearchStoredKeys Flag The flag's doc said a stored key goes only to a URL the same layer set. The merge rule keeps a stored key over an inherited ${VAR} or default URL, so the doc now names the exact rule: a stored key reaches a URL stored in config only when one layer set both, a later layer that changes, blanks or removes the URL drops the key, and a write that changes or removes the URL must enter the key again. * 🧹 refactor: Read the Secret Registry Through getConfigSecretRules Only The dev merge kept this branch's getConfigSecretFields and getConfigArraySecretFields beside dev's getConfigSecretRules, which returns the same registry data. Only the secret specs used the two extra accessors. They now read getConfigSecretRules().secretFields and .arraySecretFields, so the accessors and their exported ConfigSecretField and ArraySecretField interfaces (duplicates of AdminConfigSecretFieldRule and AdminConfigArraySecretFieldRule) are gone. |
||
|
|
df3adb837a
|
🐣 chore: Prepare v0.8.9-rc1 Release (#17336)
Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
b2aeb9c6a1
|
feat: add masked session replay lifecycle (#17194) | ||
|
|
8718338728
|
⏱️ fix: Bound Outbound Calls Made Inside a Request (#17263)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
* fix: Bound Outbound Calls Made Inside a Request RAG queries for file search and message context, OCR provider calls, action HTTP calls, the moderation check, the stored-image fetch for base64 providers, and Flux result polling had no timeout. A stalled upstream hung the chat turn, the upload or the tool call indefinitely, and Flux kept polling forever on statuses that never become Ready. Each now runs under a budget from a new librechat.yaml timeouts block with finite defaults (getOutboundTimeoutMs in @librechat/api). Action calls also receive the run's abort signal, so stopping a run closes the socket. * test: Cover a Stalled RAG Query in the Mock Harness * fix: Share One Flux Budget Across Submit and Polls, Bound the Vertex Token Exchange * refactor: Poll Flux Results Through pollUntilSettled * refactor: Leave Flux Polling for a Separate Migration * fix: Cap Configured Timeouts at the Node Timer Limit * fix: Bound the Action Token Refresh and the Whole Image Download * fix: Cap Every Outbound Budget by Wall-Clock Time Axios's timeout only fires on an idle socket, so a RAG, OCR, moderation, action or token response that keeps trickling bytes never ended. outboundRequestBudget pairs each timeout with an AbortSignal deadline, and action calls combine it with the run's own signal. * fix: Name the Budget That Ran Out and Give Actions Five Minutes The actions default rises to five minutes, since action endpoints are arbitrary third-party APIs and the old minute could cut off legitimately slow ones after an upgrade. A budget overrun now fails with an error naming the timeouts key and its value, whether it was the idle timeout or the wall-clock deadline, and logAxiosError logs it as a warning so operators know what to raise. A deadline cancellation is no longer read as a user stop, so an action that runs out of time reports a timeout instead of looking like a stopped run. * fix: Hold Outbound Deadlines Weakly So Finished Requests Leave No Timers * fix: Check the Budget Before Reading an Error Message * fix: Report a Wrapped Deadline as a Failure, Not a Stop * fix: Bound the OAuth Code Exchange and Keep the OCR Budget Hint When Protected * chore: Sort Imports in axios.ts After Rebase |
||
|
|
f7b053789e
|
🔐 feat: Defer MCP OAuth Sign-In Until a Deferred Tool Is Used (#17225)
* feat: Defer MCP OAuth Sign-In Until a Deferred Tool Is Used Adds an oauthPrompt server option (on_start by default, or on_use) and an operator-declared oauthToolCatalog. With on_use, an operator-configured OAuth server whose selected agent tools are all deferred no longer prompts at turn start: tool search offers the declared catalog (or the user's own cached catalog), and sign-in happens on the first tool call through the existing in-run OAuth step. Without a declared catalog the turn-start prompt is kept. Both fields are operator-only. Related to #16765 * test: Cover MCP OAuth Sign-In on First Deferred Tool Use * fix: Bound the Declared OAuth Tool Schema to Non-Recursive Types * refactor: Move MCP OAuth Deferral Orchestration Into packages/api * refactor: Move the Cached-Catalog OAuth Prompt Branch Into packages/api * fix: Defer MCP OAuth Only When the Offered Catalog Covers the Selection * fix: Cover Runtime OAuth, Background Tools, and Tokenless Discovery in Deferral * fix: Match Legacy Keys, Honor Background Capability, and Reject Unsupported Schema Keywords * fix: Resolve Wildcard Background Opt-In and Tighten Declared Catalog Matching * fix: Validate Declared Tool Schema Types and Enums * fix: Accept Canonical Catalog Keys the Definitions Loader Accepts * test: Pin the Declared Catalog Requirement for Cached User Catalogs * fix: Resolve Deferred Tool Options Across MCP Spelling Aliases |
||
|
|
698ee25fea
|
🧯 fix: Close Abandoned Download and Speech Streams and Cap Speech Input (#17270)
* fix: Contain Download and Speech Stream Failures and Cap Speech Input The code output download piped the Code API stream with .pipe, which adds no error listener, so a body that failed mid-stream (a bad gzip body, a reset) became an uncaught exception and the process exited. pipeToResponse uses stream.pipeline, ending the response and destroying the upstream when the client leaves. Text-to-speech piped provider streams the same way and waited only for 'end', so a provider error was uncaught and a client disconnect left the chunk loop waiting. pipeSegment resolves on end and rejects on an error or a disconnect, which ends the loop. A speech request had no length cap, so one request could fan out into thousands of serial paid provider calls. speech.tts.maxInputChars bounds it (default 20,000 characters). * docs: Document the Speech Input Cap in the Example Config * fix: Reject a Speech Segment When the Client Already Left * fix: Tear Down Both Ends of a Failed Speech Segment and Cap Streamed Speech A failed provider segment now destroys the response as well as the source, so a half-written answer cannot hang the client, and a response-side error rejects the segment instead of going unhandled. Automatic playback reads a message only up to speech.tts.maxInputChars, so long messages cannot fan out past the cap either. The download scenario now checks the behavior .pipe lacked: leaving a code download closes the upstream connection right away. * fix: Keep a Late Response Write Error From Going Unhandled * test: Key Slow Code Downloads by File and Send a Browser User Agent * fix: Read Speech Up to the Cap Instead of Refusing It Manual speech now synthesizes the text up to speech.tts.maxInputChars, the same as automatic playback, through capSpeechInput, so the CJS service only passes the capped text along and the request keeps its existing error contract. A streamed message that reaches the cap exactly now finishes, and a segment that fails before any audio went out leaves the response open for the caller's HTTP error. * fix: Count Only Text Against the Speech Cap |
||
|
|
4c6ea7e981
|
🔐 fix: Hash Passwords on a Worker Pool and Surface API Key Lookup Failures (#17261)
* fix: Hash Off the Event Loop and Surface API Key Lookup Failures Registration, email verification, password reset and verification resends hashed and compared with bcryptjs's synchronous calls. bcryptjs is pure JavaScript, so each call blocked the event loop for every request in the process. They now use the promise APIs, and the password reset dependencies are async. validateAgentApiKey caught its own query failures and returned null, so a database outage answered remote callers with 401 Invalid API key. It now lets the failure reach requireApiKeyAuth, which answers with a 500. * fix: Run bcrypt on a Worker Pool in packages/api bcryptjs's promise API still computes on the main thread, only in chunks of up to 100 ms, so concurrent registrations and resets kept stalling unrelated requests (four cost-10 hashes delayed a 5 ms timer by about 190 ms). hashSecret and compareSecret now run bcryptjs on a small worker_threads pool in packages/api, and AuthService.js calls them. * feat: Configure the Password Hashing Worker Count * fix: Verify Login and Step-Up Passwords on the Hash Pool |
||
|
|
ab8dc9d3d2
|
🕶️ fix: Keep Temporary Chats Out of Langfuse (#17202)
* fix: Keep Temporary Chats Out of Langfuse * fix: Gate Forced-Ephemeral and Open Responses Turns From Langfuse * fix: Treat Legacy and Chat Completion Temporary Turns as Untraced --------- Co-authored-by: Joel Hirzel <joel.hirzel@eps.ch> |
||
|
|
76192bdfd0
|
🛂 feat: Audit Resource Sharing Changes and Fail Closed on Reversible Audit Writes (#17053)
* feat: Audit Resource ACL Changes and Fail Closed by Default * fix: Keep Non-Reversible Admin Audit Handlers Fail-Open * docs: Narrow AUDIT_LOG_FAIL_CLOSED Description * fix: Audit and Restore ACL and Insights Changes in One Pass * fix: Break Audit and Insights Permission Type Cycle * test: Cover Resource ACL Audit Scenarios * refactor: Audit Resource Permission Changes Before Writing * test: Align Concurrent Revoke Audit Expectation * fix: Skip Deleting ACL Entries That Were Not Audited * fix: Read ACL Snapshots Through the Write Session * fix: Never Block Revocations on Audit Outages and Normalize Principal Keys * fix: Let an Explicit Public Disable Win Over a Public Update * fix: Audit Duplicate ACL Rows as Combined Permissions * fix: Audit Permission Changes Under One Target and Dedupe Revokes * fix: Audit Capability Grants Before Writing Them * feat: Serialize Resource Permission Updates With a Per-Resource Lease * fix: Fence the Resource Lease Before Writes and Always Audit Grant Assignments * fix: Renew the Resource Lease Before Each ACL Write Phase * fix: Serialize System Grant Assignment and Revocation With a Per-Grant Lease * fix: Keep Leases Alive During Audits, Bound Lock Index Wait, Canonicalize Audit Target IDs * fix: Retry Deferred Revoke Audits Under the Lease and Audit Canonical Principal and Role IDs * test: Expect Role IDs in Permission Audit Metadata * fix: Read Mutation Snapshots From the Primary Outside Transactions * fix: Flush Deferred Audits Before Cache Invalidation, Keep Renewals Monotonic, Keep Role Case in Grant Lease Keys * refactor: Map the Busy Permission Error to Its Code in the API Package * style: Sort Lease Imports and Type the Renewal Spec Read * fix: Keep Success Audits After Commit, Report Downgrades as Revocations, Code Audit Outages * refactor: Move the Audit Outage Code to Its Own Module * fix: Translate Lock Failures, Lease Non-Transactional Sessions, and Code Grant Audit Outages * fix: Sanitize Lease Renewal Failures at the Permission Boundary * fix: Annotate the Unavailable Error Code for Isolated Declarations * fix: Keep the Admin Route Fail-Closed Opt-In and Document Lease Clock Skew Safety * fix: Translate Grant Lease Store Failures to a Retryable 503 * fix: Log Failed Grant Audit Writes With Safe Metadata Only * test: Detect Raw Error Arguments in the Grant Audit Log Spec * feat: Make Permission Lease Limits Configurable and Localize Retryable Sharing Failures * fix: Bound Lock Index Readiness by the Lease Wait and Carry the Resource ID in Every Audit Entry * test: Cover Lease Config Reaching the Leases and the Sharing Dialog Failure Messages * fix: Load App Config on the Sharing and Grant Routes and Log Failed Lease Releases * perf: Load App Config Only on the Grant Mutation Routes |
||
|
|
5cb396e85c
|
👋 feat: Optional Greeting Heading and Footer-Free Welcome Screen (#17055) | ||
|
|
a06ee14b75
|
🔐 fix: Encrypt User Plugin Credentials With Random-IV v3 Format (#16996)
* fix: Encrypt User Plugin Credentials With Random-IV v3 Format * test: Cover Credential Encryption Formats in Mock E2E Scenarios * test: Round-Trip Real Credential Helpers in PluginService Spec * 🙈 fix: Remove SharePoint Picker Payload Logging (#16997) * fix: Add credentials.writeFormat to Gate v3 Credential Writes During Rollouts * test: Expect 201 When the Legacy Write Format Override Is Created * 🔊 fix: Clear TTS Audio Cache On Session End and Hash Its Keys (#16998) * fix: Clear TTS Audio Cache On Session End and Hash Its Keys * fix: Read Manual TTS Replays From the Hashed Cache Key * fix: Purge Legacy TTS Cache Keys and Fence Writes Across Logout * fix: Keep TTS Cache Writes Off the Playback Path * test: Expect Hashed Keys in the StreamAudio Cache Lookup * test: Use a Single-Token Reply Label in the TTS Cache Scenario * fix: Settle TTS Cache Clear Before IdP Logout and Across Tabs * test: Cover the TTS Cache Fence When Another Tab Logs Out * test: Wait for the Second Tab Before Logging Out in the TTS Scenario * fix: Latch TTS Cache Writes Shut Until the Tab Authenticates Again * fix: Reopen TTS Cache Writes When Authentication Completes In Place * fix: Leave for the IdP Even When TTS Cache Cleanup Fails * fix: Retry a Failed Legacy TTS Purge and Fence Other Tabs on Manual Clear * fix: Rerun the Legacy TTS Purge After Each Clear and Sign-In * fix: Rerun the Legacy TTS Purge When Another Tab Clears * fix: Fence Pre-Auth TTS Writes, Retry Failed Clears, and Fall Back to Storage Events * fix: Version the Hashed TTS Cache Key Path * fix: Move TTS Audio to a New Cache and Keep It Closed Until a Failed Clear Succeeds * fix: Persist a Pending TTS Cache Delete Across Navigation * fix: Reopen TTS Caching Only on Session Start and Fence Cache Reads * fix: Keep the TTS Delete Fence in Cache Storage and Close Reads After Logout * refactor: Keep Read-Aloud Audio in Tab Memory Instead of Cache Storage * test: Return to the Conversation After Re-Login in the TTS Logout Scenario * test: Close the Phone Sidebar Before Replaying in the TTS Logout Scenario * fix: Bound the In-Memory TTS Cache by Size as Well as Count * fix: Scope Cached TTS Audio to the Signed-In User * fix: Keep the Settings Cache Delete Available While Legacy Audio Remains * fix: Recheck Legacy TTS Audio After a Settings Clear and on Unowned Handoff * fix: Fence TTS Writes Started Before an Account Signs In * test: Opt the Fresh TTS Account Into Enter-to-Send |
||
|
|
0bc344fcb9
|
🔑 feat: Let Users Connect Their Own Account for Pull Request Lookups (#16989)
* feat: Let Users Connect Their Own Account for Pull Request Lookups * fix: Refuse Cross-Tenant Pull Request Callbacks and Surface Key Failures * fix: Keep Pull Request Grants Through Outages and Remove Them on Disconnect A token endpoint server error is an outage even with an OAuth error body, so it no longer deletes the grant, and a refresh outage reaches the lookup as unavailable instead of falling back to no token. Disconnect removes every pr_oauth row of the user, whatever app or host is configured now. A grant that never expires extends its retention when used, and the flow, request and retention limits are configurable. The connection routes are built in packages/api, mounted behind the pre-auth tenant middleware in both servers, and answer failures with stable codes. * fix: Keep the Pull Request OAuth App Out of Overrides A role, group, user or tenant override can no longer change or remove pullRequests.oauth, so the connect capability and the callback see the operator's app. * fix: Read a User's Pull Request Token Only With the Feature On * fix: Report a Malformed Stored Pull Request Grant as a Failure * fix: Remove a User's Stored Tokens When an Administrator Deletes the User * fix: Answer No Pull Request for a Conversation Without a Lane When the User Token Fails * fix: Share One Grant Read Between Concurrent Callers and Report an Expired Grant Disconnected * fix: Remove a Pull Request Grant Only on a Definite Refusal and Past Its Retention * fix: Version Pull Request Grants and Coordinate Refresh, Refusal and Retention Through Them * fix: Invalidate a Refused User Token and Read It Only for a Lane That Needs It * fix: Finish a Pull Request Connection Under the User's Effective Config Behind the Login Limiter * fix: Type the Pull Request User Token for Isolated Declarations and Settle Retention Before Answering * fix: Bind a Pull Request Connection Flow to the Generation a Disconnect Replaces * fix: Start a Batch's User Token Read Only Within Its Deadline * fix: Fence Pull Request Token Reads Against a Disconnect and Report a Failed Retention Cleanup * fix: Fence Connection Status Like Token Reads and Keep a Newer Read Joinable * fix: Report a Pull Request Grant Without Its App and Name the Sign-In That Made It * fix: Read a User's Unexpired Pull Request Grants Newest First * fix: Mark the Connection Callback as an OAuth Navigation and Report a Failed Extension * fix: Name the Pull Request Sign-In Flow on Its Landing Page * fix: Remove a Pull Request Grant of a Replaced App When It Is Read * fix: Keep a Replaced App's Grant Untouched and Extend Retention From Each Day's Use * fix: Accept a Pull Request Grant Only Under the User's Current Connection Generation * fix: Renew the Connection Generation With a Grant Still in Use * fix: Restore the Previous Connection When a Sign-In Cannot Store Its Grant * fix: Decide a Sign-In by What Was Stored When a Write Does Not Answer * fix: Roll Back a Sign-In's Generation Along With a Grant It Must Remove * fix: Refresh an Access Token a Lookup Was Refused With Before Ending the Connection * fix: Undo a Sign-In Only for a Confirmed Fence, Not a Failed Check * fix: Read a User Token Again When the Connection Changes Under the Read * fix: Apply the Current Retention Again When Another Replica Changed the Grant First * test: Answer Each Concurrent Sign-In by Its Own Code * fix: Skip Retention Rewrites for Grants That Expire Without a Refresh Token * fix: Retry a Token Rejection That Loses to a Concurrent Grant Write * fix: Skip User Token Reads for Lanes Without a Commit and Reread Status After a Reconnect |
||
|
|
52a91b23fc
|
♻️ feat: Share Pull Request Lookups Across Replicas Through Redis (#16988)
* feat: Share Pull Request Lookups Across Replicas Through Redis * fix: Bound the Shared Pull Request Cache and Drop Commands at Their Deadline * fix: Pass the Cache Config to the Pull Request Store and Check It Before a Local Cooldown * fix: Keep Batch Lookups Apart by Cache and Sharing Policy * fix: Share Only Found Pull Requests and Rate Limits, Never Moving Them Backwards |
||
|
|
5ee091e99d
|
⌨️ feat: Change Default Chat Preferences (#16932)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
Main Promotion Policy Tests / Main promotion denial and fast-forward tests (push) Waiting to run
|
||
|
|
b24bfc0dd0
|
🦊 feat: Look Up GitLab Merge Requests Behind a Provider Setting (#16986)
* feat: Look Up GitLab Merge Requests Behind a Provider Setting * fix: Revalidate GitLab Merge Requests and Read a Full History Page |
||
|
|
60f0613410
|
🏢 feat: Look Up Pull Requests on a GitHub Enterprise Host (#16985)
* feat: Look Up Pull Requests on a Configured GitHub Enterprise Host * fix: Normalize and Range-Check the Pull Request Host Port |
||
|
|
4afd5e17f8
|
💓 feat: Keep Quiet Chat Streams Alive Behind Idle-Timeout Proxies (#16904)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
|
||
|
|
1692814a30
|
🔌 feat: Enable Pull Requests by Default With a Token Fallback (#16876) | ||
|
|
caeb786e97
|
🔀 feat: Show the Conversation Pull Request in the Sidebar List (#16815)
* feat: Show the Conversation Pull Request in the Sidebar List Add a batch lookup route and a sidebar row mark: the state icon with the CI dot, opening the same card beside the row on hover. The row keeps the conversation's own title. * fix: Address Review Findings on the Sidebar Pull Request Batch and Row Mark Cap the whole batch with a configurable deadline, make the row mark a keyboard-reachable button that opens the card on focus, refresh rows when the window regains focus through the shared batch, and show a retryable failure state instead of treating a failed first lookup as no pull request. * fix: Send Sidebar Pull Request Batches One at a Time Queue every batch request behind the one before it, so an oversized list or an overlapping flush cannot multiply the server's configured lookup concurrency, and bound how long one request may hold the queue so a request that never answers cannot stop the rest. * fix: Keep the Batch Request Timeout Above the Server Deadline Default the client's request timeout to just past the longest batchTimeoutSeconds a deployment may configure, so a queued request never starts while the previous request's server-side lookups are still running. * fix: Keep Batch Lookups Inside the Concurrency Limit and Per-Entry Failures Per Entry Share one lookup limiter across every batch request so lookups that outlive a request's deadline keep their slot, answer a missing token only for the conversations that needed it, and point the row at its pull request description only while that text is in the page. * fix: Bound Batch Reads, Scope Concurrency Per Credential, and Gate the Sidebar on the Batch Version Start the batch deadline when the request arrives and bound the config and lane reads, count lookup slots per credential, advertise a batch route version and ask only a server that has it, take no row space for an absent mark, show a failed refresh over a cached empty answer, keep a malformed response from stalling the request queue, and repair the lane recording tests that still used a mock removed on dev. * fix: Move Capability Resolution Into the Package and Harden the Batch Route and Queue Resolve the pull request startup capabilities in packages/api so the route stays wiring only, bound the config and lane reads by the configured deadline, merge identical lanes before taking limiter slots, fall back to the single route when a replica has no batch route, and dispose the batch queue when the signed-in user changes. * fix: Abort the Batch Fallback With Its Request So the Queue Never Overlaps It Give the batch fetcher the request's abort signal and pass it to every single-route call, abort a request that times out or is disposed, and stop the fallback workers from starting more calls once it has. * fix: Forward the Abort Signal to the Batch POST Pass the request's abort signal through the batch fetcher, the data-provider call and Axios, so a batch request that times out or is disposed is cancelled instead of continuing beside the next one, and settle a request promptly when it is aborted. * fix: Close the Pull Request Lookup Follow-Ups and Cancel Abandoned Sidebar Rows |
||
|
|
14c43138c2
|
🖥️ feat: Show Lia on the Welcome Screen (#16684)
* feat: Show Lia on the Welcome Screen Adds the opt-in Show Lia setting (off by default) and the interface.mascot deployment flag (allowed by default). Lia mounts only on the landing page, loads lazily after first paint, stands on the composer's top edge clear of the greeting, reacts to typing, files and theme changes, and speaks through localized bubbles. She is decorative and hidden from assistive technology. * fix: Keep Lia's Long-Message Reaction Re-Armed and Pointer Reads Per Frame Deleting a message back under 280 characters now re-arms the long-message reaction, pointer handling reads layout at most once per animation frame, and the ChatView specs stub Lia like their other children. * test: Open Settings from the Phone Drawer in the Lia Scenarios The opt-in scenario no longer resets the stored preference on reload, and both Settings scenarios open the account menu from the mobile drawer on phones. * fix: Measure Lia's Caret Like the Composer and Label Her When Idle The caret mirror copies direction, alignment, indentation, wrapping and box sizing, so right-to-left and wrapped text measure like the composer. Hovering Lia between activities now says she is hanging out instead of showing nothing. * fix: Wave Off Assistants Sends and Keep Lia's Canvas and Bubble Off Welcome Content * fix: Keep Lia's Speech Bubble Inside Her Stage * fix: Wrap Long Translations in Lia's Speech Bubble * fix: Keep Lia's Long-Message Reaction Until It Plays and Pin the Scenario Greeting * fix: Make Only Lia's Body Clickable So She Fits Beside Long Greetings * fix: Let Lia Stand Beside the Composer When the Greeting Fills Its Top * feat: Let Users Drag Lia Around and Keep Her Near the Composer * test: Cover Picking Lia Up and Setting Her Down on the Composer * refactor: Keep Lia's Preference Inside Her Feature * fix: Let Keyboard Users Pet Lia and Move Her With the Arrow Keys * test: Shift Only the Wall Clock for Lia's Morning Greeting * test: Measure Lia's Keyboard Walk Both Ways So the Greeting's Width Cannot Pin Her * fix: Bring Lia Back When a New Chat Opens During Her Farewell * fix: Start Lia's Reactions on Her Own Clock After a Pause Without Room * fix: Load Lia Through Stale-Asset Recovery and Skip the Farewell Before She Appears * feat: Mark the Lia Settings Toggle as Beta |
||
|
|
ae44437e16
|
🗂️ feat: Record Lane Git State and Serve Conversation Pull Requests (#16793)
* feat: Record Lane Git State and Serve Conversation Pull Requests A conversation now stores the branch, head and repository its code lane last reported, written only by the server after a finished bash command and excluded from ordinary reads, generic saves, unset fields and imports. GET /api/convos/:conversationId/pull-request finds the pull request for that branch through an injected GitHub source with a bounded cache, answers null for an absence, and maps failures to stable codes without upstream text. The feature is off unless endpoints.agents.pullRequests is enabled with a token reference. * fix: Address Review Findings on Pull Request Lookup and Lane Writes Scope the lookup cache, shared in-flight request and rate limit cooldown to the credential, so one tenant's token never serves another. Ask for open pull requests on their own before falling back to the newest closed one, read every page of check runs up to a bound and never report an incomplete rollup as passing, order lane writes per conversation so an older write cannot land last, and name both required token permissions in the example config. * fix: Address Second Round Review Findings on Pull Request Lookup Clear the stored lane when the conversation moves to another workspace or leaves attached execution, so the previous workspace's pull request is never served. Fence the lane write on the time it was reported, so an older report from another replica cannot replace a newer one. Honor GitHub's reset window up to an hour instead of ten minutes, and expose the request timeout, whole lookup timeout and check run page limit as endpoints.agents.pullRequests settings with the previous values as defaults. * fix: Authorize Pull Request Repositories and Fence Lane Writes Require an administrator allowlist of repositories before the server token is used, since a worker reports its own repository. Match a pull request to the commit the conversation last ran at, so a reused branch name does not return another pull request. Fence the lane write on the workspace the command ran in, so a write queued before a move cannot bring the old lane back, and record a subagent thread's lane on the visible root conversation. Key the lookup cache and shared request by the recorded commit and the lookup policy, and document the worker flag in the example config. * fix: Order Lane Reports by a Database Sequence and Tighten Head Matching Replace wall clock ordering of lane reports with a per conversation counter reserved in the database when the command settles, so replica clock skew cannot reject a newer report. Treat a pull request whose head is behind the recorded commit as no match, and expose the candidate and comparison bounds of the history search as settings. Read the app config and the owner scoped lane together, inject the HTTP transport from the route instead of falling back to a global, skip a report identical to the last one written, and name the Contents permission that commit comparison needs. * fix: Queue Lane Reports by the Visible Conversation and Read Checks for the Current Head Order lane report reservations by the conversation the write lands on, so two subagent threads of one conversation share a chain, and write every report instead of skipping a repeat, since another recorder may have changed the lane in between. Read a pull request's detail before its check runs and use the head it reports, so line counts, mergeability and checks describe one commit. Treat an expired temporary chat as gone when reserving, writing and reading the lane, and make the shared cache capacity a setting. * fix: Fence Lane Reports by Attachment Epoch and Place Recorders Before Reporting Strip dotted descendants of lane fields from saves and imports, partition the pull request cache per credential, resolve the lane write target when the tool is created, and fence reports with a codeAttachmentEpoch that advances only on an owner move or detach. * fix: Fence Subagent Lane Reports by the Root Epoch and Cover Forks and Moved Heads Read the visible root's attachment epoch for a subagent report, gate lane recording on pullRequests.enabled, make the credential partition bound a config field, revalidate the detail head against the recorded commit, and find fork pull requests through the recorded commit. * fix: Keep the Credential Cache Bound Deployment Wide and Budget Head Revalidation Apply the largest configured credential bound to the shared cache, count cache hits as use, spend the comparison budget on a moved head, and fix the data-provider config default test. * fix: Cool Down Headerless Secondary Rate Limits A 403 whose message names a secondary rate limit now starts the credential cooldown for at least a minute instead of being cached as a ten second failure. |
||
|
|
0fea0240d6
|
⏳ feat: Reset Balance Allowances Without Rollover (#16781)
* feat: add periodic balance reset without rollover * fix: synchronize balance policy before periodic reset * style: preserve context balance class order * fix: Synchronize Reset Policy Before Granting Allowances * fix: Apply Current Balance Policy During Admission |
||
|
|
3f442e4dbe
|
🪶 perf: Load Tool-Call Previews and Fetch Full Parts on Demand (#16753)
* 🧾 perf: Load Tool-Call Previews and Fetch Full Parts on Demand Long agent conversations shipped every tool output, argument string and subagent transcript on load, though the cards render collapsed: 12-18 MB of message JSON per chat, enough to crash iPhone Safari tabs. A client that adds ?toolPreviews=1 to the conversation load now receives bounded previews of settled tool calls (start and end of long outputs, JSON arguments and outputs kept valid with only their longest strings shortened, exit-status trailers kept whole, subagent transcripts omitted) with explicit markers and full lengths. Opening a card or a subagent panel fetches the stored part from a new owner-scoped endpoint, GET /api/messages/:conversationId/:messageId/parts/:partIndex, cached under its own React Query key. Clients that do not ask, exports and share links keep the full payload; bounds are configurable under toolCallPreviews in librechat.yaml, and a client-authored message that carries previews is refused rather than saved. * 🧾 fix: Validate Part Reads in Parallel and Preview Fork Responses The full-part read now starts beside conversation-access validation instead of after it, and keeps the active-job fallback the conversation read has, so a conversation still live before its first save can expand its previews. Fork, duplicate and shared-link fork responses honor the preview parameter, so they no longer seed the conversation cache with the full history. Background-task results whose structure cannot fit a valid JSON preview go whole, image cards keep their prompts, and the subagent panel offers a retry when its stored part fails to load. * 🧾 fix: Key Hydrated Parts by Preview Revision and Call Identity A fetched part is now cached under the preview's revision and replaces only the fields the server shortened, so a call whose stored output changes later (a harvested background result) is fetched again rather than rolled back. Part lookups carry the run-step and agent identity and refuse an ambiguous fallback, since provider tool-call ids can repeat within one response. A subagent that finished without final text has its transcript omitted like any other settled call, and JSON nested past a fixed depth falls back to a text preview; a call whose preview fails is sent whole instead of failing the conversation load. * 🧾 fix: Release Hydrated Parts With Their History and Bound JSON Work Full tool-call parts fetched for a conversation are removed when its message history is released or cleared, so they cannot outlive it under their own key. The structure-preserving JSON preview now bails out before cloning when the value has more nodes or strings than could ever fit, keeps a __proto__ key as ordinary data, and the part endpoint accepts any safe-integer index instead of an arbitrary ceiling. * 🧾 fix: Count Property Names Before Cloning a JSON Preview Property names are never shortened, so the pre-check now adds their length to its budget and falls back to the text preview before any cloning when they alone could not fit. * 🧾 fix: Preview Artifact and Branch Responses and Rehydrate Subagent Prompts Artifact edits and parallel-response branches merge the message the server returns into the conversation cache, so both requests now ask for previews and their routes honor it. The subagent panel reads the prompt from the stored arguments once they load, and the part endpoint no longer caps identifier length, so any previewed call can be fetched. * 🧾 fix: Preview Only Tool Calls That Can Be Fetched Back by Identity A call without an id has nothing but its position to name it, and the position can shift on the client, so it is left whole instead of being previewed. The part endpoint now requires a tool-call id, so an indexed lookup always confirms the call it returns. * 🧾 fix: Fetch Parts by Exact Identity and Preview Only Unique Ones The part endpoint now finds a call by its exact identity (provider id, run-step id, agent) instead of trusting the client's index, and the preview pass only shortens calls whose identity is unique in their message, so every preview names exactly one stored part. Legacy web-search failures that carry their error phrase mid-output go whole, since the collapsed card reads that phrase anywhere. * 🧾 fix: Bound the JSON Fit Walk Before Queueing and Normalize Empty Identities The structure check now counts an array's or object's children against the node budget before queueing them, so a very wide value is refused without building a work list its size. An empty run-step or agent id is treated as absent by the part lookup, matching how the preview pass and the client already treat it. * 🧾 fix: Key Fetched Parts to the Stored Version and Hydrate Search Details Each preview now carries `previewRevision`, when its message last changed, and the client keys fetched parts to that plus a fingerprint of the whole preview, so any change to the stored call is fetched again. The web-search details card asks for the stored call when it opens, so its query is never left shortened. * 🧾 fix: Cache Fetched Parts by Identity and Hold Copy Until Hydrated The part query key drops the client-side index, which only rides along in the request; the server locates the call by message and exact identity, so a shifted index serves the cached copy instead of downloading it again. Copy controls inside a previewed part are disabled until the stored content arrives, so a slow or failed fetch cannot export shortened text. * 🧾 fix: Shape Shared Forks With the Recipient's Bounds and Keep JSON Numbers Exact A shared-link fork resolves the share owner's config for its content checks, but the forked conversation belongs to the requester, so its preview bounds now come from the requester's tenant and role (prepareResultToolCallPreviews). A structure-preserving JSON preview now requires every number in the text to survive a parse and re-serialization as the same value; an integer past 2^53, an out-of-range exponent or an over-precise decimal falls back to the text preview (or the whole output for parsed-output tools) instead of showing a changed value. |
||
|
|
c6e5f98552
|
⚙️ fix: Default Running Chat Rename to On (#16769)
interface.runningChatRename now defaults to true, so a running chat or a placeholder-title chat can be renamed without a librechat.yaml override. Set it to false during a rolling upgrade from a version without title ownership. |
||
|
|
82cde522f2
|
💳 feat: Show Balance in the Context Gauge as Credits, Currency, or Percent (#16762)
* 💳 feat: Show Balance in the Context Gauge as Credits, Currency, or Percent Move the balance out of the account menu into the composer's context gauge, below the context window, and add `balance.display` (credits | currency | percent, default credits) to choose how it reads. Currency reuses `interface.currency` at 1,000,000 credits per USD; percent shows only the share of the period's allotment spent. Settings > Account > Billing renders the same summary from the same hook, so both surfaces show identical figures, bar and refill timing in every mode. * 🧭 fix: Normalize the Balance Display Mode and Reuse a Fresh Reading on Hover Admin overrides reach the client without schema validation, so an unknown `balance.display` now reads as credits instead of being typed as a mode it is not. Hovering the gauge mounts the balance reader each time the card opens; a 30 s stale window stops every hover from refetching, while the explicit refetch after each turn still bypasses it. * 🩹 fix: Restore Gauge Popover Fixes and Tighten Balance States The popover extraction was written from a pre-sync read of TokenUsage, so it dropped dev's viewport caps and scrolling, the hideOnInteractOutside close fix, the Tailwind v4 outline-hidden rename, and the card's max-w-full; restore them. Refill copy now says when a refill becomes available rather than promising a deposit, since one lands only once the interval has passed and a charge would exhaust the balance. An empty balance reads as fully used even without an allotment, percent mode without one says usage is unavailable instead of leaving the figure blank, the balance-only ring takes the balance tone (amber until empty) and is a meter only once it has a value. * 🪙 fix: Read a Non-Positive Refill Amount as No Auto-Refill in Settings The server never refills when the amount is not positive, and the balance summary already says so; Settings showed its load error instead. * 💸 fix: Show the Insufficient-Funds Error in the Balance Display Mode The token-balance error still printed raw credit figures, so `percent` leaked the numbers it hides and `currency` mixed units with the gauge. It now reads the same display mode and formatter as the balance summary: credits as before, money in currency mode, no figures in percent mode. The auto-refill settings row also renders its own loading and failure states, since settings search can show it without the balance row beside it. * 🎚️ fix: Keep Fractional Credits and Drop the Moved Popover's Suppression Credit amounts keep up to two decimals, so an insufficient-funds message no longer reads 100.4 against 100.3 as 100 against 100; whole amounts still print without decimals. The design-rule backlog may not follow code into a new file, so the extracted popover uses the standard `transition` utility instead of the arbitrary `transition-[opacity,transform]` (which also misses Tailwind v4's separate `translate` and `scale` properties) and its suppression is removed. The composer geometry spec now reads the classes from `Popover.tsx`, where the gauge button lives. |
||
|
|
af35fe5439
|
🪚 chore: Deprecate Agent Chain Authoring (#16745)
* feat: consolidate orchestration into a native tool * test: complete persisted subagent graph fixture * fix: keep orchestration pickers inside the modal focus scope * chore: deprecate agent chain authoring * fix: preserve runtime-equivalent legacy handoff classification * test: stabilize orchestration dialog lifecycle coverage * test: wait for stream completion before final title polling --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
3e4b01834f
|
🫗 perf: Release Message Histories of Conversations the User Has Left (#16747)
* 🫗 perf: Release Message Histories of Conversations the User Has Left Long agent conversations hold 12-18 MB of message JSON each in the React Query cache, and the default 5-minute cacheTime kept every conversation visited in that window. Switching between a few of them on mobile Safari grew the JS heap past 300 MB and crashed the tab. retainMessages tracks when each per-conversation history loses its last observer and releases it once it has no observers, is not fetching, is not pinned, and is either older than 60 s or beyond the single most recently left conversation. The routed conversation, conversations with a running job, and conversations awaiting an approval decision stay pinned; releases wait while any mutation is pending. Returning to a released conversation refetches its history. * 🫗 fix: Own History Collection, Configure the Grace, and Pin by Server State Per-conversation histories get an infinite cacheTime while retention runs, so React Query's own five-minute collection can no longer drop a history a running job still pins; newly seeded histories schedule a pass; the grace and recent count come from interface.historyCacheTtlMs and interface.historyCacheRecent; the approval pin is replaced by the active-jobs set, which already lists jobs paused for a live approval; and Assistants histories stay pinned because deletion reads their thread id from the cache. * 🫗 fix: Re-arm Collection for Histories Already Counting Down and Recheck Pins Promptly A history left before retention started still had React Query's five-minute GC timer; a momentary observer now re-arms it under the infinite cacheTime. Histories kept only because they are pinned or fetching are judged again after 5 s instead of a full TTL, so a run that ends releases its transcript promptly. * 🫗 fix: Exempt Assistants Histories Without Polling and Leave Fetching Histories Alone Assistants histories are now exempt rather than pinned, so they are kept without a recurring recheck timer. The startup re-arm skips histories with a fetch in flight, since detaching a momentary last observer would cancel the request; settling the fetch re-arms collection on its own. |
||
|
|
0e3c9088f6
|
🫰 feat: Configure Tool Approval Modes Per Agent (#16707)
* 🫰 feat: Configure Tool Approval Modes Per Agent
* fix: Fence Remembered Tool Approval Authority
* fix: Unify Tool Approval Execution Invariants
* fix: Revalidate Learned Approval at MCP Invocation
* fix: Preserve One-Time MCP Review at Invocation
* fix: Execute Reviewed Calls on Templated MCP Connections
* fix: Scope Approval Witnesses to Executing Agents
* fix: Retain Approval Bindings for Hook-Rewritten Inputs
* fix: Pin Review Authority and Retire Settled Tool Calls
* fix: Fingerprint Effective MCP Request Headers
* fix: Preserve Routing Around Renewable MCP Token Fragments
* fix: Bind Tool Consent to OAuth Credential Generations
* test: Keep Mobile Approval Save Outside Drawer Escape Race
* fix: Fence OAuth Consent at MCP Transport Retries
* fix: Let Shared Agent Viewers Reset Personal Consent
* fix: Preserve Renewed Consent Across Reset Races
* fix: Resolve Verified Aliases for Personal Tool Reset
* fix: Fence Renewed OAuth Consent and Credential Review
* fix: Require Foreground Execution for Review-Only MCP Calls
* fix: Pin Invocation Ownership and Stable MCP Consent
* fix: Fence Superseded Tool Consent Completion Writes
* fix: Scope Consent Epochs to Effective MCP Authentication
* fix: Scope Approval Admission to Reachable Agent Tools
* fix: Preserve Approval Epochs for Runtime-Detected OAuth
* fix: Address Tool Approval Review Findings
* fix: Preserve Captured Consent When Tool Approval Is Inherited
* fix: Preserve Approval Admission Through Lazy Metadata
* fix: Fence Programmatic Reviews and Unresolved Lazy Approval Keys
* fix: Account for Normalized and Skill-Contributed Lazy Tools
* fix: Scope Lazy Approval to Selected Tool Spellings and Servers
* fix: Honor Disabled MCP Capability During Lazy Approval Admission
* test: Preserve Approval Merge Regressions After Rebase
* fix: Preserve One-Time Review During Non-OAuth Grant Outages
* fix: Retain One-Time Consent Across Resume Recovery
* fix: Preserve Reviewed Consent Through Transport Outages
* fix: Preserve Case-Variant Lazy Approval Hook Admission
---------
Co-authored-by: Lia <lia@librechat.ai>
|
||
|
|
19092e55bd
|
🖲️ fix: Enable Running Chat Menus and Preserve Renamed Titles (#16697)
Reconciles current dev while preserving manual title ownership, existing menus, and configuration regressions. Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
2b4e5b5acd | 🎐 perf: Coalesce Ready Background Completions by Default | ||
|
|
fb1dd57a9b
|
🔓 feat: Remember Tool Approvals Per Conversation (#16557)
* feat: Remember Tool Approvals Per Conversation Adds an opt-in "Always allow" choice to the tool approval card. When endpoints.agents.toolApproval.allowAlways is true, the server marks eligible paused calls with allow_always; approving with scope "session" stores that exact tool name on the conversation, and later runs in the same conversation fold the stored names into the policy as exact-name allow entries. The server enforces every step: the resume route rejects a session scope the pause did not offer, eligibility is rechecked against the live policy before storing, the list is written only through an owner-scoped bounded method, and generic saves and imports cannot set or clear it. Admin deny and ask rules and programmatic hooks still win, stored names are ignored under dontAsk or when the flag is off, and native code tools stay under the code approval picker. The flag defaults to false, so existing deployments keep prompting. * fix: Share the Effective Approval Policy and Persist Allows After Resume Fences Offering, resume re-check, scheduled admission and createRun now read one policy from buildEffectiveToolApprovalPolicy: endpoint rules healed against MCP alias spellings, then the conversation's remembered tools. A call held by a healed ask rule is no longer offered "Always allow", and a scheduled fire whose known tools are all remembered is no longer rejected as pause capable. The remembered-tools cap and name length cap move to toolApproval.allowAlwaysMaxTools and allowAlwaysMaxToolNameLength (defaults 64 and 256). The card stops offering the choice for new tools once the cap is reached instead of silently approving once. The resume route stores remembered tools only after the schedule and project context fences pass; a storage failure still approves the call once. * fix: Offer Always Allow Only When It Will Hold Offer allow_always only when storing the name would auto-approve the next identical call on the run's own path: every MCP spelling of the tool passes the healed static policy and no programmatic or plugin approval hook can apply to it (the pause payload does not record which hook asked). Remembered names now expand to every alias spelling of the same tool, and a deny or ask on any spelling keeps the tool ineligible. A table-driven spec walks the invariant through the real hook wiring. * fix: Recheck Approval Hooks Before Remembering a Resumed Approval The resume-time eligibility recheck now applies the same programmatic and plugin PreToolUse hook check as marking, with a hook context built from the resume request and the live plugin hook source. A hook registered after the pause turns the choice into a one-time approval: nothing is stored and the resume continues. Document that toolApproval.allowAlways should be enabled only once every replica supports it, since older replicas ignore the choice. * fix: Judge Always Allow Offers Against the Run's Live Aliases and Active Cap * fix: Charge Only New Tool Names Against the Remembered Approval Cap * fix: Recheck Remembered Approvals Against the Paused Run's Aliases * chore: Sort Imports in Agent Run After Rebase |
||
|
|
4217b9898a
|
🏋️ fix: Bound Host File Edits Outside the API Event Loop (#16677)
* fix: bound host file edit work outside the API event loop * fix: reject host edit replies past their monotonic deadline * fix: preserve bounded host edits and sanitize startup failures * fix: account permitted full-context edits without redundant scans * fix: preserve sandbox write cancellation as an abort --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
0c5e1ce67f
|
📕 fix: Explain Native Web Search Permission Denials (#16691)
Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
1a8d23e1ed
|
✅ feat: Default Machine Selection and Linked-Worktree Lanes On (#16678)
* ✅ feat: Default Machine Selection and Linked-Worktree Lanes On
Per-chat machine choice from an agent's saved allowlist and linked-worktree
lane routing were both opt-in, so neither worked until a deployment found and
set its flag. Both are now on unless set to false: machine choice still only
applies to agents with a saved allowlist, and lanes still require a worker
that advertises git_linked_worktree. One helper per flag in data-provider
decides the default for every server reader and the advertised client config.
* feat: Advertise the Code Environment Decision Protocol by Default
Per-chat machine choice needs the conversation decision protocol, which the
client requires before offering allowlisted machines, but the protocol was
only advertised when CODE_ENVIRONMENT_DECISION_VERSION=1. With selection on
by default, authors could save an allowlist the composer never offered.
An unset or blank value now advertises protocol v1; any other value, such as
0, keeps the legacy-safe path.
* fix: Turn Machine Choice Off With the Decision Protocol Opt-Out
CODE_ENVIRONMENT_DECISION_VERSION=0 stopped advertising the protocol but
routing still accepted a non-default machine, so a cached tab or a direct
client could persist a choice during a mixed-version rollout. Machine choice
is recorded through that protocol, so isCodeEnvironmentSelectionEnabled now
requires both, for routing and for the advertised endpoints config. The
protocol resolver moves to code/protocol.ts (re-exported from code/config)
so execution and endpoints can use it without an import cycle.
* style: Format checkout routing regression cases
---------
Co-authored-by: Lia <lia@librechat.ai>
|
||
|
|
bb0543fd15
|
📼 fix: Replay Running Subagent Activity (#16541)
* 📼 fix: Replay Running Subagent Activity * 📼 fix: Preserve Activity Across Rollouts and Reconnects * 📼 fix: Backfill Missing Foreground Activity * 📼 fix: Fence Replay and Drain Admitted Activity * 📼 fix: Close Subagent Replay Review Gaps * 📼 fix: Resume Activity After Replay Recovery Expires * 📼 fix: Use Singular Subagent Omission Copy * 📼 fix: Preserve Public Replay and Displayed Activity * 📼 fix: Write Expanded Live Activity Before Queuing * 📼 fix: Track Disjoint Subagent Replay Coverage * 📼 fix: Preserve Tool Details and Omission Totals * 📼 fix: Recover Tool Timing During Replay Backfill * 📼 fix: Reconcile Covered Replay Timing Metadata * 📼 fix: Restore Message Phases During Replay Backfill --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
73d704656e
|
📔 feat: Preserve Owner Text During PII Redaction (#16311)
* 📔 feat: Preserve Owner Text During PII Redaction * 🧵 fix: Keep Ordinary Chat Views Outside Private Text Provider * 🧷 fix: Preserve Owner Text Across Copy and Edit Paths * 🔏 fix: Protect PII on Denial and Abort Paths * fix: preserve protected text through denial, stop, and owner reload * test: cover preliminary private metadata in disconnect fixture * test: carry preliminary metadata in resume controller fixture * test: preserve Stop prerequisite identity in tenant fixture * fix: keep protected owner text out of search and exports * fix: preserve trusted PII placeholders through provider inspection * fix: coordinate protected turns across Stop and native sharing * fix: Preserve Private Text Admission and Query Lifecycles * fix: Track Private Query Effect Dependencies * fix: Fence Protected Admission and Screenshot Targets * fix: Share Protected Admission and Preserve Native Token Trust * test: Wait for Private Message Concurrency Indexes * fix: Preserve Protected Admission Across Recovery and Titles * fix: Coordinate Protected Root Admission and Early Stop --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
2eee568542
|
🧳 feat: Choose Agent-Allowed Machines For New Chats (#16651)
* feat: Let New Chats Choose Agent-Allowed Machines * test: Keep Machine Choice Contracts And Native Selectors In Sync * fix: Preserve Graph Machine Choices And Reference Lifecycles * fix: Explain Graph Workspace Requirements And Validate Machine Choices * test: Cover Default And Non-Default Graph Machine Choices * test: Keep Unauthorized Machine Duplication Mocks Isolated * fix: Preserve Graph Agent Machine Ownership And Explain Requirements * fix: Preserve Stable Workspace Ownership Across Runtime And Config Changes * test: Wait For Verified Generation Readiness In Native Canaries |
||
|
|
59b772f132
|
🥽 feat: Configure Attached Defaults and Honor Skill Read Ranges (#16540)
* feat: configure attached command and read defaults * fix: separate programmatic timeout defaults from ceilings * fix: retain attached programmatic schema instructions * fix: honor explicit skill and sandbox read ranges * fix: remove duplicate command imports after rebase * fix: retrieve complete sandbox text before paging --------- Co-authored-by: Lia <lia@librechat.ai> |
||
|
|
345a20fe3a
|
🪟 feat: Undock the Artifacts Pane into Its Own Window (#15911)
* 🪟 feat: Undock the Artifacts Pane into Its Own Window The artifacts pane could only live in the chat's side panel, so viewing an artifact meant giving up half the conversation and there was no way to put it on a second screen. A header action now moves the pane into a separate browser window and back. The pane stays in the chat tab's React tree and is portaled into the popup's document, so artifacts keep streaming into it and docking back is a re-render rather than a reload. Everything a portal does not carry is mirrored: the host stylesheets (re-synced for lazy chunks, HMR and CSSOM-only rules), the resolved theme, a base URL for relative assets, and Sandpack's frame messages, which would otherwise never reach the listener the opener installed. * 🪟 fix: Keep the Artifacts Pane Whole When It Changes Windows Review of the undock change surfaced one cause behind most of its findings: the pane is a new component instance in every host, so anything a mount decides was lost or wrongly reset when it moved. - The code editor buffer now carries the artifact it belongs to, so a remount restores unsaved text instead of falling back to the persisted content, and the edit the debounce never got to send is handed to the mutation on mount. The share hosts take one provider around every branch for the same reason. - The artifact registry is cleared by the host that owns it: the pane keeps it while it only changes windows, and leaving the route wipes it, so no artifact follows the user to a shared conversation. - Fullscreen exits through the document that owns the container, Mermaid pan listens where its canvas lives, and Copy reports success only once the write resolves, with a toast when it does not. - Style mirroring compares what a sheet actually contains: rules a page inserts through the CSSOM are serialized, and a rewrite the observer saw refreshes its clone even when nothing measurable changed. - A child-activity panel opened while the pane is undocked stays open; the two panels are exclusive only while they compete for the side panel. Adds the scenario suite for the window behaviors (`@scenario:` tagged) plus unit coverage for the registry lifetime, the panel slot and buffer ownership. * 🧭 fix: Carry the Artifacts Tab Across a Window Change The pane's active tab lived in the component instance, so undocking from the code tab landed the user back on the preview — with their unsaved text out of sight, which reads as losing it. The tab is pane state now, next to the editor buffer it belongs with, and the scenario asserts both survive the move. * 🧹 chore: Drop Unused Imports From the Presentation Spec * 🎯 fix: Bound the Artifacts Pane's Shared State to Its Session The second review round found the cost of state that outlives an instance, all in the seams the first round opened. - Download now reads the editor buffer only when it belongs to the artifact on screen, so selecting another artifact cannot export the previous one's edits. - The active tab is reset when the pane session ends — close or conversation change — instead of following a later artifact onto the code tab. - A mutation started by a previous pane instance can no longer report back, so the mount releases the stale "mutating" flag before handing over the restored text; otherwise the edit queued behind a completion that never arrives. - The undocked window's size and position are read while it still has them, in its `pagehide`, so closing through the browser remembers the bounds too. - Docking from the window moves focus to the control that replaces the one the user pressed, which a keyboard user otherwise loses to the document. - The share host keeps one `EditorProvider` mounted across the closed and open branches, so opening the overlay no longer remounts the transcript. * 🎨 fix: Paint the Undocked Window Before Its Sheet Arrives A mirrored stylesheet is a fetch, so the popup showed its default white canvas for that moment — plain against a dark app, and visible to the scenario as a transparent pane. The host's resolved surface colour is now the `var()` fallback in the popup's own layout sheet, so the window opens on the app's canvas and the real token takes over when it lands. The two scenarios that read settled state — the painted canvas, and a keyboard Enter that closes the window it was pressed in — now wait for it instead of sampling the first frame. * 🔭 fix: Focus the Dock Target Once the Pane Has Mounted\n\nThe focus handoff ran before the pane rendered its toolbar, so the control it\nwas meant to focus did not exist yet and the request was never spent. It now\nwaits for the mount that creates that control. * 🧩 fix: Give the Edit Pipeline and the Transcript One Owner Each Round three found the same shape three more times: work that belongs to a session was still decided by an instance or by a branch. - The editor no longer infers whether a previous instance's save is running. React Query keeps a mutation's callbacks on the mutation, so that request settles the shared flag itself; the new instance waits for idle and submits the restored buffer once, instead of clearing a flag it does not own and resubmitting against an `original` the earlier request may have replaced. - The shared conversation keeps its transcript in one place — always the first panel of the resizable group — so opening the pane, undocking it or docking it again changes only the pane's host, not the transcript's ancestry. - The clipboard fallback runs in the pane's own document, so an undocked pane on a deployment without the Clipboard API can still copy instead of only reporting failure. * 🧷 fix: Tie the Editor Buffer and Focus to the Pane Session Round four found the last places where the retained buffer and the focus handoff were decided by a code path rather than by the session boundary. - Closing the pane discards the buffer, the tab and any pending focus request, so reopening an artifact starts from what is saved instead of restoring — and silently resubmitting — text the user abandoned. - Only the buffer an instance inherits at mount is drained. Navigating back to an artifact restores its own unsaved text in the editor instead of writing the persisted content over it, which used to queue that content behind the edit and undo it. - Closing the window through the browser hands focus back exactly as the Dock control does, rather than leaving a keyboard user on the document body. - The clipboard fallback restores focus by capability rather than `instanceof`, which never matches across the popup's realm. * 🔐 fix: Make Undocking Configurable and Its Saves Session-Bound - `interface.artifactUndocking` is a `configSchema` field, default enabled, so a deployment that cannot use popups keeps the docked pane. The hosts resolve it — the chat host from the startup config, the shared host from the shared-link config, which now carries the flag — and hand it to the pane through the context it already takes, rather than the pane reading config itself. - A save carries the editing session it was started in. React Query keeps its callbacks after the editor is gone, and those callbacks used to write the buffer a closed session had just cleared and submit its queued edit; they now stop at a session boundary, so a closed pane mutates nothing and leaves no text behind for the next one. * ✂️ fix: Stop the Editor from Overwriting Another Artifact's Unsaved Text - A write this component makes into the Monaco model comes back through `onChange` exactly like a keystroke. Restoring an artifact's text therefore looked like typing and keyed the shared buffer to the artifact now on screen — so selecting another artifact before the debounce fired replaced the text the first one was still holding, and returning to it showed the persisted content. The value written here is now recognised and consumed, and the retained buffer is sent deliberately when its artifact comes back, which is where its cancelled debounce finally becomes a save. - The save lock is the session's, not a request's. A save that outlives its session no longer clears the lock or the failure notice a later session took, and ending a session releases it — while an edit typed behind a lock whose owner is gone is sent by the editor holding it as soon as the lock is free, instead of waiting for the user to type again. * 🔔 fix: Report Failures in the Window the User Is Looking At The app's toast surface is mounted once in the chat tab, so a notice raised from the undocked pane — a copy that no clipboard path accepted, for instance — appeared in a document nobody was looking at. The window now carries a Radix toast provider and viewport of its own around the portaled pane; the toast state is shared, so the same notice is shown wherever the user is rather than routed by hand at each call site. * 🚧 fix: Offer Undocking Only Once the Deployment Has Answered An absent config read as enabled, which is the default, but a config request in flight reads the same way: a user could undock during that window and the arriving answer would then take the Dock control away with it. Both hosts now treat an unanswered config as no capability, and the pane keeps the control that docks it whenever it is undocked, so a capability that disappears cannot strand the pane in a window with no way back. * 🎯 fix: Land Queued Edits, the Config Toggle and Focus on the Window - A queued edit is sent against the content the artifact actually holds. The save that held the lock has already replaced what that edit was typed against, so submitting the captured `original` had the endpoint reject the newest text and leave it in the buffer alone. - `interface.artifactUndocking` now survives interface loading: `loadDefaultInterface` rebuilds the object property by property, so the flag never reached `/api/config` or the shared-link payload and a deployment that set `false` still saw the control. - Undocking hands focus to the pane the way docking already did. The control the user pressed goes away with the docked toolbar, so a keyboard user was left on the empty document of the window that had just opened; the focus request is now a move in either direction, which is what it is named after. * 🔓 fix: Let the Request Own the Save, Not the Session The save lock was a flag the editor set and cleared, which gave two ways to be wrong: a callback whose session had ended cleared a lock the next session was waiting on, and ending a session released a lock whose request was still running — so a pane reopened mid-save could start a second read-replace-save against content the first request was about to change. The state is now the request's. The artifact save carries a mutation key and `isMutating` is read from React Query's mutation cache, so it is true exactly while a save is in flight, whoever started it: nothing to release, nothing to leave behind, and an editor that appears mid-save queues its edit and sends it — rebased on the content that landed — once the request settles. * ⏱️ test: Give the Undocked Preview Time to Compile * 📌 fix: Rebase a Queued Edit on What the Save Actually Wrote The artifact registry catches up when the edited message propagates, not when the save returns, so an edit sent in between was rebased on content the server had already replaced and the endpoint rejected it. The text the last save wrote is on the request itself: the drain reads it from the keyed mutation in React Query's cache and falls back to the registry only when there is no save to speak of. The same applies to a buffer inherited at mount, which is submitted against that record too. * 🧷 fix: Keep the Pane's Tab and Its Storage Off the Instance Both findings of the review at a03ee0f7 are the same shape as the ones before them: something the pane needs was reached for where it does not survive. - The tab is pane state, but the reset that keeps it honest was an instance ref. A host change mounts a new pane, so that ref started empty, read the artifact already on screen as freshly opened and wrote `preview` back — undocking and docking both returned the user to the preview, which reads as the code they were editing having been thrown away. The marker moves to the atom beside the tab it guards, and ends with the pane session like the rest of it. Opening a *different* artifact still returns to the preview. - `localStorage` was reached for at the call site. A policy that denies Web Storage throws from the getter itself, before the guard around `getItem` could run, so undocking threw instead of falling back to default bounds and the redock and teardown paths threw on their way home — stranding the pane in a window whose control the user had just pressed. Both helpers take the window and touch storage inside their own guard. The scenario that should have caught the tab defect asserted `aria-checked` once, which matches the frame before the reset lands, so it is polled now. * 🧪 test: Drop the Denied-Storage Scenario the Shell Cannot Support Verification at c94e5ef showed the scenario asserting a capability LibreChat does not have: denying Web Storage in the browser replaces the page with the error boundary ("denied") before the pane's controls are reachable, so the popup never opened and the test timed out in all three projects. The finding behind it was about one call site — the pane reaching for `source.localStorage` outside the guard around its `getItem` — and that stays fixed and covered by the unit tests in `undockedWindow.spec.ts`, which reproduce the throwing getter and fail without the fix. Surviving denied storage app-wide is the shell's problem, not the pane's, and is tracked at berry-13/LibreChat#41. The spec says why the scenario is absent so it is not added back. * 🔗 fix: Match the Artifact Trigger's Name as Dev Now Builds It The scenarios opened the artifact by its full accessible name, spelled out as "<title> Click to open". Dev's "Unify Artifact Triggers as Tool Rows" (#15915) folded the format badge and whether the row renders a preview into that name, so it now reads "E2E HTML Artifact HTML Opens as a rendered preview Click to open" and an exact match finds nothing. Every scenario in the file failed at its first click, three retries deep, which is what pushed the e2e shard past its 30 minute ceiling. This did not show up locally because the mock harness serves `client/dist`, and mine was built before the rebase. The old bundle still rendered the old name, so the stale locator passed here and failed in CI — and dev's own `plain-text-artifact-row` spec failed locally for the mirror-image reason. Both pass against a freshly built client. The trigger is matched on its title now, the way dev's spec does it, so the badge and the preview hint can change again without breaking the file. * 🍞 fix: Share One Toast Viewport Between the App and the Window The undocked artifacts window needs a toast viewport of its own, and it carried its own copy of the app shell's class list — so any change to toast placement, stacking or width would have had to be made twice, or the popup's notices would drift from the app's.\n\nThe viewport is now one composition in \, rendered by both hosts. It keeps the class list it always had and still takes a \, so the popup can adjust its own placement without forking the primitive. * 🚫 fix: Keep a Rejected Edit Rejected Across a Host Change A save the endpoint answers with 400 is deterministic, and the editor already refuses to send that exact text again. The refusal lived in the editor instance while the text itself lives in the shared buffer, so moving the pane to another host — which remounts the editor — dropped the marker and the inherited-buffer drain immediately sent the rejected text back, against the same original that produced the 400. Every dock or undock cost another rejected request, with no new edit from the user.\n\nThe marker now sits beside the buffer it describes, in the editor session, and names the artifact it was recorded for. A remount inherits it; a successful save clears it; ending the session clears it with the buffer. Returning to an artifact no longer resends its rejected text either, for the same reason. A genuine new edit still saves. * 🧭 fix: Key the Artifact Registry to the Host's Conversation The guard that bounds the artifact registry to one conversation decided that the conversation had changed by reading the chat tab's Recoil slot, which the shared route never sets. A shared conversation's host stays mounted while the reader moves between shared links, so on that route the change was invisible and only the unmount cleanup ever fired: artifacts from the previous link stayed in the registry, and opening an artifact in the next one could list and navigate back to the previous share's content.\n\nThe identity is now the host's to supply — the chat tab passes its Recoil slot, a shared conversation passes its own id — which is also what keeps the hook from reaching into app-global state for something only its caller knows. The first observed identity still does not wipe, so the loading transition into a shared conversation keeps the artifacts that belong to it. * 🧪 test: Cover the Shared Host, a Blocked Popup and a Rejected Save Three paths the pane reaches that no scenario exercised: a shared conversation, whose host resolves the undock capability from the shared-link config; a browser that refuses the popup, where the pane has to stay put and say so; and an edit the endpoint rejected, which must not go back on the wire because the pane changed hosts. * 📝 docs: Document the Artifact Undocking Toggle in the Example Config \ reached the schema and the shared-link config without ever appearing in the example file a deployment copies, so the lever existed but was undiscoverable. Documented with the default that reproduces today's behavior. * 🔐 fix: Make the Undock Capability the Host's Answer, Not a Default \ filled \ with \ when a host left it out, so a host that forgot would offer a window the deployment may have turned off — the one field in that context with no sensible fallback. It is now required, which makes forgetting it a compile error instead of a capability grant. * 🕰️ fix: Read an Absent Conversation as Loading, Not as a Switch The registry guard normalized a missing identity to a sentinel and stored it, so a host that reported nothing for a render — a shared link whose data refetches, a chat tab reading its slot before it is filled — looked like a move to another conversation. The reader lost the artifact they had open, and the same conversation coming back read as a first sighting.\n\nAn absent id is now no news at all: the last real identity stays the one the next id is compared against, so returning to it changes nothing and a real switch still wipes. Reported by Devin review of 097f9bfadd (BUG-0002), which also caught that ShareArtifactsContainer's comment already promised this behavior. * 🏷️ fix: File a Refused Save Under the Artifact That Was Refused The rejection marker was written with whichever artifact the pane happened to be showing when the 400 landed. A save answers after the user may have moved on, so a refusal for artifact A filed under artifact B left A free to send the same refused text again as soon as the user came back to it — and cleared B's own marker on A's next success.\n\nThe artifact a save was started for is captured when the request goes out, and both callbacks use it: the refusal names that artifact, and a success clears only that artifact's marker. Reported by Codex on 097f9bfadd. * 🖥️ fix: Do Not Reopen the Pane on a Monitor That Is Gone Remembered bounds are coordinates, and they outlive the monitor arrangement that produced them. Undocking takes the pane out of the page along with the only control that docks it, so a window reopened onto a display that no longer exists takes the artifact somewhere the user cannot reach.\n\nThe remembered rectangle is now used only when it can still be reached: it either overlaps this display's work area, or the browser says another display is attached, which is the case the feature exists for. A desktop reporting exactly one display is the only one where the rectangle is provably gone, and there the pane opens at the default bounds. A browser that does not report other displays keeps the user's placement. Reported by Devin review of a85d5c348e (BUG-0001). * 🪞 fix: Follow a Stylesheet the Host Switches, Not Only Rewrites The style mirror watched for nodes and text, so a sheet whose attributes changed — a \ switch, a \ flag, a \ that stops it being a stylesheet — left the popup showing styling the host had moved on from, with nothing to bring it back into line.\n\nThose attributes are part of the signature now, the observer watches them, and an update applies them to the clone alongside its content. Reported by Devin review of a853d48c90 (BUG-0002). * ♻️ fix: Rebase Every Resubmitted Edit on What the Last Save Wrote An edit replaces whatever the last save wrote, and the artifact registry only catches up when the edited message propagates. Three separate paths resubmit retained text — a queued edit, a buffer inherited at mount, and the edit restored when the user comes back to an artifact — and each had to learn that separately; the restore path had not, so it sent \ as the original, the endpoint refused it with a 400, and the text the user typed never landed.\n\nThe rebase now happens once, where the request is built: \ resolves the original from the save's own record unless a caller overrides it, so no path can forget — including the ordinary keystroke debounce, which had the same gap right after a save. Reported by Codex on a7c047cc2a, and the third finding in this family. * 🧪 test: Let the Shared-Link Dock Click Race Its Own Window Docking closes the window the click was made in, so the click can resolve against a page that has already gone — the same race the focus scenario already tolerates. The assertion that matters, the pane arriving back in the shared page, is unchanged. Seen once on desktop-dark while verifying a7c047cc2a. * 🪞 fix: Clone a Stylesheet in the State the Host Has It The attribute mirror kept a sheet current once the window was open, but the clone was built without those attributes — so a sheet the host had already switched off, or aimed at another medium, arrived in the popup switched on. Its signature matched from that moment, so the sync had nothing to correct.\n\nThe clone now carries the same attributes the sync keeps current. Reported by Devin review of c5d51b85fb (BUG-0002), and the same cause as its predecessor in that round. * 🧪 test: Match the Blocked-Popup Notice Where It Is Shown The notice is rendered in the toast and repeated in the live region, so the text matched two nodes and the assertion tripped strict mode on the slower mobile project. Either node proves the user was told; the assertion now takes the first. * 🗑️ fix: Never Let a Cleared Editor Save Itself as a Deletion Typing has always refused to save an empty editor: a user who selects all and deletes is mid-edit, not asking for the artifact's content to be removed. The paths that resubmit retained text did not know that, so a buffer holding an empty string was sent the moment the pane changed hosts or the user came back to the artifact — persisting a deletion nobody confirmed.\n\nThe rule now sits with the other decisions about whether a request goes out, in \, so the debounce, the queued edit, the inherited buffer and the restore all share it. Reported by Codex on a9a51439a5 (P1). * 🧹 fix: Retire the Inherited Buffer Once a Newer Edit Is in Play A host change hands the replacement editor the text its predecessor never sent, and the drain submits that once the save pipeline is idle. If the user kept typing in the replacement, the newer text queued behind the running save — and when it landed, the drain still had the older buffer in play and sent it, putting the artifact back the way it was.\n\nAnything an instance submits or queues now retires the buffer it inherited at mount, so the newest text is the last word. The drain passes the inherited text itself, which is how it stays exempt. Reported by Codex on 04a9f685b6 (P1). * 🎨 style: Satisfy the Tailwind v4 Class Order From Canary * 🧺 fix: Retain a Displaced Buffer Under the Artifact That Owns It Editing one artifact evicted another's unsaved text from the shared code buffer: the selection change had cancelled that edit's debounce, so the overwritten copy was the only place it lived and coming back to the artifact fell through to its persisted content. A buffer another artifact displaces is now retained under its owner, and the editor restores and sends it from there on the way back. Reported by Codex on 591ab13c96 (P1). * 🧪 test: Key the Tabs Spec's Mocked Buffer to Its Artifact The pane-wholeness change gated the preview on the buffer naming the artifact on screen, but the spec's useCodeState mock never set codeArtifactId, so the edited preview never applied. The mock now carries the owner the component reads, and the editor spec's mock grows the retained-buffer field the component destructures. * 🧪 test: Prove a Displaced Edit Returns With Its Artifact The displaced-buffer scenario gets its contract-level coverage: an edit the user leaves on one artifact, an edit that displaces it on another, and a return that has to land on the first artifact's own unsaved text. The fake model grows a reply carrying two artifacts so both trigger rows exist in one conversation, and its one nested ternary is unrolled so the file lints under the repo rules CI applies to staged files. * fix: Resolve Every Artifact Surface and Refusal Per Artifact Preview, download and the Mermaid host now read an artifact's retained buffer the same way the editor does, rejection markers are kept per artifact so one refusal no longer overwrites another, and the saved-content history is only preferred while the registry still sits on this session's chain of saves. * fix: Hold an Inherited Edit Until the Editor Can Save It A buffer inherited across a host change while a response was generating was marked drained before the read-only guard dropped the save, and the read-only transition then replaced it with persisted content. The drain now waits for editing to return and writes the inherited text back after that transition. * chore: Sort the Presentation Spec's Imports After the Canary Rebase * test: Prove Each Artifact Surface and Save Path End to End Covers the download of a displaced edit, a refusal per artifact, an edit after another session changed the artifact, and an edit carried through a response by a host change. * test: Give the Undocked Presentation Case the Canary Query Client * test: Start Artifact Scenarios From a Settled Reply on the Desktop Layout * test: Stub the Command Executor Stamp in the Callbacks Spec Mock Canary's #16556 calls stampCommandExecutor from callbacks.js, but this spec's @librechat/api mock predates it, so three cases failed on canary itself. The mock now carries the real helper, as it already does for isCodeArtifactToolOutput. * fix: Track What the Server Holds Per Artifact Instead of Inferring It The editor reconstructed the server's content from the mutation cache and treated every buffer as unsaved. A save now records what it wrote in a per-artifact ledger that the registry retires once it catches up, so a change made elsewhere (including a revert to an earlier value) wins over this tab's history, and text this tab already saved is never sent again by a host change or a return to the artifact. * fix: Hide the Undocked Pane While Its Conversation Route Is Pending The route keeps the previous conversation mounted but hidden while another one loads or fails to, and the undocked portal escaped that ancestry. The host now passes its pending state down and the window hides the pane with it. * fix: Mark the Saved Buffer Copy and Retire Lag the Registry Has Passed A buffer is saved only while it is the copy a save wrote, so editing away and back to the same text is still sent. Lag values the registry has already moved past are dropped in order, so a later change back to one of them is read as a change made elsewhere. * test: Drop the Callbacks Mock Stub Canary Now Carries * perf: Prune Settled Save Records When the Editing Session Ends |
||
|
|
bbb58a867e |
⛴️ fix: Preserve Canary Sync Resolutions (#16457)
Retain the tracked-file integration outcomes recorded by original canary sync PR #16457. No new implementation is introduced. Shared and ambiguous corrections are carried by the final sync-resolution commit so the resulting tracked tree equals frozen canary |
||
|
|
5b84c4b57f |
⏳ feat: Add Ephemeral Retention Mode for Forced Temporary Chats (#13811)
* feat: add ephemeral retention mode for forced temporary chats
Adds RetentionMode.EPHEMERAL, which forces every newly saved chat
temporary: hidden from history and search, given the temporary-chat
expiration, and with the toggle locked on.
Forces isTemporary and applies the temporary expiration in the normal
conversation and message save methods, routes Assistants/Threads
messages through the normal message save, applies the all-data
retention policy to file uploads and shared links, and stamps imports,
forks, and duplicates. Locks the frontend toggle and keyboard shortcut
behind an administrator-enforced badge.
The default temporary mode and the existing all mode are unchanged.
* fix: enforce ephemeral retention when resuming paused chats
* fix: preserve forced retention across pauses and assistant turns
* test: Use Real Module IDs for Installed Package Mocks
* test: Wait for Resumed Retention Persistence
* test: Control Mongo Index Setup in OpenID Fixture
* test: Close Mobile Drawer Before Retention Resume Scenario
* fix: Store Responses API Messages Under the Retention Write Context
Input and output messages were saved with the raw request, so under
ephemeral retention they missed the forced-temporary classification the
conversation received. Route both through getConversationWriteContext
and announce the stored reply as saved.
* fix: Align Resumed Responses With the Parent Retention Deadline
A resumed response was saved with a fresh forced-temporary window while
the re-stamp kept the conversation's earlier deadline, so a chat that
paused again could leave its response stored after the conversation
expired. Stamp the saved response with the parent's deadline.
* fix: Clear Released Bookmark Tags When Forcing a Chat Temporary
stampForcedRetention released a converted chat's bookmark counts but
kept its tags, so deleting that chat before TTL removal decremented the
same tags again and reduced counts owned by other visible chats. Clear
the tags in the conditional conversion update that releases them.
* fix: Store No Bookmark Tags on Forced-Temporary Imports
An ephemeral import, fork or duplicate skipped its tag count increment
but kept the source tags, so deleting the copy before TTL removal
decremented counts owned by other visible chats. Store the same tags the
import counts, which is none for a forced-temporary copy.
* test: Provide the Forced-Temporary Retention Helper to the Header Stacking Mock
* test: Reuse One Admin Login per Worker in Ephemeral Retention Scenarios
* fix: Keep Legacy Temporary Chats Temporary When Forking Under All-Data Retention
* fix: Convert a Resumed Chat Under Ephemeral Retention Before It Can Re-Pause Empty
* fix: Treat a Reloaded Pre-Policy Run as Temporary Once Retention Is Forced
* fix: Stamp Messages with the Deadline a Concurrent Retention Stamp Stored
* fix: Wait for the Startup Config Before Rebuilding a Resumed Submission
* test: Wait for the Resumed Response Row in the Ephemeral Resume Scenario
* test: Provide the Real Command Executor Stamp to the Callbacks Mock
(cherry picked from commit
|
||
|
|
e1e1d1b19d |
🎒 feat: Carry Project Context Across Conversations (#15684)
* 🎒 feat: Carry Project Context Across Conversations
* fix: fail a project attach whose upload hold cannot be released and keep file deletes independent of project cleanup
- Attaching a project file now fails, with nothing attached, when the file's
temporary upload hold cannot be released, instead of attaching a file that
can still expire.
- A failed project cleanup after a file delete is logged rather than failing a
delete that already happened, and a user-wide delete clears that user's
project references without reading every file first.
- Both resize handles share the orientation-aware grip, so a primary handle in
a vertical group renders a rotated grip like the alternate one.
* fix: treat an empty tenant id as no tenant in the project file picker
* fix: attach nothing when a project file is deleted while the attach is in flight
* fix: localize project file association failures instead of showing server text
* test: expect a localized reason for a rejected project file association
* fix: scope project file listing to the caller's tenant and name the file limit when attaching an existing file
- Listing a project's attached files now returns not found when the project
belongs to another tenant, matching the available-file listing and the
chat context resolver.
- Choosing an existing file for a full project now names the project file
limit instead of the generic attach error, like the upload path.
* fix: treat an empty tenant id as no tenant in every project tenant check
A caller whose tenant id is an empty string was refused its own tenantless
project when listing attached or available files, because the handlers
compared '' with null. The project handlers and the chat context resolver now
share one comparison that treats an empty tenant id as no tenant, the rule the
project file queries already follow.
* test: wait for the workspace layout swap and the mobile drawer before acting in the long-metadata spec
The desktop title was measured while the phone layout could still be the one
rendered, and the sidebar row menu was opened before the mobile drawer
committed its open state, which closes a menu opened ahead of it. The spec
now waits for the workspace's phone-only sidebar toggle to leave and for the
drawer to drop inert, the same drawer signal the agents helpers use.
* fix: keep the agent context fingerprint of a turn outside any project unchanged
Every turn now passes a project context key into the agent context
fingerprint, and a turn outside any project passed the no-project sentinel,
which changed the digest of every existing no-project checkpoint. An agent
event conversation written before this change then cold-started and reloaded
its history on its next event. The fingerprint now hashes the no-project key
as absent, so those checkpoints keep matching.
* test: load the long-metadata spec at phone width before driving the mobile drawer
The spec crossed back from desktop to phone width without a reload, which
leaves the drawer on the desktop toggle path whose delayed focus handoff to
the close button dismissed the row menu roughly 200ms after it opened. The
spec now reloads at phone width, as a phone arrives, and waits for the
drawer's own focus handoff before opening the menu.
(cherry picked from commit
|