Commit graph

3 commits

Author SHA1 Message Date
Marco Beretta
3d240e2b8a
🧪 fix: Close css-colors Triplet and Disabled-Recipe Rule Gaps (#17358)
* fix: Close Gaps in the css-colors Triplet Check and the Disabled-Recipe Rule

The triplet check now reads angle channels, and the disabled-recipe rule accepts spelled recipes under the same or fewer enclosing variants, resolves cva and constant class strings, and handles spread strings, per-dim primitive coverage and implied selectors.

* fix: Read Recipe Markers Anywhere in the Variant Stack and Keep Object Spreads

* test: Cover Spelled-Out Disabled Recipes in the Design Lint Scenario

* fix: Keep Stateful Arbitrary Disabled Selectors Unrestored and Order Arbitrary Enclosing Variants

* fix: Order Enclosing Variants Whenever an Arbitrary Selector Is Present

* fix: Pin the Disabled Marker Position When Arbitrary Variants Enclose a Dim

* fix: Order Child Selector Variants Like Arbitrary Ones

* fix: Skip Unplaced Disabled Variants and Read Math Functions by Token

The disabled-recipe rule now skips utilities under arbitrary variants it cannot place instead of guessing how a recipe orders against them, and unwraps TypeScript assertions on spread and class-map recipes. css-colors classifies any innermost math function by its tokens, so rounding strategies and constants no longer hide an angle-led triplet.

* fix: Read Any Fixed Math Function as a css-colors Channel

A math function over numbers and angles is a fixed channel in any position, so unit cancellation (calc(90deg / 1deg)) needs no unit algebra, and trigonometric functions and sign are fixed whatever their arguments (atan2(1px, 1px), sign(90deg)).

* fix: Unwrap Constant Class Strings and Honor Class-Map Overrides

A const initializer under as const or satisfies is read like a plain string, and a class-map recipe entry no longer counts when a later spread or the same key can overwrite it.

* fix: Keep Angle Math Results and Disjoint Spreads Out of Overrides

An angle-valued math result stays an angle, so it reads only as a leading hue, and a later object-literal spread invalidates a class-map recipe only when it sets the same key.

* fix: Place Valued data-disabled Self Selectors in disabled-recipe
2026-10-24 15:09:30 +02:00
Marco Beretta
8e60a4185a
🧱 refactor: Judge Chat Package Imports on the Resolved Module (#16975)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
Main Promotion Policy Tests / Main promotion denial and fast-forward tests (push) Waiting to run
* refactor: Judge chat imports on the resolved target with one boundary rule

scripts/eslint/chat.mjs replaces the import patterns and load selectors: every
specifier is normalized (extension, trailing slash, /index, package name)
before it is judged, across static imports, re-exports, import(), require(),
import-equals and import types, so any spelling of the /react or /components
entry or a UI package is rejected from core. A RuleTester table and a
table-driven scenario cover the spellings.

* fix: Anchor the chat boundary root to the config directory

* fix: Keep bare app paths and bare core entries behind the chat boundary

* fix: Treat aliased react paths in core as the /react entry
2026-10-11 01:06:07 +02:00
Marco Beretta
adb04422bf
🚦 feat: Lint Disabled Dims That Compose No Disabled Recipe (#16907)
* feat: Lint Disabled Dims That Compose No Disabled Recipe

* fix: Catch Bracketed Disabled Variants and Read Recipes From References

* fix: Skip Enabled-State Branches and False-Valued Disabled States

* fix: Read Full-Opacity Recipes, Primitive Recipes and Compound Conditions

* fix: Keep the Suppression Error Wording the Baseline Spec Reads

* test: Add a lint scenario for the disabled-recipe rule

* fix: Leave negated disabled selectors and conditions alone in the disabled-recipe rule

* feat: Judge disabled recipes per branch, by import and by the element they restore

* fix: Trust recipes only from the theme module and only through defaulted cva variants

* fix: Resolve namespaced recipes through their import

* fix: Read cva disabled variants, guarded recipes and trailing important in the disabled-recipe rule

* fix: Read variant dims a disabled condition picks and recipes behind the same ternary

* fix: Follow nested disabled guards and real cva defaults in the disabled-recipe rule

* fix: Trust recipes only through class helpers and string concatenation

* fix: Read cva compound variants only under compoundVariants and guard key lookups

* fix: Require the recipe that can win for the faded element in the disabled-recipe rule

* fix: Judge stacked disabled variants by their most distant element

* fix: Match recipe markers, read || polarity, compound arrays, constant class strings and helper bindings

* fix: Accept spelled recipes, default-imported primitives, inverted props and disabled-guarded recipes

* fix: Check every chosen dim, trusted helper sources, data-disabled, recipe markers and guard identity

* chore: Re-record the disabled-recipe backlog after rebasing onto dev
2026-10-10 01:47:47 +02:00