Commit graph

1786 commits

Author SHA1 Message Date
Danny Avila
6e00a9743a
⏭️ fix: Let Queued User Turns Go Before Completion Wake-ups at Run End (#18027)
* fix: Let Queued User Turns Go Before Completion Wake-ups at Run End

When a run ends with both a server-owned queued user turn and a background
or subagent completion wake-up waiting on it, the wake-up was expedited at
generation settlement while the queued turn sat out its five-second
readiness re-check, so the wake-up claimed the predecessor fence first and
the user's turn waited behind a whole automated turn.

- Generation settlement now also expedites the conversation's queued-turn
  deliveries.
- Background and subagent wake-ups defer without consuming an attempt while
  a queued turn holds an unexpired claim or is the due lane head, then run
  after it, chained to its response.
- hasPendingAgentQueuedTurn answers false for rows that need recovery or a
  user decision (reservations, expired claims, indeterminate admissions,
  dead heads awaiting dismissal), so a stuck queued turn never holds a
  wake-up. The read runs in parallel with the existing conversation read
  and fails open.
- Readiness deferral logs now carry the execution error code.

* fix: Read Queued-Turn Precedence in Claim Order and Defer on Unknown State

- Read the live claim after the head read settles, so a queued -> claimed
  transition between the two reads cannot answer false.
- Take plain identifiers in hasPendingAgentQueuedTurn and convert the user
  id inside data-schemas, keeping Mongoose types out of packages/api.
- A failed precedence read now defers the wake-up without consuming an
  attempt (QUEUED_TURN_STATE_UNAVAILABLE) instead of proceeding.

* fix: Read the Active Queued-Turn Lane in One Query

A claim released back to `queued` between the head read and the live-claim
read could still answer false. Read the reserving, queued and claimed rows
in one query over the capacity index, whose `activeSlot` key holds steady
from reservation until a terminal state, so each row is seen exactly once
in one state. Dead heads and indeterminate quarantines stay separate
indexed reads in parallel. Falls back to a planner-chosen read when the
capacity index has not been built yet.

* fix: Fall Back to a Planner Read Whenever the Lane Hint Is Refused

A hint can be refused for reasons other than a missing index on some engines. The hinted read only pins the stable key, so any refusal now retries unhinted; a genuine outage fails that read too and defers the wake-up.

* fix: Read Queued-Turn Blockers After the Turn They Block

The precedence read gathered the active lane, the dead lane head and the
indeterminate quarantine in parallel, so a blocker could be older than the
queued turn it blocked. A dead head dismissed while the reads were in flight
still answered false and let a completion wake-up race the successor it had
just unblocked.

Read the active lane first, and the blockers (a reservation, an expired
claim, an indeterminate admission, a dead row ahead of the head) only
afterwards and only for a due head, in one existence query. A blocker that
has already cleared no longer answers false, and a conversation with no due
queued turn now costs one read instead of three.
2026-11-10 14:56:41 -05:00
lia-by-librechat[bot]
c102e2d498
🦪 fix: Preserve Generated File Byte Snapshots (#18009)
* fix: Preserve Generated File Byte Snapshots

* fix: Select Snapshot Generations Before Resource Partitioning

* fix: Select Snapshot Destinations Before File Admission

* fix: Separate Snapshot Capture Identity and File Consumers

* fix: Separate Owned References and Literal Snapshot Mounts

* fix: Clean Up Unfinished Snapshots and Normalize Upload Arbitration

* fix: Keep Shared Snapshot Mounts Ahead of Private Receipts

* test: Keep Snapshot Priority Regressions Type-Safe

* fix: Preserve Literal Snapshot Paths During Legacy Recovery

* fix: Reconcile Legacy Receipt Paths Before Recovery

* fix: Reuse Fresh Unnamed Legacy Code References

* fix: Expire Snapshot Reservations Before Provisioning

---------

Co-authored-by: Lia <lia@librechat.ai>
Co-authored-by: lia-by-librechat[bot] <328778573+lia-by-librechat[bot]@users.noreply.github.com>
2026-11-10 13:45:15 -05:00
Marco Beretta
413456941c
🏓 fix: Preserve MCP Server Ping Responses (#18020)
Preserve valid empty MCP responses to immediate and repeated server pings. Keep client liveness probing unchanged. Fixes #17568.
2026-11-10 19:27:44 +01:00
lia-by-librechat[bot]
2f55f1b942
🦊 feat: Add Claude Fable 5.2 Support (#18015)
* 🦊 feat: Add Claude Fable 5.2 Support

* fix: Preserve Snapshot Version Boundaries in Model Matching

* test: Measure the Snapshot-Safe Token Matcher Search

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-10 12:54:39 -05:00
lia-by-librechat[bot]
7f2073086d
🔂 fix: Preserve Subagent Checkpoints Across Tool Approvals (#18007)
* 🔂 fix: Preserve Subagent Checkpoints Across Tool Approvals

* fix: Type Mongo Checkpoint Test Collections

* fix: Reclaim Child Checkpoints With Their Parent Conversation

* test: Seed Legacy Terminal Replay Without Publishing a Stub

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-10 12:50:16 -05:00
lia-by-librechat[bot]
d30d33a724
🖨️ fix: Preserve Concurrent PDF Extraction (#18008)
* 🖨️ fix: Preserve Concurrent PDF Extraction

* fix: Synchronize PDF Extraction Bun Lockfile

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-10 12:21:34 -05:00
Marco Beretta
91fd4b6833
🧭 perf: Validate Agent Models Against Their Own Endpoint Catalog (#17972)
* perf: Validate Agent Models Against Their Own Endpoint Catalog
* perf: Share In-Flight Model List Fetches
* test: Cover Agent Model Validation Across Endpoints
* test: Check Agent Model Catalog Parity With the Real Loaders
2026-11-10 17:33:29 +01:00
Marco Beretta
bcbb8290ec
🔌 perf: Look Up MCP Server Catalogs Concurrently for Tool Definitions (#17973)
* perf: Look Up MCP Server Catalogs Concurrently for Tool Definitions
* test: Cover MCP Sign-In Order for Concurrent Catalog Lookups
* docs: Widen the mcpCatalogLookups Comment in the Example Config
* test: Cover the Catalog Lookup Bound Passed to the Definitions Loader
2026-11-10 17:33:18 +01:00
Marco Beretta
0701ce70a7
🌿 perf: Read Only the Active Branch for Turn History (#17971)
* perf: Read Only the Active Branch for Turn History
* perf: Narrow the History Read Only When It Skips a Tenth of the Rows
* test: Cover Follow-Up Turns After a Regenerated Answer
2026-11-10 17:32:58 +01:00
Marco Beretta
9554046d5a
fix: Preserve Unknown-Provider MCP Display Images (#18000) 2026-11-10 17:29:45 +01:00
lia-by-librechat[bot]
05043fcd4e
🪒 fix: Strip Provider Attachment Payloads From Terminal Events (#18003)
* fix: strip provider attachment inputs from terminal messages

* test: use valid generated attachment metadata

* test: use generated attachment tool discriminator

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-10 11:09:05 -05:00
lia-by-librechat[bot]
b9994b9ead
🦣 fix: Honor Trace Policy in Memory Runs (#18006)
Co-authored-by: Lia <lia@librechat.ai>
2026-11-10 10:35:59 -05:00
Marco Beretta
44119f3fba
🧭 fix: Add Context Windows for Unmapped Bedrock Models (#17995)
- fix: Add Context Windows for Unmapped Bedrock Models
- fix: Price Newly Mapped Bedrock Models
- fix: Bill GPT-6.1 Terra Regional Profiles at the Regional Rate
2026-11-10 16:35:33 +01:00
lia-by-librechat[bot]
222b51cf96
🥸 fix: Block Private IPv4-Translated IPv6 Targets (#18002)
* 🥸 fix: Block Private IPv4-Translated IPv6 Targets

* fix: Accept Translated Private Address Exemptions

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-10 09:22:41 -05:00
lia-by-librechat[bot]
ea8c133c0b
🥸 fix: Resolve Directory Principals Through Trusted Integration Data (#17825)
* 🥸 fix: Resolve Directory Principals Through Trusted Integration Data

* fix: Verify Permission Principals Concurrently and Preserve Stored Groups

* fix: Refresh Stored Directory Group Membership Before Sharing

* fix: Preserve Directory Membership and Surface Principal Failures

* fix: Stage Principal Reads Before Bounded Permission Persistence

* test: Classify Historical Code Capability Name Expansion

* fix: Bound Directory Verification and Propagate Graph Denials

* test: Await Principal Collections Before Transaction Verification

* test: Isolate Theme Paint Measurements From DOM Trace Capture

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-10 09:22:08 -05:00
lia-by-librechat[bot]
e6567c7a68
📰 fix: Preview Pasted Text Without Blocking Sends (#17962)
Some checks failed
Publish `librechat-data-provider` to NPM / pack (push) Has been cancelled
Publish `@librechat/data-schemas` to NPM / pack (push) Has been cancelled
Docker Dev Images Build / publish (push) Has been cancelled
Sync Helm Chart Tags / Ignore non-main push (push) Has been cancelled
Sync Helm Chart Tags / Sync chart tags (push) Has been cancelled
Publish `librechat-data-provider` to NPM / publish-npm (push) Has been cancelled
Publish `@librechat/data-schemas` to NPM / publish-npm (push) Has been cancelled
* 📰 fix: Preview Pasted Text Without Blocking Sends

* test: Cover Paste Cleanup and Accessible Preview Text

* fix: Preserve Paste Cleanup Across Upload Races

* test: Pass Paste Identity to Draft Lock Regression

* fix: Consume Paste Replacement Chains and Enforce Upload Limits

* fix: Flatten Pending Paste Edits Onto Their Surviving Source

* fix: Transfer Recovery Ownership While Editing Pending Pastes

* fix: Persist Bounded Paste Snippets and Isolate Replay Drafts

* fix: Type File Sanitization by Its Preview Inputs

* fix: Preserve Pending Uploads Above During-Run Text Limits

* fix: Isolate Historical User Reruns From Live Paste Drafts

* fix: Restore Paste Drafts Before Persisting Composer State

* fix: Expose Paste-Only During-Run Send Controls

* test: Scope Paste Warning Assertion to Toast Viewport

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-10 08:10:21 -05:00
Marco Beretta
82f30ad9bc
🟩 fix: Add Context Windows for Bedrock NVIDIA Nemotron Models (#17952)
- Map the four NVIDIA Nemotron models on Bedrock to their AWS-documented context windows (256K for Nemotron 3 Super and Nano, 128K for the Nano v2 pair), so agents stop falling back to the 32K default that MCP tool schemas exhaust once a tool result arrives.
- Price the same models at their Bedrock on-demand rates so the context and pricing maps stay in parity.
2026-11-10 09:10:41 +01:00
Marco Beretta
ac1de5a606
📎 fix: Keep Lazily Provisioned Attachments for Code Calls After read_file (#17942)
* fix: Keep Lazily Provisioned Attachments for Code Calls After read_file
* test: Scope the read-then-bash completion text to the message view
2026-11-10 09:03:47 +01:00
dvorak33
a3868fdbe8
🖼️ fix: Bound Flux Tool Images and Preserve Original Attachments (#13749)
Bound model-facing Flux images to the 5 MiB base64 budget for standard and finetuned generation. Preserve original image data for attachment storage under the existing resolution policy.

Fixes #6954.
2026-11-09 22:41:29 +01:00
Marco Beretta
4e0f242557
⚡ fix: Parallelize Setup Cancel Lookups and Keep Attachment Drafts on Reload (#17963)
* fix: Read the Account and Session Together and Test Cancel on a Real Database

- Start the setup user and refresh session lookups together in the cancel controller instead of one after the other, as the opt-in confirmation already does
- Run the cancel controller spec on mongodb-memory-server with the real data-schemas methods, so the session and compare-and-swap predicates under test are the production ones, and add a negative case for each
- Keep only a module wiring test in the CJS controller spec, since the database behavior is now covered where it can run for real

* test: Pin the Cancel Response When the Session Lookup Fails

Both lookups now run before any cookie or write, so a failed session lookup answers 500 with the browser and the stored state untouched. Cover that on the real database.

* fix: Keep the Saved Files Draft Until the File List Loads

After a reload the live file map is empty until the server's file list arrives, and the restore that rebuilds it needs that list. The save effect rewrote the stored draft from the empty map in between, so a pasted-text chip or any other attachment was gone before it could be restored. It now waits for the list. This is what turned the composer-attachments restore scenario red on dev.
2026-11-09 21:57:01 +01:00
Marco Beretta
dc646c3880
🎚️ fix: Forward Selected Gemini Thinking Levels as reasoning_effort on Custom Endpoints (#17951) 2026-11-09 17:41:23 +01:00
Marco Beretta
876f3aad1a
🪟 fix: Serve the OAuth Error Page for Connect Callback Failures (#17946) 2026-11-09 17:41:17 +01:00
Marco Beretta
7a927fb19e
🚪 fix: Let Users Sign Out of Required Two-Factor Enrollment (#17956) 2026-11-09 17:40:50 +01:00
Marco Beretta
1c95034f93
🔗 fix: Encode Local Storage URLs and Reject Nested File Names (#17949) 2026-11-09 17:40:12 +01:00
lia-by-librechat[bot]
b4afbb3a1e
🛝 perf: Render Chats Independently of Catalog Discovery (#17692)
* 🛝 perf: Render Chats Independently of Catalog Discovery

* Preserve Target Authorization and Passive Startup Intent

* Keep Startup Selection, Readiness, and Catalog Keys Consistent

* Preserve Remembered Targets and Validate Scoped Presets

* Retain Remembered Assistant Resource Aliases Across Endpoint Switches

* Apply URL Targets Before Waiting for Send Readiness

* Fix First-Page Agent Discovery and Await Model Selection

* Preserve Spec Access and Refresh Selected Assistant State

* Preserve Builder Deletion State and Start History Reads Earlier

* fix: Preserve Startup Recovery and History Read Ownership

* fix: Retain Express Query Routing in Assistant Lookups

* fix: Prioritize Route Reads and Recover Credential Changes

* fix: Bind Credential Revocation to Its Requested Scope

* fix: Refresh Credential Metadata After Pending Key Reads

* fix: Revalidate Inactive Credential Metadata on Target Mount

* fix: Preserve Reviewed Chat Resolutions After Rebase

* fix: Resolve Dev Conflicts and Preserve Startup Boundaries

* test: Preserve the ChatView Slot Target Boundary

* fix: Defer Terminal Delivery Until Subscription Attachment Completes

* fix: Contain Deferred Terminal Callback Failures

* test: Classify Historical Tool Name Capability Reads

* fix: Activate Requested Catalogs and Isolate Provider Failures

* fix: Keep Healthy Provider Choices Available During Catalog Recovery

* test: Exclude Copied Trace Bundles From Dependency Comparison

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-09 11:11:22 -05:00
Marco Beretta
bffa50e7a8
🚦 fix: Keep the Gateway Message on Classified Rate Limit Errors (#17903)
* fix: Keep the Provider Message on Classified Rate Limit Errors

* fix: Honor maxProviderErrorChars for Classified Generation Errors

* test: Cover Classified Gateway Errors in the Mock Harness

* test: Cover a Zero Provider Detail Limit on Generation Errors

* refactor: Resolve Classified Provider Errors in the TypeScript Backend

* fix: Redact Provider Details Before Truncating Them
2026-11-09 15:44:02 +01:00
Marco Beretta
db083e1cf3
🗑️ fix: Drain Assistants Runs Before Erasing the Account (#17937) 2026-11-09 15:35:31 +01:00
Marco Beretta
70dfb8abe0
🔒 fix: Gate GET Routes That Start OAuth Flows Behind Terms Acceptance (#17935) 2026-11-09 15:35:24 +01:00
Marco Beretta
c6c79e4ea7
🔒 fix: Return Approved Error Text From the Remaining Structured Tools (#17934) 2026-11-09 15:35:18 +01:00
Marco Beretta
9bd44801ec
⏳ fix: Bound Blob Storage Image Reads by the Image Fetch Budget (#17932) 2026-11-09 15:35:11 +01:00
Marco Beretta
2855de2637
🧷 fix: Keep Agent References to File Ids Another Record Still Holds (#17931) 2026-11-09 15:35:05 +01:00
Marco Beretta
7c92a7f7d9
📜 fix: Skip Scheduled Fires for Owners Who Have Not Accepted the Terms (#17930) 2026-11-09 15:34:59 +01:00
lia-by-librechat[bot]
907589a38c
🦦 fix: Bound Spreadsheet Text Extraction (#17824)
* 🦦 fix: Bound Spreadsheet Text Extraction

* fix: Isolate Spreadsheet Parsing From Inherited Heap Flags

* fix: Configure Spreadsheet Admission and Return Retryable Overload

* fix: Return Structured Spreadsheet Limit Rejections

* fix: Preserve Spreadsheet Date Epoch During Deferred Formatting

* fix: Preserve Bounded OpenDocument Display Text

* fix: Detect UTF-16 OpenDocument Display Text

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-09 08:27:47 -05:00
lia-by-librechat[bot]
d3ca74605c
📪 fix: Require Email Delivery for Password Reset Links (#17823)
* 📪 fix: Require Email Delivery for Password Reset Links

* fix: Sanitize Recovery Delivery Errors and Handle Disabled Email

* test: Preserve Recovery Mutation State Types and Remove Obsolete Copy

* test: Enable Email Capability in Password Recovery Shape Fixtures

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-11-09 08:27:33 -05:00
Danny Avila
57ab67cbac
📏 fix: Measure Usage Percent Against the Allowance Each Period Granted (#17850)
* 📏 fix: Measure Usage Percent Against the Allowance Each Period Granted

Store the credits granted at the start of each balance period on the record and measure the usage percent against it, so changing refillAmount or startBalance no longer moves a user's percent until their next grant. Legacy records fall back to the configured amount.

* 🕰️ fix: Ignore a Stored Allotment a Later Refill Has Replaced

Stamp each stored allotment with the time of its grant and measure against it only while no refill is more recent, so a refill by a replica that predates the field falls back to the configured amount instead of reporting usage against the prior period's allowance.

* 🔒 fix: Write the Allotment Grant Atomically and Return Its Period Start

Insert lastRefill with the credit, allotment and grant time when a balance record is created, so a racing creator never moves another's period start past its grant. Return lastRefill even without auto-refill so the client can place a stored allotment in its period, and fall back when it cannot.
2026-11-09 08:27:13 -05:00
Danny Avila
23aa0f822d
🗂️ feat: Defer System Tools Behind Tool Search (#17864)
* 🎛️ fix: Treat Model Spec Tools as Defaults, Not Mandates

* 🗂️ feat: Defer System Tools Behind Tool Search
2026-11-09 08:27:01 -05:00
Marco Beretta
4c14c1eb2c
🗃️ fix: Load Retention Config on the Archive Route Before Saving (#17929) 2026-11-09 13:40:37 +01:00
Danny Avila
d875425ed2
🔐 fix: Authorize Restored MCP Tools Before Agent Revert Writes Them (#17843)
* 🔐 fix: Authorize Restored MCP Tools Before Agent Revert Writes Them

Reverting wrote the version snapshot, including its mcpServerNames, before
filterAuthorizedTools ran. Agent-scoped MCP access is granted from that index,
so a restored server vouched for itself and an editor without access to it
could re-attach it. A snapshot without mcpServerNames also left the current
index in place, keeping agent-scoped access to servers no tool used.

The handler now authorizes the restored tools against the agent as it stands,
treating only its current tools as existing, and passes the authorized tools
and rebuilt index to revertAgentVersion so the restore is one write pinned to
the revision it was checked against. revertAgentVersion always rewrites the
index for the restored tools.

* 🔐 fix: Exclude the Target Agent's Own Grant When Authorizing a Revert

Moves the restore authorization into authorizeAgentRestore in packages/api,
leaving the revert controller as wiring.

A newly restored MCP tool whose server the user reaches only through agents
must now be reachable through an agent other than the one being reverted,
checked fresh against the database. The target's current or cached index
(including one left stale by an earlier revert) no longer vouches for it.

Prior server names are matched through their normalized aliases, and only for
tools the agent already had. When nothing resolves, the pre-restore index is
kept instead of deriving names from tool keys.

A revision-filtered restore that misses is reported as a 409 conflict.

The route spec restores the real ~/config so the MCP registry is consulted
rather than reported unavailable.

* 🔐 fix: Check Newly Restored MCP Servers Against Live Grants

The restore gate now runs for every approved MCP tool, not only consumeOnly
ones. A tool the agent doesn't already have, on a DB-backed server, is
admitted when a current tool still uses that server, or on a live direct
server grant, or through another viewable agent. A grant the registry still
caches after revocation no longer becomes durable through the restored index.

Admission is memoized per server. A snapshot tools array that sanitizes to
nothing restores an explicit empty set. Active-server matching no longer
reuses the index fallback, so a stale entry is never read as in use.

* 🔐 fix: Treat Legacy Cached DB Configs as User-Sourced in the Restore Gate

A config cached before an upgrade may carry a dbId without source. The
restore gate now uses isUserSourced, so such configs get the live access
check instead of passing as operator-managed.

* 🔐 fix: Recheck Unindexed Existing MCP Tools in the Restore Gate

Holding a tool no longer exempts it from the live check. Only a current tool
whose server the agent's index already lists skips it. Otherwise an unindexed
tool on a legacy agent could pass on a revoked grant the registry still
caches, and the restore would add its server to the index.

* ⚡ perf: Run Restore Admission Checks for Distinct Servers Concurrently

filterAuthorizedTools now starts every admission check during its single pass
and awaits them together, so each distinct DB-backed server no longer adds a
serial lookup wave to the revert. Tool order is preserved and server names
are recorded only for admitted tools.
2026-11-09 07:20:31 -05:00
Atef Bellaaj
c766d07456
🔎 fix: Align Custom Anthropic Model Discovery With Native Requests (#17881)
Some checks are pending
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Vote Gate / Gate (push) Waiting to run
Codegraph E2E Votes / vote (shard 1/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 10/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 2/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 3/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 4/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 5/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 6/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 7/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 8/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 9/10) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
2026-11-09 11:02:06 +01:00
Marco Beretta
4bded120a9
🛂 fix: Only Hand Out OpenID Access Tokens the Bearer Verifier Accepts (#17904)
* fix: Only Hand Out OpenID Access Tokens the Bearer Verifier Accepts

The OpenID reuse path in refreshController and the post-refresh fallback in
getOpenIDAppAuthToken returned the cached access token as the app auth token
whenever its exp was in the future. Entra issues Microsoft Graph access tokens
to sign-in clients by default; their aud names Graph, so the bearer verifier
rejects them and every protected request answers 401 until the client loops.

Both paths now require the access token's aud to name the client id or an
OPENID_AUDIENCE entry, the same audiences the verifier accepts. The reuse path
refreshes with the IdP instead, and the post-refresh fallback keeps opaque
tokens as before. Audience parsing is shared with openIdJwtStrategy.

Related to #17791

* test: Exercise Real OpenID Audience Helpers in AuthService Spec

The AuthService spec stubbed the audience helpers as pass-throughs, so it
could not catch a foreign-audience access token escaping the post-refresh
fallback. Use the real exports and cover Graph-audience, configured-audience
and opaque access tokens through setOpenIDAuthTokens.
2026-11-08 23:40:21 +01:00
Marco Beretta
654ce897e9
🗄️ fix: Skip Attachments Deleted by Storage Retention Instead of Failing the Turn (#17910)
* fix: Skip Attachments Deleted by Storage Retention Instead of Failing the Turn

A file that storage retention removed from an earlier message made every
later turn of the conversation fail, because the encoders rethrew the
storage miss and the user has no way to remove an attachment from history.

History replay now passes a handler to the encoders, which leave missing
files out of the request and report them; the message's file context tells
the model which files were deleted and were not read. Current-turn
attachments keep the strict error, since the user can remove and re-upload
them. Code Interpreter priming names files missing from storage in the
tool context and only requires resource recovery for other failures.

* refactor: Keep Code Reupload Failure Policy in packages/api

Tally priming reupload failures in createCodeReuploadFailures so the
decision that a file deleted from storage is named instead of requiring
resource recovery lives in TypeScript, and add mock e2e scenarios for a
follow-up after an attachment is deleted from storage.

* fix: Classify Code Files as Deleted Only at the Storage Read

A 404 from the Code API upload was counted as a source file deleted from
storage, which skipped resource recovery. openCodeFileSource marks a miss
where the stored object is read, and only that error counts as deleted.

Move the history replay of attachments with tolerated misses into
replayMessageAttachments so BaseClient only calls it.

* fix: Name Local Code Files Whose Stream Reports a Missing Object

Local storage returns a read stream that raises ENOENT only once read, so
openCodeFileSource now holds a stream until its first chunk or error and
names a miss there. The missing-files context assignment moves into
setMissingCodeFilesContext so both tool loaders only call it.

* fix: Close a Held Code File Stream When Priming Is Cancelled

openCodeFileSource waits for a source stream's first chunk; when that
wait fails, as on cancellation, the caller never receives the stream, so
destroy it before rethrowing instead of leaking its file descriptor.
2026-11-08 23:38:47 +01:00
Marco Beretta
b97a973d42
📦 fix: Treat Empty Sandpack Bundler URLs as Unset (#17901)
* fix: Treat Empty Sandpack Bundler URLs as Unset

An empty SANDPACK_BUNDLER_URL or SANDPACK_STATIC_BUNDLER_URL (common with
${VAR:-} passthrough in Docker Compose) was handed to Sandpack as the
bundler URL, leaving artifact panels blank. buildSandpackOptions now falls
back to the default bundler for an empty value, and the shared-link startup
payload omits empty bundler URLs.

Related to #17790

* test: Cover Empty Sandpack Bundler URLs in Artifact Previews
2026-11-08 22:34:17 +01:00
Marco Beretta
c3d5815d50
🛰️ fix: Poll the Flux Cluster Returned by the Global Endpoint (#17907)
* fix: Poll the Flux Cluster polling_url Returned by the Global Endpoint

* fix: Only Forward the Flux Key to Same-Origin or BFL Polling URLs

* test: Cover Flux polling_url Routing in the Mock Harness
2026-11-08 22:25:36 +01:00
Marco Beretta
d3de8a4801
🧩 fix: Match mcp:<server>:<tool> Tool Approval Patterns Against MCP Tool Keys (#17902)
* fix: Match mcp:<server>:<tool> Tool Approval Patterns Against MCP Tool Keys

* fix: Normalize Globbed MCP Server Names in Tool Approval Patterns

* fix: Keep Colons Inside MCP Server Names in Tool Approval Patterns

* test: Submit the Scoped Approval and Give the Control Agent remember_fact

* fix: Match mcp:<server>:<tool> Rules Per Segment Instead of Rewriting Them

* fix: Match Glob-Free mcp: Approval Rules Against Their Exact Key

* fix: Never Grant Through a Server Glob That Normalization Widened

* fix: Never Grant a Globbed mcp: Rule on an Ambiguous Tool Key

* fix: Mirror Both Server Name Normalization Branches in mcp: Server Globs

* fix: Treat Boundary Underscores in mcp: Server Globs as Optional
2026-11-08 20:53:08 +01:00
Marco Beretta
d0d9a30327
🧩 fix: Accept Content-Array Tool Outputs in the Responses API (#17900)
* fix: Accept Content-Array Outputs in Responses function_call_output

The Open Responses spec allows function_call_output.output to be a string or
an array of input_text, input_image and input_file parts, but request
validation refused anything that was not a string. Validate the array parts
and convert them with the same part mapping the message path uses, so the
replayed tool result keeps its text and images in order.

* fix: Inspect Tool-Output Media Against File Policies

Image URLs and file names in a function_call_output content array reached the
model without the file-policy fragments the same parts get in a message.
Collect those fragments for both item types in packages/api and call that
from the Responses controller.

* test: Cover Content-Array Tool Outputs in the Responses API
2026-11-08 19:22:29 +01:00
Marco Beretta
5a633524a2
🔑 fix: Remember Tool Approvals for MCP Servers Using Env References (#17889)
* fix: Remember Tool Approvals for MCP Servers Using Env References

* fix: Resolve Approval Env Only for Tiers That Expand It, Add E2E Scenarios

* fix: Reject User Placeholders in Resolved Env Values and Take the Env Source as a Parameter

* test: Expect the Resume Reply After Approving the Env MCP Tool

* fix: Check Fully Expanded Config Values for User Placeholders

* fix: Resolve Approval Env Into a Prototype-Free Map From Own Properties
2026-11-08 16:58:10 +01:00
Marco Beretta
5440735bed
🧮 fix: Count Memory Tokens After the o200k Encoding Loads (#17892)
* fix: Count Memory Tokens After the o200k Encoding Loads

Memory create and update routes, the by-id handler, and the memory agent's
set_memory tool persisted Tokenizer.getTokenCount, which returns the UTF-8
byte length for long text while o200k_base is still loading. Await
countTokens instead so the stored tokenCount is the real count.

Related to #17842

* test: Cover Memory Token Counts Saved Before the Tokenizer Loads

* test: Mock countTokens in Memory Tool and Route Specs
2026-11-08 15:23:40 +01:00
Marco Beretta
ea584cd519
🧾 fix: Count Google Native Media Blocks in Precomputed Token Budgets (#17890)
* fix: Count Google Native Media Blocks in Precomputed Token Budgets

* test: Cover Gemini PDF context accounting in the mock harness
2026-11-08 15:01:26 +01:00
Marco Beretta
ea4d7c7e36
🪟 feat: Add Welcome Footer and Response Author Options and Tidy the Chat Chrome (#17879)
* fix: Keep the Projects Section Expanded by Default

* fix: Label the Streaming Dot With a Tooltip and an Accessible Name

* fix: Move the Welcome Screen Footer Directly Under the Composer

* fix: Drop the Agent Name From Responses When the Selector Already Shows It

* fix: Align the Sidebar Section Headings With the Date Labels

* feat: Make the Welcome Footer Placement and Response Author Configurable

* fix: Hide the Memories Panel on the Agents Route

* test: Cover the Launch QA Chat Chrome in E2E Scenarios

* test: Assert the Section Heading Padding Merge Without Mocking App Internals

* fix: Read the Response Author Setting Through the Messages Host

* test: Give the Consumer Spec's Messages Host the Author Setting
2026-11-08 14:57:59 +01:00
Marco Beretta
4a3b3a2e1a
⚖️ fix: Apply User and Group Balance Overrides on Sign-In (#17884)
* fix: Resolve User and Group Balance Overrides on Sign-In

Login routes pass the lean user document from the passport strategy, which has _id but no id, so the balance sync resolved config from the role alone and wrote role-level balance settings over user and group overrides on every login.

* test: Cover the Sign-In Balance Sync With a User Override Scenario
2026-11-08 00:07:33 +01:00