From fbca86bba953674a2998bf67082586e28bcf29b1 Mon Sep 17 00:00:00 2001 From: Marco Beretta <81851188+berry-13@users.noreply.github.com> Date: Fri, 13 Nov 2026 18:18:17 +0100 Subject: [PATCH] =?UTF-8?q?=E2=9A=99=EF=B8=8F=20fix:=20Guard=20Mongo=20Cle?= =?UTF-8?q?anup=20In=20Package=20Service=20Tests=20(#17992)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: Guard Mongo Cleanup In Package Services Tests * fix: Guard Mongo Cleanup In Agents Precedence And Promotion Tests --- packages/api/src/admin/config.keyed.integration.spec.ts | 2 +- packages/api/src/agents/precedence.integration.spec.ts | 2 +- packages/api/src/agents/steering/__tests__/promotion.spec.ts | 2 +- packages/api/src/app/resolve.integration.spec.ts | 2 +- packages/api/src/cache/__tests__/keyvMongo.spec.ts | 2 +- packages/api/src/code/environments.integration.spec.ts | 2 +- packages/api/src/code/inheritance.spec.ts | 2 +- packages/api/src/code/setup.registry.integration.spec.ts | 2 +- packages/api/src/code/setup/router.integration.spec.ts | 2 +- packages/api/src/code/setup/service.integration.spec.ts | 2 +- packages/api/src/code/targets.integration.spec.ts | 2 +- packages/api/src/conversations/save.spec.ts | 2 +- packages/api/src/crypto/credentials.spec.ts | 2 +- packages/api/src/files/finalize.database.spec.ts | 2 +- packages/api/src/files/operations.database.spec.ts | 2 +- packages/api/src/messages/parts.spec.ts | 2 +- packages/api/src/middleware/balance.spec.ts | 2 +- packages/api/src/middleware/capabilities.integration.spec.ts | 2 +- packages/api/src/middleware/checkBalance.spec.ts | 2 +- packages/api/src/projects/resources.spec.ts | 2 +- packages/api/src/pulls/oauth.spec.ts | 2 +- packages/api/src/schedules/service.spec.ts | 2 +- packages/api/src/shared-links/access.test.ts | 2 +- packages/api/src/shared-links/service.test.ts | 2 +- packages/api/src/skills/deletionService.restart.spec.ts | 2 +- packages/api/src/skills/management.spec.ts | 2 +- packages/api/src/skills/sync/github.spec.ts | 2 +- packages/api/src/user/erasure.spec.ts | 2 +- 28 files changed, 28 insertions(+), 28 deletions(-) diff --git a/packages/api/src/admin/config.keyed.integration.spec.ts b/packages/api/src/admin/config.keyed.integration.spec.ts index 89b232752e..1a05f03595 100644 --- a/packages/api/src/admin/config.keyed.integration.spec.ts +++ b/packages/api/src/admin/config.keyed.integration.spec.ts @@ -227,7 +227,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }, LIFECYCLE_TIMEOUT_MS); describe('hiding librechat.yaml custom endpoints by key', () => { diff --git a/packages/api/src/agents/precedence.integration.spec.ts b/packages/api/src/agents/precedence.integration.spec.ts index f67f563be6..072e086764 100644 --- a/packages/api/src/agents/precedence.integration.spec.ts +++ b/packages/api/src/agents/precedence.integration.spec.ts @@ -286,7 +286,7 @@ afterEach(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongod.stop(); + await mongod?.stop(); }, DB_SETUP_TIMEOUT_MS); describe('completion wake-ups and queued user turns at run end', () => { diff --git a/packages/api/src/agents/steering/__tests__/promotion.spec.ts b/packages/api/src/agents/steering/__tests__/promotion.spec.ts index 4e2bf89e03..c35528d439 100644 --- a/packages/api/src/agents/steering/__tests__/promotion.spec.ts +++ b/packages/api/src/agents/steering/__tests__/promotion.spec.ts @@ -52,7 +52,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/app/resolve.integration.spec.ts b/packages/api/src/app/resolve.integration.spec.ts index 869535251c..21d0011fc0 100644 --- a/packages/api/src/app/resolve.integration.spec.ts +++ b/packages/api/src/app/resolve.integration.spec.ts @@ -92,7 +92,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/cache/__tests__/keyvMongo.spec.ts b/packages/api/src/cache/__tests__/keyvMongo.spec.ts index 84a16333ea..c37af7e2cf 100644 --- a/packages/api/src/cache/__tests__/keyvMongo.spec.ts +++ b/packages/api/src/cache/__tests__/keyvMongo.spec.ts @@ -21,7 +21,7 @@ afterEach(async () => { }); afterAll(async () => { - await mongoServer.stop(); + await mongoServer?.stop(); }); describe('KeyvMongo key index', () => { diff --git a/packages/api/src/code/environments.integration.spec.ts b/packages/api/src/code/environments.integration.spec.ts index 97c18c1ae0..fe67088d5b 100644 --- a/packages/api/src/code/environments.integration.spec.ts +++ b/packages/api/src/code/environments.integration.spec.ts @@ -30,7 +30,7 @@ describe('code environment registry', () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/code/inheritance.spec.ts b/packages/api/src/code/inheritance.spec.ts index 08b35163c4..e35d93c756 100644 --- a/packages/api/src/code/inheritance.spec.ts +++ b/packages/api/src/code/inheritance.spec.ts @@ -117,7 +117,7 @@ describe('resolveSubagentCodeWorkspaceInheritance', () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/code/setup.registry.integration.spec.ts b/packages/api/src/code/setup.registry.integration.spec.ts index e009757919..4fe7613ec4 100644 --- a/packages/api/src/code/setup.registry.integration.spec.ts +++ b/packages/api/src/code/setup.registry.integration.spec.ts @@ -42,7 +42,7 @@ describe('staged browser setup registry', () => { }); afterAll(async () => { await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); test('explicitly enforces owner-slot uniqueness when automatic index creation is disabled', async () => { diff --git a/packages/api/src/code/setup/router.integration.spec.ts b/packages/api/src/code/setup/router.integration.spec.ts index 15a1fa6587..398af03d62 100644 --- a/packages/api/src/code/setup/router.integration.spec.ts +++ b/packages/api/src/code/setup/router.integration.spec.ts @@ -193,7 +193,7 @@ describe('browser setup HTTP protocol boundary', () => { else process.env[name] = value; } await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); function app(options: { registrationUnavailable?: boolean } = {}) { diff --git a/packages/api/src/code/setup/service.integration.spec.ts b/packages/api/src/code/setup/service.integration.spec.ts index 1d1a3cbf40..6402255d64 100644 --- a/packages/api/src/code/setup/service.integration.spec.ts +++ b/packages/api/src/code/setup/service.integration.spec.ts @@ -274,7 +274,7 @@ describe('browser setup durable lifecycle', () => { }); afterAll(async () => { await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); test('resumes immutable starts, returns the CLI approval, and idempotently completes the final owner slot', async () => { diff --git a/packages/api/src/code/targets.integration.spec.ts b/packages/api/src/code/targets.integration.spec.ts index bb33a4958a..9cbe10855e 100644 --- a/packages/api/src/code/targets.integration.spec.ts +++ b/packages/api/src/code/targets.integration.spec.ts @@ -92,7 +92,7 @@ describe('subagent code targets against the principal-scoped machine list', () = afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/conversations/save.spec.ts b/packages/api/src/conversations/save.spec.ts index 8d2afa07f6..95ce17b733 100644 --- a/packages/api/src/conversations/save.spec.ts +++ b/packages/api/src/conversations/save.spec.ts @@ -60,7 +60,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/crypto/credentials.spec.ts b/packages/api/src/crypto/credentials.spec.ts index 40a9d9c3ad..a14b12fac1 100644 --- a/packages/api/src/crypto/credentials.spec.ts +++ b/packages/api/src/crypto/credentials.spec.ts @@ -58,7 +58,7 @@ describe('getPluginAuthMap with mixed-version records', () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); it('decrypts legacy and v3 records stored for the same plugin', async () => { diff --git a/packages/api/src/files/finalize.database.spec.ts b/packages/api/src/files/finalize.database.spec.ts index 83032777b9..ba7a318ca0 100644 --- a/packages/api/src/files/finalize.database.spec.ts +++ b/packages/api/src/files/finalize.database.spec.ts @@ -21,7 +21,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/files/operations.database.spec.ts b/packages/api/src/files/operations.database.spec.ts index ae3c2df1af..f93f9e139f 100644 --- a/packages/api/src/files/operations.database.spec.ts +++ b/packages/api/src/files/operations.database.spec.ts @@ -28,7 +28,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/messages/parts.spec.ts b/packages/api/src/messages/parts.spec.ts index 5aff4bf694..67cef26c7e 100644 --- a/packages/api/src/messages/parts.spec.ts +++ b/packages/api/src/messages/parts.spec.ts @@ -156,7 +156,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongod.stop(); + await mongod?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/middleware/balance.spec.ts b/packages/api/src/middleware/balance.spec.ts index d2cbc51f57..4b39f9c1b0 100644 --- a/packages/api/src/middleware/balance.spec.ts +++ b/packages/api/src/middleware/balance.spec.ts @@ -37,7 +37,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/middleware/capabilities.integration.spec.ts b/packages/api/src/middleware/capabilities.integration.spec.ts index d2ed7e432c..2896d002a7 100644 --- a/packages/api/src/middleware/capabilities.integration.spec.ts +++ b/packages/api/src/middleware/capabilities.integration.spec.ts @@ -52,7 +52,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/middleware/checkBalance.spec.ts b/packages/api/src/middleware/checkBalance.spec.ts index 910a186ad1..04bf31dda1 100644 --- a/packages/api/src/middleware/checkBalance.spec.ts +++ b/packages/api/src/middleware/checkBalance.spec.ts @@ -483,7 +483,7 @@ describe('checkBalance', () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/projects/resources.spec.ts b/packages/api/src/projects/resources.spec.ts index c4e79cbfe0..5cf7e49354 100644 --- a/packages/api/src/projects/resources.spec.ts +++ b/packages/api/src/projects/resources.spec.ts @@ -29,7 +29,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); for (const modelName of modelsToCleanup) { if (mongoose.models[modelName]) { delete mongoose.models[modelName]; diff --git a/packages/api/src/pulls/oauth.spec.ts b/packages/api/src/pulls/oauth.spec.ts index e4f8781048..8ff91b1733 100644 --- a/packages/api/src/pulls/oauth.spec.ts +++ b/packages/api/src/pulls/oauth.spec.ts @@ -43,7 +43,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/schedules/service.spec.ts b/packages/api/src/schedules/service.spec.ts index 0cc10c3429..194769080c 100644 --- a/packages/api/src/schedules/service.spec.ts +++ b/packages/api/src/schedules/service.spec.ts @@ -2850,7 +2850,7 @@ describe('scheduled reset policy synchronization', () => { }); afterAll(async () => { await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); beforeEach(async () => { await mongoose.connection.dropDatabase(); diff --git a/packages/api/src/shared-links/access.test.ts b/packages/api/src/shared-links/access.test.ts index 56c22b0a26..05193f30dd 100644 --- a/packages/api/src/shared-links/access.test.ts +++ b/packages/api/src/shared-links/access.test.ts @@ -48,7 +48,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/shared-links/service.test.ts b/packages/api/src/shared-links/service.test.ts index db6dfd2f1b..1da6f977e3 100644 --- a/packages/api/src/shared-links/service.test.ts +++ b/packages/api/src/shared-links/service.test.ts @@ -35,7 +35,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongoServer.stop(); + await mongoServer?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/skills/deletionService.restart.spec.ts b/packages/api/src/skills/deletionService.restart.spec.ts index d6006ebb6f..eff00601b2 100644 --- a/packages/api/src/skills/deletionService.restart.spec.ts +++ b/packages/api/src/skills/deletionService.restart.spec.ts @@ -20,7 +20,7 @@ describe('Skill cleanup across a worker restart', () => { afterAll(async () => { await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); it('finishes a superseded committed upload without reporting successful cleanup as a lost claim', async () => { diff --git a/packages/api/src/skills/management.spec.ts b/packages/api/src/skills/management.spec.ts index fd0d360efd..6bbf794eb8 100644 --- a/packages/api/src/skills/management.spec.ts +++ b/packages/api/src/skills/management.spec.ts @@ -57,7 +57,7 @@ beforeAll(async () => { }); afterAll(async () => { await mongoose.disconnect(); - await server.stop(); + await server?.stop(); if (originalStrict == null) delete process.env.TENANT_ISOLATION_STRICT; else process.env.TENANT_ISOLATION_STRICT = originalStrict; }); diff --git a/packages/api/src/skills/sync/github.spec.ts b/packages/api/src/skills/sync/github.spec.ts index 3aaa1bfef2..a7c8a69585 100644 --- a/packages/api/src/skills/sync/github.spec.ts +++ b/packages/api/src/skills/sync/github.spec.ts @@ -3812,7 +3812,7 @@ describe('steady-state sync of an unchanged source', () => { afterAll(async () => { await mongoose.disconnect(); - await server.stop(); + await server?.stop(); }); beforeEach(async () => { diff --git a/packages/api/src/user/erasure.spec.ts b/packages/api/src/user/erasure.spec.ts index b68221e1da..55f5ee40bd 100644 --- a/packages/api/src/user/erasure.spec.ts +++ b/packages/api/src/user/erasure.spec.ts @@ -52,7 +52,7 @@ beforeAll(async () => { afterAll(async () => { await mongoose.disconnect(); - await mongo.stop(); + await mongo?.stop(); }); afterEach(async () => {