mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-19 06:23:32 +00:00
🐳 fix: Qualify Docker Hub Image Names in Compose Files and Dockerfiles (#17950)
* fix: Qualify Docker Hub Image Names in Compose Files and Dockerfiles Podman has no default registry, so a short image name such as mongo:8.0.20 or pgvector/pgvector:0.8.0-pg15-trixie fails with "short-name did not resolve to an alias" unless the host configures unqualified-search registries. Name docker.io on every third-party image in the compose files, the override example and the Dockerfiles, using docker.io/library/ for official images. Tags and digests are unchanged. scripts/images.test.mjs fails on any image a compose file or Dockerfile pulls without a registry host, and Static Checks runs it when one of those files changes. * test: Harden the image name scanner for indented comments and variable defaults Commented image lines are matched at any indentation, a variable with an empty default or more than one interpolation is not guessed, and a Dockerfile FROM with a default is judged by that default, as in compose files. * fix: Qualify the Channel Gateway and Mongo Replica Images The channel compose stack landed on dev with short names, which the image name test now rejects.
This commit is contained in:
parent
1da68ffa4c
commit
effcec615d
19 changed files with 259 additions and 36 deletions
13
.github/workflows/static-checks.yml
vendored
13
.github/workflows/static-checks.yml
vendored
|
|
@ -20,6 +20,13 @@ on:
|
|||
- '.github/workflows/static-checks.yml'
|
||||
- '.github/actions/mongodb-binary/**'
|
||||
- '.husky/pre-push'
|
||||
# Compose files and Dockerfiles sit outside the source trees above, and
|
||||
# the container image name test below has to run when one of them changes.
|
||||
- '**/Dockerfile*'
|
||||
- '**/*compose*.yml'
|
||||
- '**/*compose*.yaml'
|
||||
- '**/*compose*.yml.example'
|
||||
- 'rag.yml'
|
||||
- '!**.md'
|
||||
# The merge queue tests the commit about to land on dev. It has no path filter; the checks
|
||||
# below stay scoped to what the queued change touches, read against the merge group base.
|
||||
|
|
@ -218,6 +225,12 @@ jobs:
|
|||
if: steps.cache-node-modules.outputs.cache-hit == 'true' || steps.install_dependencies.outcome == 'success'
|
||||
run: npm run test:dependencies
|
||||
|
||||
# Podman has no default registry, so a short image name such as
|
||||
# `mongo:8.0.20` fails to resolve for anyone running it with Podman.
|
||||
- name: Test container image names
|
||||
if: steps.cache-node-modules.outputs.cache-hit == 'true' || steps.install_dependencies.outcome == 'success'
|
||||
run: npm run test:images
|
||||
|
||||
# The @shadcn/lint design rules read each primitive's `cva` variants through
|
||||
# the @librechat/client entry point, which resolves to packages/client/dist.
|
||||
# Without it they classify nothing and report strictly fewer violations than
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue