🕶️ fix: Unhide Event Subagent Names on the Dark Surface (#15206)

The event subagent group's child rows are raw buttons with no text color
of their own, and the section root set none either, so the agent name
labels inherited straight from the unthemed black body color — invisible
on the dark surface (and silently off-token in light mode: pure black
where --text-primary is 33 33 33). The slug and status lines carried
explicit text-text-secondary, which is why only the names vanished.

Root gets text-text-primary, matching SubagentActivity and
SubagentThreadPanel, so every descendant inherits the theme role and the
rows' secondary lines keep their explicit overrides. Verified against
the live cascade: the label computes rgb(0,0,0) in both modes today and
the token color (236/236/236 dark, 33/33/33 light) with the root themed.
This commit is contained in:
Danny Avila 2026-08-25 09:25:06 -04:00 committed by GitHub
parent 877b9b2f1a
commit e9dec7749a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 20 additions and 1 deletions

View file

@ -118,6 +118,21 @@ describe('EventSubagentActivityGroup', () => {
);
});
it('themes the group root so raw child-row buttons never inherit the unthemed body color', () => {
render(
<RecoilRoot>
<EventSubagentActivityGroup
conversationId="parent-conversation"
parentMessageIds={['parent-message']}
/>
</RecoilRoot>,
);
expect(screen.getByRole('region', { name: 'com_ui_subagent_activity' })).toHaveClass(
'text-text-primary',
);
});
it('matches the width of a parallel assistant response', () => {
render(
<RecoilRoot>

View file

@ -155,7 +155,11 @@ function EventSubagentRows({
return (
<section
aria-label={localize('com_ui_subagent_activity')}
className="my-2 overflow-hidden rounded-lg border border-border-light bg-surface-secondary/40"
/** `text-text-primary` on the root, like `SubagentActivity` and
* `SubagentThreadPanel`: the child rows are raw buttons that inherit
* their label color, and without a themed ancestor they bottom out at
* the unthemed black body color invisible on the dark surface. */
className="my-2 overflow-hidden rounded-lg border border-border-light bg-surface-secondary/40 text-text-primary"
data-event-subagent-group={eventChildren[0]?.parentMessageId}
>
<Button