From e714aba067484e34ac3a7f0bd8077f7dccc8ac04 Mon Sep 17 00:00:00 2001
From: Marco Beretta <81851188+berry-13@users.noreply.github.com>
Date: Sat, 14 Nov 2026 17:01:27 +0100
Subject: [PATCH] =?UTF-8?q?=E2=8F=B3=20refactor:=20Render=20the=20Pending?=
=?UTF-8?q?=20Turn=20and=20Steers=20From=20@librechat/chat=20by=20Default?=
=?UTF-8?q?=20(#18134)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
- refactor: Render Pending Turn and Steers from the Package
- refactor: Keep Package Pending Rows Inert Without a Steer Host
- fix: Read the Host Thread Mode on Every Render
- fix: Point the Hosts Guard at the Messages Loader
- fix: Follow the Moved Pending Rows in the Guard and Lazy Chunk Specs
- fix: Ship Message Body Typography With the Shared Theme Styles
- fix: Keep the App Message Typography Cascade With the Shared Styles
---
.github/guard-specs.json | 10 +-
client/src/Providers/MessagesHostContext.tsx | 2 +
client/src/__tests__/hosts.test.tsx | 12 +-
.../__tests__/messageContentCascade.spec.ts | 47 ++++
.../Composer/__tests__/semanticTokens.spec.ts | 2 +-
.../Input/__tests__/QueuedTurnPortal.spec.tsx | 29 ++-
.../components/Chat/Messages/PendingTurn.tsx | 63 -----
.../Messages/__tests__/PendingTurn.spec.tsx | 125 ---------
.../Chat/Messages/__tests__/load.spec.tsx | 9 +-
client/src/components/Chat/Messages/load.tsx | 11 +-
client/src/components/Chat/Messages/slots.tsx | 12 -
.../Chat/__tests__/ChatView.slots.spec.tsx | 55 +---
.../Chat/__tests__/ChatView.subagent.spec.tsx | 9 +-
client/src/style.css | 3 +
client/test/inertSteerHost.ts | 34 +++
client/test/messagesHost.tsx | 1 +
.../mock/scenarios/lazy-surfaces.spec.ts | 8 +-
.../chat/src/__fixtures__/messagesHost.ts | 1 +
packages/chat/src/__fixtures__/steerHost.ts | 39 +++
packages/chat/src/components.ts | 2 +
.../src/components/messages/MessagesView.tsx | 40 ++-
.../components/messages}/PendingSteers.tsx | 129 +++++-----
.../src/components/messages/PendingTurn.tsx | 62 +++--
.../messages/__tests__/MessagesView.spec.tsx | 64 +++--
.../messages/__tests__/PendingSteers.spec.tsx | 240 +++++++++++-------
.../messages/__tests__/PendingTurn.spec.tsx | 113 ++++++++-
.../__tests__/pendingDefaults.spec.tsx | 123 +++++++++
.../messages/thread/__tests__/Thread.spec.tsx | 28 +-
.../pane/__tests__/messages.spec.tsx | 4 +-
.../chat/src/components/pane/messages.tsx | 11 +-
packages/chat/src/react.ts | 2 +-
packages/chat/src/react/messages/host.tsx | 4 +
.../src/react/steer/__tests__/host.spec.tsx | 16 +-
packages/chat/src/react/steer/host.tsx | 8 +-
packages/chat/test/consumer.spec.tsx | 25 +-
packages/client/src/theme/parts.css | 11 +
packages/client/src/theme/parts.spec.ts | 15 ++
37 files changed, 844 insertions(+), 525 deletions(-)
create mode 100644 client/src/__tests__/messageContentCascade.spec.ts
delete mode 100644 client/src/components/Chat/Messages/PendingTurn.tsx
delete mode 100644 client/src/components/Chat/Messages/__tests__/PendingTurn.spec.tsx
delete mode 100644 client/src/components/Chat/Messages/slots.tsx
create mode 100644 client/test/inertSteerHost.ts
create mode 100644 packages/chat/src/__fixtures__/steerHost.ts
rename {client/src/components/Chat/Messages/Content/Parts => packages/chat/src/components/messages}/PendingSteers.tsx (72%)
rename client/src/components/Chat/Messages/Content/Parts/__tests__/PendingSteers.test.tsx => packages/chat/src/components/messages/__tests__/PendingSteers.spec.tsx (72%)
create mode 100644 packages/chat/src/components/messages/__tests__/pendingDefaults.spec.tsx
create mode 100644 packages/client/src/theme/parts.spec.ts
diff --git a/.github/guard-specs.json b/.github/guard-specs.json
index 3de890b08e..64aea283bb 100644
--- a/.github/guard-specs.json
+++ b/.github/guard-specs.json
@@ -24,17 +24,22 @@
"client/src/__tests__/hosts.test.tsx": [
"client/src/App.jsx",
"client/src/components/Chat/Messages/hosts.ts",
- "client/src/components/Chat/Messages/slots.tsx",
+ "client/src/components/Chat/Messages/load.tsx",
"client/src/components/Chat/Presentation.tsx",
"client/src/routes/ShareRoute.tsx",
"client/src/routes/Search.tsx"
],
+ "client/src/__tests__/messageContentCascade.spec.ts": [
+ "client/src/style.css",
+ "packages/client/src/theme/parts.css"
+ ],
"client/src/__tests__/loadingCanvas.spec.ts": ["client/index.html"],
"client/src/__tests__/loadingSpinner.spec.tsx": ["client/index.html"],
"client/src/components/Chat/Input/Composer/__tests__/semanticTokens.spec.ts": [
"client/src/components/Chat/",
"client/src/hooks/Input/usePaletteEntries.tsx",
- "packages/chat/src/components/composer/"
+ "packages/chat/src/components/composer/",
+ "packages/chat/src/components/messages/PendingSteers.tsx"
],
"client/src/components/Chat/Input/__tests__/appearanceTokens.spec.ts": [
"client/src/components/Chat/Input/",
@@ -79,6 +84,7 @@
],
"packages/client/src/components/__tests__/radixLayers.spec.ts": ["package-lock.json"],
"packages/client/src/theme/defaults.spec.ts": ["packages/client/src/theme/defaults.css"],
+ "packages/client/src/theme/parts.spec.ts": ["packages/client/src/theme/parts.css"],
"packages/client/src/theme/primitives.spec.ts": [
"eslint-suppressions.json",
"packages/client/src/components/"
diff --git a/client/src/Providers/MessagesHostContext.tsx b/client/src/Providers/MessagesHostContext.tsx
index c9b5a75993..71885661d1 100644
--- a/client/src/Providers/MessagesHostContext.tsx
+++ b/client/src/Providers/MessagesHostContext.tsx
@@ -32,6 +32,7 @@ import useConversationSeenSource from '~/hooks/Conversations/seenSource';
import useGetAddedConvo from '~/hooks/Conversations/useGetAddedConvo';
import { useOptionalMessagesOperations } from './MessagesViewContext';
import { PrivateText } from '~/components/Chat/Messages/PrivateText';
+import { FLAT_THREAD } from '~/components/Chat/Messages/Thread/flag';
import MessageAudio from '~/components/Chat/Messages/MessageAudio';
import { useAssistantsMapContext } from './AssistantsMapContext';
import MessageIcon from '~/components/Chat/Messages/MessageIcon';
@@ -156,6 +157,7 @@ export const appMessagesHost: MessagesHost = {
useSeenSource: useConversationSeenSource,
renderMessageIcon: (props) =>
- {String(messages)} {slots === mockSlots ? 'app slots' : 'no slots'} + {String(messages)} {slots == null ? 'package defaults' : 'app slots'}
); } @@ -34,7 +33,7 @@ describe('message list loader', () => { mockLoadScreenMessages.mockReset(); }); - it('draws the package list with the app slots once both have loaded', async () => { + it('draws the package list once its hosts have loaded', async () => { mockLoadScreenMessages.mockResolvedValue({ default: PackageList }); const { renderMessages } = loadModule(); @@ -45,7 +44,7 @@ describe('message list loader', () => { ); expect(screen.getByRole('status')).toBeInTheDocument(); - expect(await screen.findByText('null app slots')).toBeInTheDocument(); + expect(await screen.findByText('null package defaults')).toBeInTheDocument(); }); it('loads the list once for every caller', async () => { diff --git a/client/src/components/Chat/Messages/load.tsx b/client/src/components/Chat/Messages/load.tsx index 5a6d75c138..b022434e62 100644 --- a/client/src/components/Chat/Messages/load.tsx +++ b/client/src/components/Chat/Messages/load.tsx @@ -9,19 +9,14 @@ type MessagesModule = { default: ComponentType