CERBERUS/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2026-08-27 12:13:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

fix: require explicit skills toggle + treat partial cache as miss

Browse source 
- initialize.js: change ephemeralSkillsToggle !== false to === true
  (unset toggle no longer enables skills)
- primeSkillFiles cache: require ALL files to have codeEnvIdentifier
  before using cache (partial persistence = cache miss = re-upload)
- primeInvokedSkills cache: same check (allFilesWithIds.length must
  equal total file count)
This commit is contained in:
Danny Avila 2026-04-14 21:28:52 -04:00
parent ee8bd4b99f
commit e4bfa0a5be
2 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
api/server/services/Endpoints/agents/initialize.js
View file

@ -202,7 +202,7 @@ const initializeClient = async ({ req, res, signal, endpointOption }) => {
const enabledCapabilities = new Set(appConfig?.endpoints?.[EModelEndpoint.agents]?.capabilities);
const ephemeralSkillsToggle = req.body?.ephemeralAgent?.skills;
const skillsCapabilityEnabled =
enabledCapabilities.has(AgentCapabilities.skills) && ephemeralSkillsToggle !== false;
enabledCapabilities.has(AgentCapabilities.skills) && ephemeralSkillsToggle === true;
const accessibleSkillIds = skillsCapabilityEnabled
? await findAccessibleResources({
userId: req.user.id,

21
packages/api/src/agents/skillFiles.ts
View file

@ -88,16 +88,17 @@ export async function primeSkillFiles(
const files: PrimeSkillFilesResult['files'] = [];
const sessionId = firstWithId.codeEnvIdentifier.split('/')[0];
// SKILL.md doesn't have a codeEnvIdentifier; find it by name convention
// (it was uploaded with the batch and shares the session)
for (const sf of skillFiles) {
if (sf.codeEnvIdentifier) {
const [sid, fid] = sf.codeEnvIdentifier.split('/');
// All files must have identifiers for the cache to be complete.
// Any missing identifier means partial persistence — fall through to re-upload.
const allHaveIds = skillFiles.every((sf) => sf.codeEnvIdentifier);
if (allHaveIds) {
for (const sf of skillFiles) {
const [sid, fid] = (sf.codeEnvIdentifier as string).split('/');
files.push({ id: fid, session_id: sid, name: `${skill.name}/${sf.relativePath}` });
}
}
if (files.length > 0) {
if (allHaveIds && files.length > 0) {
logger.debug(
`[primeSkillFiles] Session still active for skill "${skill.name}", reusing ${files.length} files`,
);
@ -282,11 +283,11 @@ export async function primeInvokedSkills(
// ALL distinct sessions for freshness. If all are active, return cached
// references with zero re-uploads. If any expired, re-upload everything.
if (deps.getSessionInfo && deps.checkIfActive) {
const allFilesWithIds = fileListResults
.flatMap((r) => r.files)
.filter((f) => f.codeEnvIdentifier);
const allFiles = fileListResults.flatMap((r) => r.files);
const allFilesWithIds = allFiles.filter((f) => f.codeEnvIdentifier);
if (allFilesWithIds.length > 0) {
// Only use cache when ALL files have identifiers (no partial persistence)
if (allFilesWithIds.length > 0 && allFilesWithIds.length === allFiles.length) {
const sessionIds = new Set(allFilesWithIds.map((f) => f.codeEnvIdentifier!.split('/')[0]));
const checkResults = await Promise.all(